Bug 113811 - FILESAVE: dialogs are not preserved in flat ODS file
Summary: FILESAVE: dialogs are not preserved in flat ODS file
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.1.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: dataLoss
: 126772 (view as bug list)
Depends on:
Blocks: ODF-Flat
  Show dependency treegraph
 
Reported: 2017-11-13 21:50 UTC by Mátyás Jani
Modified: 2024-09-04 14:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
ods file containing a single dialog (7.87 KB, application/vnd.oasis.opendocument.spreadsheet)
2017-11-13 21:50 UTC, Mátyás Jani
Details
fods file produced by saving the above ods file, the dialog is not listed in the file (20.17 KB, application/vnd.oasis.opendocument.spreadsheet-flat-xml)
2017-11-13 21:52 UTC, Mátyás Jani
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mátyás Jani 2017-11-13 21:50:22 UTC
Created attachment 137727 [details]
ods file containing a single dialog

Reproduce:
Create a new localc sheet, create a dialog (Tools -> Macros -> Organize Dialogs).
Save the file as .ods, then reopem the file: the dialog is there.
Save the file as .fods, and reopen the file: the dialog is not present anymore.

This bug possibly affects other applications as well.
Comment 1 Mátyás Jani 2017-11-13 21:52:05 UTC
Created attachment 137728 [details]
fods file produced by saving the above ods file, the dialog is not listed in the file
Comment 2 Mohamed 2017-11-14 01:00:08 UTC
Issue not reproduced, the created dialog appears in both files.
Tested on:
    • Operating system: Windows 8.1 Pro 64-bits.
    • LibreOffice: Version: 5.4.3.2 (x64)
      Build ID: 92a7159f7e4af62137622921e809f8546db437e5
      CPU threads: 4; OS: Windows 6.29; UI render: default; 
      Locale: en-US (en_US); Calc: group

And also on:
    • Operating system: Ubuntu 16.04.3 64-bits.
    • LibreOffice :Version: 5.4.3.2
      Build ID: 92a7159f7e4af62137622921e809f8546db437e5
      CPU threads: 8; OS: Linux 4.4; UI render: default; VCL: gtk2; 
      Locale: en-US (ja_JP.UTF-8); Calc: group
Comment 3 Mátyás Jani 2017-11-14 08:19:54 UTC
Thanks for testing it. It does not work on:

    • Operating system: Arch linux
    • package: libreoffice-fresh-5.4.3-1-x86_64
    • Version: 5.4.3.2
      Build ID: 5.4.3-1
      CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: kde4; 
      Locale: en-US (en_US.UTF-8); Calc: group

Also not working on:
    • Operating system: Arch linux
    • package: libreoffice-still-5.3.7-5-x86_64
    • Version: 5.3.7.2.0+
      Build ID: 5.3.7-5
      CPU Threads: 4; OS Version: Linux 4.13; UI Render: default; VCL: kde4; Layout Engine: new; 
      Locale: en-US (en_US.UTF-8); Calc: group

Might be an Arch or kde related issue after all.
Comment 4 Mátyás Jani 2017-11-14 11:32:33 UTC
Tested, fails (created dialog do not appear in fods file):
    • Ubuntu 16.04 LTS 64-bit
    • Version: 5.1.6.2
      Build ID: 1:5.1.6~rc2-0ubuntu1~xenial2
      CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
      Locale: en-US (en_US.UTF-8); Calc: group
Comment 5 Mátyás Jani 2017-11-14 20:54:25 UTC
Fails on:
    • Windows 7 64-bit
    • Version: 5.3.6.1
      Build ID: 686f202eff87ef707079aeb7f485847613344eb7
      CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; 
      Locale: en-US (en_US); Calc: group

Looks like it's not an Arch or KDE issue after all :)
Comment 6 Mohamed 2017-11-15 02:17:11 UTC
Thank you for the reply, could you please mention detailed steps to reproduce, so I can follow it one by one.
Comment 7 raal 2017-11-15 16:07:27 UTC
I can confirm with Version: 6.0.0.0.alpha1+
Build ID: c79467ba954987f1d239c594c1e1b3af3f5515f6
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 
and Version 4.1.0.0.alpha0+
Comment 8 Mátyás Jani 2017-11-15 19:55:21 UTC
(In reply to Mohamed from comment #6)
> Thank you for the reply, could you please mention detailed steps to
> reproduce, so I can follow it one by one.

Hi, sorry for the delay, detailed steps below (English UI):
1) Start localc, with a new, empty spreadsheet
2) Tools -> Macros -> Organize Dialogs...
3) In the list under the text "Dialog:" select the bottom-most entry corresponding to your spreadsheet (eg. "Untitled 1" )
4) Click on New... on the right side, then click OK
   It will create the dialog ("Dialog1")
5) Close this window and save the file
   a) as a normal .ods file,
   b) as a flat .fods file
7) Close localc
8) Start localc, if you load the .fods file, and navigate to Tools -> Macros -> Organize Dialogs..., your dialog will be missing
   If you open the .ods file, it will be there

Also if you uncompress the .ods file, you can find the corresponding xml file:
$ unzip -l Untitled\ 1.ods | grep Dialog1
      349  2017-11-15 19:49   Dialogs/Standard/Dialog1.xml

But it is not in the .fods file:

$ cat Untitled\ 1.fods | grep -c Dialog1
0

Thanks!
Comment 9 QA Administrators 2019-05-22 02:52:50 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2021-05-22 04:23:13 UTC Comment hidden (obsolete)
Comment 11 Mike Kaganski 2022-04-20 10:06:34 UTC
*** Bug 126772 has been marked as a duplicate of this bug. ***
Comment 12 QA Administrators 2024-04-20 03:15:33 UTC Comment hidden (obsolete)
Comment 13 linux 2024-09-04 14:09:03 UTC
Hi,

I can confirm this Bug with LibreOffice Version Version: 24.8.0.3 (X86_64) on Windows 10 X86_64.

I happens in Calc and also Writer.

It is not just the conversion to fodt/fods that fails. 
If you open a fodt/fods, add a Dialog and then save it, they Dialog
just disappears. So it seems that the flat format does ignore Dialogs when saving.
Comment 14 linux 2024-09-04 14:15:14 UTC
I would suggest to change the importance to "major" since it is a data loss without any error message whatsoever to the user. This means when using the flat format you can spend ours creating dialogs, saving and then some days later you open the file again and notice that all your work has gone.

The flat format is also very important, if you want to modify the file by a program, because it is much easier to deal with (just one file instead of a fine adjusted web of files). So it also gives a false impression of the abilities, if you have a flat format but then at some random places appears data-loss.
Comment 15 raal 2024-09-04 14:20:59 UTC
Version is the oldest tested.