Bug 113860 - Selecting a recent or favorite special character is not applied by OK in bullets and numbering dialog
Summary: Selecting a recent or favorite special character is not applied by OK in bull...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: kurtaazz
URL:
Whiteboard: target:6.1.0 target:6.0.7 target:6.0.6
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
: 118531 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-15 16:06 UTC by Tamás Zolnai
Modified: 2018-07-25 23:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tamás Zolnai 2017-11-15 16:06:40 UTC
Description:
We can specify any character as bulleting symbol on Customize tab page of bulleting character. The issue is that on the Special Character dialog there are a recent and favorite list of items which are not applied if I select one of these items and click OK.

Steps to Reproduce:
1. Open Impress
2. Click into title shape
3. Open numbering dialog (context menu -> Bullets and Numbering... -> Customize)
4. Click on custom character selection button (Characeter: Selection...)
5. Select a character from favorite or recent list of items and click OK

Actual Results:  
The selected character is not applied.

Expected Results:
The bulleting symbol should be changed to the selected character.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
Comment 1 Tamás Zolnai 2017-11-15 16:10:51 UTC
Let's turn this into an easy hack. The code is here:
cui/source/dialogs/cuicharmap.cxx

I would suggest to check how this dialog (SvxCharacterMap) is opened and what the caller code does after the dialog is closed by OK.
Comment 2 Commit Notification 2017-11-27 01:04:00 UTC
Mark Vecsernyes committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb384cf3792e3efc2473f26eee86b335804f2f9b

tdf#113860 - Selecting a recent or favorite special character is not applied

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Buovjaga 2018-07-15 15:41:08 UTC
*** Bug 118531 has been marked as a duplicate of this bug. ***
Comment 4 Buovjaga 2018-07-18 11:32:44 UTC Comment hidden (obsolete)
Comment 5 muso 2018-07-18 11:37:34 UTC
This bug is still in LO 6.0.5. Please backport the fix to the 6.0.x series as well.
Comment 6 Xisco Faulí 2018-07-18 13:16:59 UTC
(In reply to muso from comment #5)
> This bug is still in LO 6.0.5. Please backport the fix to the 6.0.x series
> as well.

Cherry-picked to 6-0 in https://gerrit.libreoffice.org/#/c/57645/
Comment 7 Commit Notification 2018-07-25 22:41:01 UTC
Mark Vecsernyes committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=39bf66b0384182970939334c98743551e7e95910&h=libreoffice-6-0

tdf#113860 - Selecting a recent or favorite special character is not applied

It will be available in 6.0.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2018-07-25 23:50:52 UTC
Mark Vecsernyes committed a patch related to this issue.
It has been pushed to "libreoffice-6-0-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=107ae269fc0807bb877f4a06281a8ac5ef167efe&h=libreoffice-6-0-6

tdf#113860 - Selecting a recent or favorite special character is not applied

It will be available in 6.0.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.