Bug 113946 - FILEOPEN: DOCX: WPS drawing in wrong position
Summary: FILEOPEN: DOCX: WPS drawing in wrong position
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Patrick Jaap
URL:
Whiteboard: target:6.1.0 target:6.0.0 target:6.0.1
Keywords: filter:docx
: 96219 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-20 09:52 UTC by Patrick Jaap
Modified: 2020-05-20 11:29 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file with a WPS line (13.57 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2017-11-20 09:53 UTC, Patrick Jaap
Details
comparison LibreOffice 6.0 and MSO 2010 with a wider line (20.45 KB, image/png)
2017-11-20 17:01 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Jaap 2017-11-20 09:52:50 UTC
Description:
Sample file contains a small line in the first paragraph of text, LO Writer places it a lines below this position.

Steps to Reproduce:
1. Open the sample file in Writer

Actual Results:  
Line is placed to deep in the document.

Expected Results:
Line is placed in the first paragraph.


Reproducible: Always


User Profile Reset: No



Additional Info:
This may be related to
https://bugs.documentfoundation.org/show_bug.cgi?id=112450

but the bug is a little bit different.


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Comment 1 Patrick Jaap 2017-11-20 09:53:24 UTC
Created attachment 137868 [details]
sample file with a WPS line
Comment 2 Xisco Faulí 2017-11-20 16:59:28 UTC
Confirmed in

- Version: 6.0.0.0.alpha1+
Build ID: 637d96a25926e299fff5b4cf5a0055b1d171b23b
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: th-TH (ca_ES.UTF-8); Calc: group

- Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

- Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

but I don't see it in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 3 Xisco Faulí 2017-11-20 17:01:16 UTC
Created attachment 137874 [details]
comparison LibreOffice 6.0 and MSO 2010 with a wider line
Comment 4 Patrick Jaap 2017-11-27 14:44:05 UTC
I figured out what is causing the problem:

The vertical position is given relative to top margin. In MSO this is the top of the page. In LO this seems to be the top of the text area. Manually changing the position in LO relative to "entire page" yields correct results.
Comment 5 Patrick Jaap 2018-01-15 16:17:14 UTC
There is a patch on gerrit:

https://gerrit.libreoffice.org/#/c/47905/
Comment 6 Commit Notification 2018-01-21 21:59:17 UTC
Patrick Jaap committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ff8826d438a9fd080e8e61f8e66b3d3b2c8d752b

tdf#113946 add 'topMargin' to GraphicHelpers import

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Luke 2018-01-22 07:22:42 UTC
*** Bug 96219 has been marked as a duplicate of this bug. ***
Comment 8 Commit Notification 2018-01-23 21:03:10 UTC
Patrick Jaap committed a patch related to this issue.
It has been pushed to "libreoffice-6-0-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc8665445e81891eafcbe8a25a5b5b80db330375&h=libreoffice-6-0-0

tdf#113946 add 'topMargin' to GraphicHelpers import

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2018-01-23 22:28:44 UTC
Patrick Jaap committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ada232a67fbb3acf60b104a4916719dbdb891819&h=libreoffice-6-0

tdf#113946 add 'topMargin' to GraphicHelpers import

It will be available in 6.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.