Bug 114194 - RTL: Keyboard navigation between textboxes not in logical order in various slide layouts
Summary: RTL: Keyboard navigation between textboxes not in logical order in various sl...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: RTL-CTL a11y Slide-Layout
  Show dependency treegraph
 
Reported: 2017-12-01 10:11 UTC by Yousuf Philips (jay) (retired)
Modified: 2019-07-31 11:57 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
correct order (18.27 KB, image/png)
2017-12-01 10:11 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-12-01 10:11:40 UTC
Created attachment 138165 [details]
correct order

Similar to the incorrect tab navigation order mentioned in bug 101014, this order doesn't change when in a RTL locale, which is also incorrect as its using the same order as if RTL wasnt enabled.

It is likely that the placeholder textboxes arent being placed on the slide in an RTL order and RTL text direction is only being set to the textboxes.
Comment 1 Eyal Rozenberg 2017-12-20 20:35:23 UTC
Can you please attach a document corresponding to the existing attachment?
Comment 2 Yousuf Philips (jay) (retired) 2017-12-21 11:40:43 UTC
(In reply to Eyal Rozenberg from comment #1)
> Can you please attach a document corresponding to the existing attachment?

steps:
1. open impress in RTL locale
2. set slide to 'Title, 2 Content and Content' or 'Title, 4 Content'
3. For 'Title, 2 Content and Content', it should look like 'Title, Content and 2 Content' when in RTL and vise-versa
4. For 'Title, 4 Content' the tab order should go similar to attachment 138165 [details] but isnt
Comment 3 Eyal Rozenberg 2018-09-17 19:52:54 UTC
I still don't understand what I should be seeing as opposed to what's expected. What do you mean by "order"? The visual order is what it is. Do you mean the order in the XML? Please be clearer.
Comment 4 Xisco Faulí 2018-10-18 10:39:58 UTC
(In reply to Eyal Rozenberg from comment #3)
> I still don't understand what I should be seeing as opposed to what's
> expected. What do you mean by "order"? The visual order is what it is. Do
> you mean the order in the XML? Please be clearer.

Hello Jay,
Could you please answer the question above in order to help us triage this issue?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the question has been answered
Comment 5 Yousuf Philips (jay) (retired) 2018-10-18 18:40:32 UTC
(In reply to Eyal Rozenberg from comment #3)
> I still don't understand what I should be seeing as opposed to what's
> expected. What do you mean by "order"? The visual order is what it is. Do
> you mean the order in the XML? Please be clearer.

Based on the fix in bug 101014, this keyboard tab order issue that is incorrect for RTL is in the XML.
Comment 6 Eyal Rozenberg 2019-07-31 11:57:04 UTC
Ok, so I understand what Yousuf means now.

I reproduced as follows:

1. Open impress with an RTL locale set
2. Access the Slide menu: Either Right-click the slide background in the main pane; or right-click the slide sequence pane; or go to Slide on the main menu bar.
3. In the Slide menu, choose Slide Layout > Title, 4 Content
4. In the Slide menu, choose Properties
5. In the Page tab, set Text Direction to RTL
6. Create a New Slide (e.g. using the Slide Menu); 
7. Examine the new slide's tab order:
   7.1 Mouse-press the circumference of one of the title area; it becomes highlighted.
   7.2 Press Tab several times; the highlight moves from the title box to a content box, then to another etc.

Note: Step 6 is only there to avoid the dilemma of whether potentially-altering a slide's text direction should change the tab order of already-created elements.

Expected result: The tab order should be: Title, top right box, top left box, bottom right box, bottom left box. (Another reasonable order could have bee Title, top right, bottom right, top left, bottom left but let's forget about that.) That is illustrated in attachment 138165 [details].

Actual result: The tab order is: Title, top left box, top right box, bottom left box, bottom right box. 

Reproduced with:
Version: 6.3.0.1
Build ID: 1:6.3.0~rc1-2
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: he-IL (en_IL); UI-Language: en-US
Calc: threaded