During the removal of the tools types, the ULONG type was converted to the sal_uLong type. This is just a stop-gap, and every use of sal_uLong should be reviewed and replaced by an appropriate unsigned integer type, depending on the situation sal_uInt32, sal_uInt64, size_t or "unsigned int" are likely candidates. for an example see this commit, where positions of a SvStream are converted, so sal_uInt64 is the correct type because files can be larger than 4GB. https://cgit.freedesktop.org/libreoffice/core/commit/?id=05d3a1899eb50202fd3929b702bae1003b5610be
Hello, I am a newbie and wish to work on this bug,
Hey Michael, can you tell me in which file "sal_uLong" is used and has to be reviewed and replaced with appropriate integer types?
Hi Shobitha: $ git grep sal_uLong is a great tool here. In which files ? I guess any files - but I would start with a small commit to somewhere where there are no virtual methods or overrides to confused the picture. HTH.
> git grep sal_uLong | wc -l 4988 it doesn't make sense to have this bug assigned to only one developer, lots of people can work in parallel without stepping on each other's toes.
May you please tell how to review which data type is needed . It is very difficult to find the function calls etc to get an idea.
@Sourabh, as Michael said in comment 4, no need to assign it to yourself...
Shubham Verma committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b49701fa5c22abba6b9b4a60ddd2720973dd858 tdf#114441 sal_uLong to better integer types It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bijan Tabatabai committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5857555e129a5913352cd7e8c7e825dd6892d808 tdf#114441 Convert sal_uLong to other types in ./sc/source/ui/app It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caio B. Silva committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a93c71a97975c0b3f8fceae86fa2bd598a9eae59 tdf#114441 Replacing sal_uLong with most appropriate integer types It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi Michael, I am Komal. I am novice to open source. But really interested to learn and contribute for this organization. I went through this issue description and I made changes to one of the file ./sw/inc/pvprtdat.hxx. But I was confused about how to commit the changes. I have committed it on libreoffice/core repository on github. Is that valid? I'm sorry if I have done anything wrong. Thank you!
(In reply to Komal from comment #10) https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch
(In reply to himajin100000 from comment #11) > (In reply to Komal from comment #10) > > https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch Thank You! I will check that out Is the github repository obsolete now?
on github libreoffice/core repository it clearly says "Read-only LibreOffice core repo - no pull request". We never used github for LibreOffice development, it's just a mirror.
(In reply to Tomaz Vajngerl from comment #13) > on github libreoffice/core repository it clearly says "Read-only LibreOffice > core repo - no pull request". > > We never used github for LibreOffice development, it's just a mirror. I am so sorry for creating this nuissance! Its very silly of me! Thanks!
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0515ffdb2e4c975f1d19257dfed2a24ff3cbfdb4%5E%21 tdf#114441 Convert use of sal_uLong to sal_uInt32 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
https://git.libreoffice.org/core/+/bd32bf4deb7a2ae9d790a10b5c8af6ea33b7c127%5E%21
Komal committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/de1a23288ff6e4d7228fd8d7920b37b570df8f9a%5E%21 tdf#114441,Change in the data type to sal_Int32 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Salih Sariyar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/006734562be1fec6b8fa4ff291c51b6043265653%5E%21 tdf#114441: Convert use of sal_uLong to better integer types It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Muzaffer Kadir YILMAZ committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b9e75051807b807a6c9b96433390e09abaf38c24%5E%21 tdf#114441 - Convert variables use Tell() function sal_uLong to sal_uInt64 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Christian Barth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/261fa8cdf4626c9785e0ca4776e44eab4b9222e0 tdf#114441 changed some sal_uLong to better fitting types It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi Michael Stahl, I am assigning task to myself. I will convert all sal_ULong to appropriate integer types of "filter" module.
shashikdm committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cf82475c785c47327cdc9d591d63d7a82dd1ac53 tdf#114441 Changing sal_uLong to appropriate integer type in filters module It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
hi Shashikant, i didn't notice that immediately but please don't assign the issue to yourself, there are still ~4100 sal_uLong left in master and multiple people can work on them in parallel. thanks for your patch :)
Pelin Kuran committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9465bc10db81d2a2d1e2a82dbaaefa02d2939db1 tdf#114441: Convert use of sal_uLong to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pelin Kuran committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6cfdff7892bb5ee7c252886a6bad798979ae65f6 tdf#114441: Convert use of sal_uLong to better integer types It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.