During the removal of the tools types, the ULONG type was initially converted to sal_uIntPtr, before those doing that work switched to using the stop-gap sal_uLong type instead. sal_uIntPtr has a very special purpose, variables of this type hold pointers that are converted to integers. any use of the sal_uIntPtr type that is actually "just" an integer should be replaced by an appropriate unsigned integer type, depending on the situation sal_uInt32, sal_uInt64, size_t or "unsigned int" are likely candidates. as an example, take the UniqueIndexImpl class. it stores sal_uInt32 internally but its public interfaces are defined on sal_uIntPtr; it is obvious that sal_uIntPtr should be replaced by sal_uInt32 here in UniqueIndexImpl and its clients.
As I'm working in 63154, I will take a look in this bug.
Valentin Kettner committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=061130bd6d60c648991afb83bc0befb48a68f34e fdo#75280 Started cleaning up of sal_uIntPtr usage. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
looks like Alexandre isn't actually working on this; un-assigning... actually the clean-up here should parallelize easily so multiple people can work on it anyway.
I would like to work on this bug.Does this bug simply means to convert ALL the sal_uIntPtr to approtiate types like sal_uInt32, sal_uInt64.
(In reply to Lovekesh Garg from comment #4) > I would like to work on this bug.Does this bug simply means to convert ALL > the sal_uIntPtr to approtiate types like sal_uInt32, sal_uInt64. no; sal_uIntPtr should be used exactly in those places where its semantics are asked for---an (unsigned) integer large enough to hold a pointer
Created attachment 113969 [details] changes in unqidx.hxx
please someone have a look at the attachment and let me know if its correct or not..thank you
Created attachment 113970 [details] sal_uintptr change for debug.hxx
Created attachment 113971 [details] zcodec.hxx fix
Created attachment 113972 [details] inetstrm.hxx
Created attachment 113973 [details] inetmsg.hxx
dtardon->mridul: Please do not add complete source files as attachments. If you want to submit a patch, use gerrit.
mridul: just for your information: https://wiki.documentfoundation.org/Development/gerrit
Hi, I would like to work on this bug. Mark as assigned.
*** Bug 91527 has been marked as a duplicate of this bug. ***
To extract the relevant info from the duplicate bug into this one here - I think size_t would be a reasonably default type, given the fact the original type was ULONG.
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicCleanup)
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
Jaskaran committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=45701913f642b17aabd67b52de9002cc79cf07ae tdf#75280 Replace sal_uIntPtr to better types in /connectivity It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Changing status to reflect this bug is being worked on.
A polite ping, still working on this bug ?
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=08fc0da4033b8ea2b3ae67aa06175e839771396b tdf#75280 Cleaning up of sal_uIntPtr usage #1a It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a6ab81651a98dd726ab7d40101dc81f62895fd4 tdf#75280 Cleaning up of sal_uIntPtr usage #2 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e9bded5b87b491c0a0d7a62512e9c0923a08ce28 tdf#75280 Cleaning up of sal_uIntPtr usage #3 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2e4753c3f511cfc6b2932ce60d0bc2e09296f9f tdf#75280 Cleaning up of sal_uIntPtr usage #4a It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A general question, 1. How do I decide which one to replace sal_uIntPtr with ? That is, how do I decide to use 16/32/64 bit invariant of sal_uInt ? Any tests I should run etc ? 2. Also according to https://bugs.documentfoundation.org/show_bug.cgi?id=75280#c5, Comment 5, How do I decide where sal_uIntPtr and where sal_uInt variants are used ? Cliffnotes: How to decide when to use sal_uInt and if it is to be used, which variant (16/32/64 etc) to be used ? Thanks.
(In reply to Sudarshan K from comment #26) > A general question, > 1. How do I decide which one to replace sal_uIntPtr with ? That is, how do I > decide to use 16/32/64 bit invariant of sal_uInt ? Any tests I should run > etc ? > 2. Also according to > https://bugs.documentfoundation.org/show_bug.cgi?id=75280#c5, Comment 5, How > do I decide where sal_uIntPtr and where sal_uInt variants are used ? that is the challenge in this easyhack, read the first comment it explains it quite good. also take a look at some of the commits already done. > > Cliffnotes: How to decide when to use sal_uInt and if it is to be used, > which variant (16/32/64 etc) to be used ? look at the usage of the variable, some places are easy others are quite complicated. > > Thanks.
Hieronymous committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=39851c7f780e548d494a9ef8bdf256b32a631f00 tdf#75280 Clean up usage of sal_uIntPtr. It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gaurav Dhingra committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c52745f8a3743841a4de030928c61d22063dd8ec tdf#75280 Convert few inappropriate use of sal_uIntPtr to better integer types It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=437a5d7c72547f6f17b4ffecd51e76a2487de99e tdf#75280: convert sal_uIntPtr to sal_uInt32 for ErrorInfo member It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jochen Nitschke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=05d3a1899eb50202fd3929b702bae1003b5610be tdf#75280 replace uses of sal_uLong It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Regis committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/70040ba199ab34a792beb34cbafdbc8edc0e22ea%5E%21 tdf#75280 -Convert inappropriate use of sal_uIntPtr to better integ types It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.