During the removal of the tools types, the ULONG type was initially converted to sal_uIntPtr, before those doing that work switched to using the stop-gap sal_uLong type instead. sal_uIntPtr has a very special purpose, variables of this type hold pointers that are converted to integers. any use of the sal_uIntPtr type that is actually "just" an integer should be replaced by an appropriate unsigned integer type, depending on the situation sal_uInt32, sal_uInt64, size_t or "unsigned int" are likely candidates. as an example, take the UniqueIndexImpl class. it stores sal_uInt32 internally but its public interfaces are defined on sal_uIntPtr; it is obvious that sal_uIntPtr should be replaced by sal_uInt32 here in UniqueIndexImpl and its clients.
As I'm working in 63154, I will take a look in this bug.
Valentin Kettner committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=061130bd6d60c648991afb83bc0befb48a68f34e fdo#75280 Started cleaning up of sal_uIntPtr usage. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
looks like Alexandre isn't actually working on this; un-assigning... actually the clean-up here should parallelize easily so multiple people can work on it anyway.
I would like to work on this bug.Does this bug simply means to convert ALL the sal_uIntPtr to approtiate types like sal_uInt32, sal_uInt64.
(In reply to Lovekesh Garg from comment #4) > I would like to work on this bug.Does this bug simply means to convert ALL > the sal_uIntPtr to approtiate types like sal_uInt32, sal_uInt64. no; sal_uIntPtr should be used exactly in those places where its semantics are asked for---an (unsigned) integer large enough to hold a pointer
Created attachment 113969 [details] changes in unqidx.hxx
please someone have a look at the attachment and let me know if its correct or not..thank you
Created attachment 113970 [details] sal_uintptr change for debug.hxx
Created attachment 113971 [details] zcodec.hxx fix
Created attachment 113972 [details] inetstrm.hxx
Created attachment 113973 [details] inetmsg.hxx
dtardon->mridul: Please do not add complete source files as attachments. If you want to submit a patch, use gerrit.
mridul: just for your information: https://wiki.documentfoundation.org/Development/gerrit
Hi, I would like to work on this bug. Mark as assigned.
*** Bug 91527 has been marked as a duplicate of this bug. ***
To extract the relevant info from the duplicate bug into this one here - I think size_t would be a reasonably default type, given the fact the original type was ULONG.
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicCleanup)
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
Jaskaran committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=45701913f642b17aabd67b52de9002cc79cf07ae tdf#75280 Replace sal_uIntPtr to better types in /connectivity It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Changing status to reflect this bug is being worked on.
A polite ping, still working on this bug ?
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=08fc0da4033b8ea2b3ae67aa06175e839771396b tdf#75280 Cleaning up of sal_uIntPtr usage #1a It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a6ab81651a98dd726ab7d40101dc81f62895fd4 tdf#75280 Cleaning up of sal_uIntPtr usage #2 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e9bded5b87b491c0a0d7a62512e9c0923a08ce28 tdf#75280 Cleaning up of sal_uIntPtr usage #3 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tymyjan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2e4753c3f511cfc6b2932ce60d0bc2e09296f9f tdf#75280 Cleaning up of sal_uIntPtr usage #4a It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A general question, 1. How do I decide which one to replace sal_uIntPtr with ? That is, how do I decide to use 16/32/64 bit invariant of sal_uInt ? Any tests I should run etc ? 2. Also according to https://bugs.documentfoundation.org/show_bug.cgi?id=75280#c5, Comment 5, How do I decide where sal_uIntPtr and where sal_uInt variants are used ? Cliffnotes: How to decide when to use sal_uInt and if it is to be used, which variant (16/32/64 etc) to be used ? Thanks.
(In reply to Sudarshan K from comment #26) > A general question, > 1. How do I decide which one to replace sal_uIntPtr with ? That is, how do I > decide to use 16/32/64 bit invariant of sal_uInt ? Any tests I should run > etc ? > 2. Also according to > https://bugs.documentfoundation.org/show_bug.cgi?id=75280#c5, Comment 5, How > do I decide where sal_uIntPtr and where sal_uInt variants are used ? that is the challenge in this easyhack, read the first comment it explains it quite good. also take a look at some of the commits already done. > > Cliffnotes: How to decide when to use sal_uInt and if it is to be used, > which variant (16/32/64 etc) to be used ? look at the usage of the variable, some places are easy others are quite complicated. > > Thanks.
Hieronymous committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=39851c7f780e548d494a9ef8bdf256b32a631f00 tdf#75280 Clean up usage of sal_uIntPtr. It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gaurav Dhingra committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c52745f8a3743841a4de030928c61d22063dd8ec tdf#75280 Convert few inappropriate use of sal_uIntPtr to better integer types It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=437a5d7c72547f6f17b4ffecd51e76a2487de99e tdf#75280: convert sal_uIntPtr to sal_uInt32 for ErrorInfo member It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jochen Nitschke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=05d3a1899eb50202fd3929b702bae1003b5610be tdf#75280 replace uses of sal_uLong It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Regis committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/70040ba199ab34a792beb34cbafdbc8edc0e22ea%5E%21 tdf#75280 -Convert inappropriate use of sal_uIntPtr to better integ types It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Kemal Ayhan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9f7a4f14a310628d0649c31d22c8ba8493443511 tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b5b68303b17e88163ec6fc946c7908492b554498 tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mesut Çifci committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/16f6a6e61fdcbb41b77a613d49959c0b9e3a8a32 tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1a5832e8340a2502f24d7fea98c656e629887d2e tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d66ddcffe61d90cb1472e74a040963086032bf9c tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c7de89df5efc4b2af1f81c00befcc957a7e22ca6 tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mesut Çifci committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/18b03440b4dca084274a02d16a8a1545d629a4c1 tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5434688e5c38d438444dd8d088dff9d3de58214a tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
iakarsu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d089b2adc1fc67a7621c3078b6b37c5e997789c tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pelin Kuran committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dd98cb655f243024260dd45c44b751e564c1c67e tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sarper Akdemir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/09a2432c5939f20be49d9f7e2ee5c65d00c9433f tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Batuhan Taskaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4efdf5e5145c96116d7ef76a0bbade57865447f7 tdf#75280: Use sal_uLong instead of sal_uIntPtr It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Canberk TURAN committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0f78ec160d93c9765f3a27be54a4d986872e9a69 tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Efdal İncesu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a27a8f0c03436916e20e3362e8b5ed2410da3b23 tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mehmet Emin Başoğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d23faf1d1ae526cc7af5470e60eb7dc7a46e74cc tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eda Nur Var committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2a37089bad8656271f0fde92ab7731f29a19c8df tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Burak Bala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ca76204c89db32839259a67c52a140a5b7f1fceb tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eda Nur Var committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b16faa4dcd87b9c7203b230a9feaebbb05c5a9cb tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sarper Akdemir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/81f73ca9b9a61fcbba1533ac8b5d5be16025667b tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Canberk TURAN committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9e0470da4a88a588a294856236d6adf1eefe22f6 tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
shivammore committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f4dfbba277bcfc418cb49fdc94b153c15e1ac30b tdf#75280 Clean up usage of sal_uIntPtr. It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/63d4d3421fec5a4e9e88dcee2992cda38cc7452a tdf#75280: Convert inappropriate use of sal_uIntPtr (sfx2) It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8cd8cdcfa54ca34dc6365a398e3c69cbfc685891 tdf#75280: Convert some inappropriate use of sal_uIntPtr (+sal_uLong) (vcl) It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c38fa04c70401d84352e8ae7ca650dfcc74b3e0 tdf#75280: "nFormat" should be "sal_uLong" instead of sal_uIntPtr (svx/imapdlg) It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bayram Çiçek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c7d0f4452cd4eba2d180eb5bb9f8b0add048e5de tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Made a commit. Please review. https://gerrit.libreoffice.org/c/core/+/110491
Aditya Pratap Singh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c056b630ef97aab139625d0a7c085825c8a9eb7f tdf#75280 Convert some sal_uIntPtr in ucb to more appropriate types It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
OmkarAcharekar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/77131a5277f52300319f7cc5f8c2cc8b4d600a7c tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I tried to look into this and there are 151 files with sal_uIntPtr remain. As far my understanding goes after looking those I think there are no more of these changes required. So, maybe we can close this.
have just reviewed the remaining usages, the situation is much improved... these are inappropriate, although not in the way mentioned in the description: here some value is extracted out of an uno::Any, and there are easier to use functions such as uno::Any::get<sal_Int32>() to do this. editeng/source/accessibility/AccessibleEditableTextPara.cxx: Color crChar(ColorTransparency, static_cast<sal_uInt32>( reinterpret_cast<sal_uIntPtr>(anyChar.pReserved))); editeng/source/accessibility/AccessibleEditableTextPara.cxx: Color crCharUnderLine(ColorTransparency, static_cast<sal_uInt32>( reinterpret_cast<sal_uIntPtr>( anyCharUnderLine.pReserved))); sw/source/core/access/accpara.cxx: sal_uInt32 crBack = static_cast<sal_uInt32>( reinterpret_cast<sal_uIntPtr>(anyChar.pReserved)); sw/source/core/access/accpara.cxx: sal_uInt32 crChar = static_cast<sal_uInt32>( reinterpret_cast<sal_uIntPtr>(anyChar.pReserved)); sw/source/core/access/accpara.cxx: sal_uInt32 crUnderline = static_cast<sal_uInt32>( reinterpret_cast<sal_uIntPtr>(anyChar.pReserved)); these are probably inappropriate sal_uIntPtr that should be other integer types: include/svx/svdoedge.hxx: sal_uIntPtr* pnQuality, SdrEdgeInfoRec* pInfo) const; svx/source/gallery2/codec.cxx: sal_uIntPtr nIndex = 0, nCountByte, nRunByte; svx/source/svdraw/svdhdl.cxx: sal_uIntPtr nNewHdlNum(nNewHdl); svx/source/svdraw/svdoedge.cxx: sal_uIntPtr nBestQual=0xFFFFFFFF; svx/source/svdraw/svdoedge.cxx: sal_uIntPtr nQual=0; svx/source/svdraw/svdoedge.cxx: sal_uIntPtr* pnQuality, SdrEdgeInfoRec* pInfo) const svx/source/svdraw/svdoedge.cxx: sal_uIntPtr nQual=0; svx/source/svdraw/svdoedge.cxx: sal_uIntPtr nQual0=nQual; // prevent overruns svx/source/svdraw/svdoedge.cxx: sal_uIntPtr n1=std::abs(aXP1[1].X()-aXP1[0].X())+std::abs(aXP1[1].Y()-aXP1[0].Y()); svx/source/svdraw/svdoedge.cxx: sal_uIntPtr n2=std::abs(aXP1[2].X()-aXP1[1].X())+std::abs(aXP1[2].Y()-aXP1[1].Y()); svx/source/svdraw/svdoedge.cxx: sal_uIntPtr n3=std::abs(aXP1[3].X()-aXP1[2].X())+std::abs(aXP1[3].Y()-aXP1[2].Y()); svx/source/svdraw/svdoedge.cxx: sal_uIntPtr nBesser=0; svx/source/svdraw/svdoedge.cxx: nQual+=static_cast<sal_uIntPtr>(nTmp)*0x01000000; svx/source/svdraw/svdoedge.cxx: nQual+=static_cast<sal_uIntPtr>(nIntersections)*0x10000000; svx/source/svdraw/svdoedge.cxx: sal_uIntPtr nBestDist=0xFFFFFFFF; svx/source/svdraw/svdoedge.cxx: sal_uIntPtr nDist=static_cast<sal_uIntPtr>(std::abs(aConPos.X()-rPt.X()))+static_cast<sal_uIntPtr>(std::abs(aConPos.Y()-rPt.Y())); there is also the sal_IntPtr type (signed) with similar problem. these are probably inappropriate sal_IntPtr that should be other integer types: include/vcl/toolkit/treelistbox.hxx: sal_IntPtr GetTabPos(const SvTreeListEntry*, const SvLBoxTab*) const; svx/source/sidebar/line/LineWidthPopup.cxx: sal_IntPtr nVal = OutputDevice::LogicToLogic( svx/source/sidebar/line/LineWidthPopup.cxx: reinterpret_cast<sal_IntPtr>(m_xVSWidth->GetItemData(iPos)), MapUnit::MapPoint, sw/inc/authfld.hxx: mutable sal_IntPtr m_nTempSequencePos; sw/inc/authfld.hxx: mutable sal_IntPtr m_nTempSequencePosRLHidden; ///< hidden redlines sw/source/core/fields/authfld.cxx: sal_IntPtr & rnTempSequencePos(pLayout && pLayout->IsHideRedlines() sw/source/core/fields/authfld.cxx: sal_IntPtr & rnTempSequencePos(pLayout && pLayout->IsHideRedlines() sw/source/uibase/utlui/uitool.cxx: sal_IntPtr nPoolId = SwStyleNameMapper::GetPoolIdFromUIName( pBase->GetName(), SwGetPoolIdFromName::ChrFmt ); ucb/source/sorter/sortdynres.cxx:void EventList::AddEvent( sal_IntPtr nType, sal_Int32 nPos ) ucb/source/sorter/sortresult.cxx: sal_IntPtr mnCurPos; ucb/source/sorter/sortresult.cxx: sal_IntPtr mnOldPos; ucb/source/sorter/sortresult.cxx: explicit SortListData( sal_IntPtr nPos ); ucb/source/sorter/sortresult.cxx: sal_IntPtr nCompare = 0; ucb/source/sorter/sortresult.cxx: sal_IntPtr nCompare = 0; ucb/source/sorter/sortresult.cxx: sal_IntPtr nIndexOne; ucb/source/sorter/sortresult.cxx: sal_IntPtr nIndexTwo; ucb/source/sorter/sortresult.cxx: sal_IntPtr nCompare; ucb/source/sorter/sortresult.cxx: sal_IntPtr _nStart, sal_IntPtr _nEnd ) ucb/source/sorter/sortresult.cxx: sal_IntPtr nStart = _nStart; ucb/source/sorter/sortresult.cxx: sal_IntPtr nEnd = _nEnd; ucb/source/sorter/sortresult.cxx: sal_IntPtr nMid = 0, nCompare = 0; ucb/source/sorter/sortresult.cxx: sal_IntPtr i, nCount; ucb/source/sorter/sortresult.cxx: sal_IntPtr nIndex = 1; ucb/source/sorter/sortresult.cxx: sal_IntPtr nPos = FindPos( pData.get(), 1, nIndex-1 ); ucb/source/sorter/sortresult.cxx: sal_IntPtr i, nEnd; ucb/source/sorter/sortresult.cxx: sal_IntPtr nOldLastSort; ucb/source/sorter/sortresult.cxx: for ( sal_IntPtr i=0; i < nCount; i++ ) ucb/source/sorter/sortresult.cxx: sal_IntPtr nSortPos = m_O2S[nPos]; ucb/source/sorter/sortresult.cxx: sal_IntPtr nVal = m_O2S[j]; ucb/source/sorter/sortresult.cxx: sal_IntPtr i, nSortPos, nTo; ucb/source/sorter/sortresult.cxx: sal_IntPtr nStart = nPos + nCount; ucb/source/sorter/sortresult.cxx: sal_IntPtr nEnd = nStart + nOffset; ucb/source/sorter/sortresult.cxx: std::unique_ptr<sal_IntPtr[]> pTmpArr(new sal_IntPtr[ nCount ]); ucb/source/sorter/sortresult.cxx: sal_IntPtr nFrom = nPos - 1; ucb/source/sorter/sortresult.cxx: sal_IntPtr const nVal = m_O2S[nFrom + i]; ucb/source/sorter/sortresult.cxx: sal_IntPtr nStart = nPos + nCount; ucb/source/sorter/sortresult.cxx: sal_IntPtr const nVal = m_O2S[nStart + i]; ucb/source/sorter/sortresult.cxx: for ( sal_IntPtr i=0; i<nCount; i++ ) ucb/source/sorter/sortresult.cxx: sal_IntPtr const nSortPos = m_O2S[nPos]; ucb/source/sorter/sortresult.cxx: sal_IntPtr nCompare, nCurPos, nNewPos; ucb/source/sorter/sortresult.cxx: sal_IntPtr nStart, nEnd, nOffset, nVal; ucb/source/sorter/sortresult.cxx: sal_IntPtr i, nNewPos, nVal; ucb/source/sorter/sortresult.cxx: for ( i = mnLastSort; i<static_cast<sal_IntPtr>(maS2O.Count()); i++ ) ucb/source/sorter/sortresult.cxx:SortListData::SortListData( sal_IntPtr nPos ) ucb/source/sorter/sortresult.cxx: if ( nPos < static_cast<sal_IntPtr>(maData.size()) ) ucb/source/sorter/sortresult.cxx: if ( nPos < static_cast<sal_IntPtr>(maData.size()) ) ucb/source/sorter/sortresult.cxx: if ( nPos < static_cast<sal_IntPtr>(maData.size()) ) ucb/source/sorter/sortresult.cxx: if ( nPos < static_cast<sal_IntPtr>(maData.size()) ) ucb/source/sorter/sortresult.hxx: void AddEvent( sal_IntPtr nType, sal_Int32 nPos ); ucb/source/sorter/sortresult.hxx: std::deque<sal_IntPtr> m_O2S; /// maps the original Entries to the sorted ones ucb/source/sorter/sortresult.hxx: sal_Int32 FindPos( SortListData const *pEntry, sal_IntPtr nStart, sal_IntPtr nEnd ); vcl/source/treelist/treelistbox.cxx:sal_IntPtr SvTreeListBox::GetTabPos(const SvTreeListEntry* pEntry, const SvLBoxTab* pTab) const vcl/source/treelist/treelistbox.cxx: sal_IntPtr nPos = pTab->GetPos(); vcl/source/treelist/treelistbox.cxx: nPos += static_cast<sal_IntPtr>(nDepth);
Chizoba ODINAKA committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e1a882e82331e3ee301332e3d10b36b5620073f9 tdf#75280 Convert sal_uIntPtr to size_t a more appropriate integer type It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I submitted a patchset for this https://gerrit.libreoffice.org/c/core/+/177303 But it hasn't been assigned any reviewers or gotten any comments (aside from my own). It passed Jenkins build a couple weeks ago. Is there anything else I was supposed to do?
(In reply to Marc Mondesir from comment #64) > I submitted a patchset for this > > https://gerrit.libreoffice.org/c/core/+/177303 > > But it hasn't been assigned any reviewers or gotten any comments (aside from > my own). It passed Jenkins build a couple weeks ago. Is there anything else > I was supposed to do? Yes: seek a reviewer. Otherwise you risk a long delay as people are only digging through unreviewed patches occasionally. In this case, I'm pretty sure I have asked for a review in the chat, but the holiday period was quiet.
(In reply to Buovjaga from comment #65) > Yes: seek a reviewer. Otherwise you risk a long delay as people are only > digging through unreviewed patches occasionally. In this case, I'm pretty > sure I have asked for a review in the chat, but the holiday period was quiet. Ah, okay. Thanks. Somebody else just triggered a rebase but didn't add a reviewer. If it has no reviewers after a few days I'll ask in the chat.
Marc Mondesir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b3d5a3d7a79715464cc221f5b0e5489b3c2b250e tdf#75280: Convert sal_uIntPtr use to operator >>= Color. It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.