Bug 91527 - Convert misleading use of sal_uIntPtr to size_t
Summary: Convert misleading use of sal_uIntPtr to size_t
Status: RESOLVED DUPLICATE of bug 75280
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2015-05-23 13:38 UTC by Thorsten Behrens (allotropia)
Modified: 2015-12-16 00:04 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Behrens (allotropia) 2015-05-23 13:38:16 UTC
Grep for sal_uIntPtr in the code-base (preferably module-by-module, so any potential patches are of manageable size).

Notice that tons of variables of that type are for things like 'nAnz', 'nCount', 'nFlags' etc, so clearly no pointer-y things at all.

To further reduce the WTF-factor of the code base, replacing those obvious cases with size_t instead would be great.

To the best of my knowledge, both types are defined equivalently on all current platforms, still, strive to ideally rename the entire usage around one occurence - i.e. change the function signature, all call sites, and any depending variables. Make sure to build the code with werror enabled.
Comment 1 Thorsten Behrens (allotropia) 2015-05-23 13:44:29 UTC

*** This bug has been marked as a duplicate of bug 75280 ***
Comment 2 Robinson Tryon (qubit) 2015-12-16 00:04:21 UTC
Migrating Whiteboard tags to Keywords: (EasyHack SkillCpp DifficultyBeginner TopicCleanup)
[NinjaEdit]