Bug Hunting Session
Bug 114557 - 'Match Case' checkbox in Find toolbar cannot be renamed and icon cannot be set
Summary: 'Match Case' checkbox in Find toolbar cannot be renamed and icon cannot be set
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1.0.4 release
Hardware: All All
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find-Toolbar Customize-Dialog-Toolbars
  Show dependency treegraph
 
Reported: 2017-12-19 13:23 UTC by Timur
Modified: 2019-07-26 20:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2017-12-19 13:23:22 UTC
Toolbar buttons can be renamed. 
But Match Case button in Find Bar cannot be renamed and icon cannot be set.
Also, over that checkbox button, right click is not possible.
Looks like implementation error from 4.1.
Comment 1 Dieter Praas 2017-12-19 19:42:25 UTC
I tried

1. Open document in writer
2. Tools => Customise => Toolbars
3. Select Toolbar "Find"
4. Select "Match Case" => Modify
5. Rename it or change icon => O.K.

Changes were displayed in the dialog, but not in the UI.

Version: 6.0.0.0.beta2 (x64)
Build ID: 13edaaa12f25de343fce136064e27da66c1c4fa4
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: group threaded
Comment 3 Maxim Monastirsky 2017-12-19 20:36:13 UTC
"Match Case" isn't a toolbar button, but a checkbox control which is placed on a placeholder item on the toolbar. If we really want to allow renaming it (why?), then it should be converted to an ordinary toolbar toggle button.
Comment 4 Dieter Praas 2017-12-19 20:43:48 UTC Comment hidden (obsolete)
Comment 5 Maxim Monastirsky 2017-12-19 21:32:36 UTC
(In reply to Dieter Praas from comment #4)
> (In reply to Maxim Monastirsky from comment #3)
> > If we really want to allow renaming it(why?)
> 
> If the dialog allows you to rename it, I would expect, that it is possible
> to rename it.
Technically, the dialog operates on toolbar items. It has no idea that the code of one of those items will suddenly at runtime decide to display a custom control instead of a button. This might improve a bit after implementing Bug 112651, so we will be (mostly) aware of items that use controls, and can e.g. disable renaming them. But problems don't end with controls, as there are several ordinary toolbar buttons, that change their text at runtime. How should we handle them?

Also, note that the title will actually appear if you dock the find toolbar vertically (although the button won't work in such configuration, until Bug 55846 is fixed).

> But pershaps it's a litte more tricky:
> 
> 1. Open document in writer
> 2. Tools => Customise => Toolbars
> 3. Select Toolbar "Find"
> 4. Select "Find & Replace" => Change Icon => O. K.
> 5. Icon is not changed in the toolbar, but if you open the edit menu, you
> can see the new icon
This is Bug 106784. Let's not mix it here.
Comment 6 QA Administrators 2018-12-20 03:56:07 UTC Comment hidden (obsolete)
Comment 7 Timur 2018-12-20 10:56:07 UTC
Repro 6.3+. I'll convert to Enhancement to avoid inquiries since this is unlikely to be resolved unpurposely. 

(In reply to Maxim Monastirsky from comment #3)
> If we really want to allow renaming it (why?), then it should be converted..
My use case is: I like keep Find Bar on top in line with Standard toolbar. 
Since space is tight, I shorten known labels. Like "Case" instead of "Match Case".