Bug 115026 - EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)
Summary: EDITING: LibreOffice ignores page break when adding a table to the second pag...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Writer-Tables Writer-Tables-Style
  Show dependency treegraph
 
Reported: 2018-01-15 17:47 UTC by Telesto
Modified: 2019-07-19 02:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (2.91 KB, text/plain)
2018-01-15 18:29 UTC, Telesto
Details
Bibisect log (4.92 KB, text/plain)
2018-01-17 09:47 UTC, Telesto
Details
commit that introduce Break table-level property recording (1.44 KB, text/plain)
2018-01-20 05:41 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-01-15 17:47:01 UTC
Description:
LibreOffice ignores page break when adding a table to the second page

Steps to Reproduce:
1. Open Writer
2. Insert a page break -> CTRL+ENTER
3. Insert a table on the second page -> Second page disappears; table moves to the first

4. Second attempt: Insert some text on the first page. Press CTRL+ENTER.. Try to add a table to the second page. Table will be at the first page

Actual Results:  
Table the the first page

Expected Results:
Table should be added to the second page


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Versie: 6.0.0.2
Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: GL; 
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Telesto 2018-01-15 18:29:17 UTC
Created attachment 139115 [details]
Bibisect log

Bisected to:
author	Jim Raykowski <raykowj@gmail.com>	2017-10-31 15:48:07 -0800
committer	Yousuf Philips <philipz85@hotmail.com>	2017-12-27 15:27:50 +0100
commit	203b913155812706e9be14c5fe2b8f543cc4fdc7 (patch)
tree	e2233e80cbc67d0bf834d4eb716ff935cebe6d08
parent	023949fac0043408ac1b86dc67732666d041875e (diff)
tdf#107555 Apply 'Default Style' table style to newly inserted tables
Comment 2 Telesto 2018-01-15 18:34:03 UTC
@Jay,
Thought you might be interested in this one
Comment 3 Jacques Guilleron 2018-01-16 17:26:56 UTC
Hi Telesto,

I confirm with
LO  6.0.0.2 Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
Worked as excepted with
LO 6.0.0.1 (x64) Build ID: d2bec56d7865f05a1003dc88449f2b0fdd85309a
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
Comment 4 Yousuf Philips (jay) (retired) 2018-01-16 18:38:03 UTC
@Jim,
Seems your apply default table style to inserted table patch has a regression.

https://gerrit.libreoffice.org/#/c/46842/
Comment 5 Jim Raykowski 2018-01-17 02:15:44 UTC
(In reply to Yousuf Philips (jay) from comment #4)
> @Jim,
> Seems your apply default table style to inserted table patch has a
> regression.
> 
> https://gerrit.libreoffice.org/#/c/46842/

Hi Jay,

This behavior can be reproduced in versions before the patch was merged by manually performing what the patch does automatically. (Apply a style to a table)

I have reproduced it in the following two versions:
Version: 5.4.4.2, Build ID: 1:5.4.4~rc2-0ubuntu0.16.04.1~lo1 
and
Version: 6.0.0.0.beta2 (x64) mswindows

Here are the steps to reproduce in pre patched versions:
1. Open a version of Writer without this patch
2. Open Sidebar -> View > Sidebar
3. Click on Styles deck icon
4. Click on Tables Styles icon in Styles Panel
5. Insert a page break -> CTRL+ENTER
6. Insert a table on the second page
7. Double click on any table style in the list box in the Styles Panel

Actual Results: 
Table moves to previous page

Expected Results:
Table should stay on page it was on
Comment 6 Telesto 2018-01-17 09:19:07 UTC
Found in
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)

but not in
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5

1. Open Writer
2. Insert a page break (CTRL+ENTER)
3. Add a table on the next page
4. Menu Table -> Autoformat styles -> Choose a style and apply

Table moves to previous page
Comment 7 Telesto 2018-01-17 09:47:56 UTC
Created attachment 139143 [details]
Bibisect log

I would suspect the patch for bug 49342...
Comment 8 Jacques Guilleron 2018-01-17 14:04:19 UTC
Confirm the behavior from Comment 6 with
LO 3.6.0.4 (Build ID: 932b512)
and upper versions
but not with
LO 3.5.7.2 Version ID : 3215f89-f603614-ab984f2-7348103-1225a5b
under Windows 7 Home.
Comment 9 Jim Raykowski 2018-01-20 01:12:50 UTC
I have located what seems to be the cause of this bug. 

tblafmt.cxx

void SwTableAutoFormat::RestoreTableProperties(SwTable &table) const
{
    SwTableFormat* pFormat = table.GetFrameFormat();
    if (!pFormat)
        return;

    SwDoc *pDoc = pFormat->GetDoc();
    if (!pDoc)
        return;

    SfxItemSet rSet(pDoc->GetAttrPool(), aTableSetRange);

//    rSet.Put(m_aBreak);  <<<<< comment this line

When this line of code is removed a table inserted at the start of a new page behaves as expected. I don't really understand why. My knowledge of itemsets and pools and ranges is not strong.
Comment 10 Jim Raykowski 2018-01-20 05:41:05 UTC
Created attachment 139232 [details]
commit that introduce Break table-level property recording

Here may be where this behavior began.
Comment 11 Telesto 2018-05-04 16:23:34 UTC
Repro with:
Version: 6.1.0.0.alpha0+
Build ID: 2ed7c02478968852d7d39c2c4677f2ecf3441bc7
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-22_01:00:56
Locale: nl-NL (nl_NL); Calc: CL
Comment 12 Telesto 2018-07-17 17:41:13 UTC
Repro
Version: 6.2.0.0.alpha0+
Build ID: 8e9d43546c8e46ea635472ddf07f5c183dc13360
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-07-11_23:34:15
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded

STR
1. Open Writer
2. Insert a page break -> CTRL+ENTER
3. Insert a table with a table style applied (non-default)
Comment 13 Jim Raykowski 2018-07-18 06:47:39 UTC
This is related to the table properties text flow:

Table > Properties... > Text Flow tab > Break checkbox and break type radio buttons.

One way we can can work around this case is by not setting the break here [1] if it is SvxBreak::NONE.  

[1] https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/tblafmt.cxx#906
Comment 14 QA Administrators 2019-07-19 02:53:26 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug