Bug 107555 - Apply the 'Default Style' table style to newly inserted tables
Summary: Apply the 'Default Style' table style to newly inserted tables
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.1.0 target:6.0.0.2 target:6....
Keywords:
Depends on: 107554
Blocks: Writer-Tables-Style
  Show dependency treegraph
 
Reported: 2017-05-02 00:16 UTC by Yousuf Philips (jay) (retired)
Modified: 2018-03-28 14:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-05-02 00:16:18 UTC
Once the current default style has been corrected (bug 107554), then newly inserted tables need to be applied with this default style.
Comment 1 Yousuf Philips (jay) (retired) 2017-10-30 09:01:25 UTC
Jim: Do you have time to take this on?
Comment 2 Jim Raykowski 2017-10-31 18:17:59 UTC
Hi Jay,

So currently when a table is inserted, without setting the style to 'Default Style' in the AutoFormat dialog, no style is used by default.

We want to have 'Default Style' used unless another style, including 'None', is selected in the AutoFormat dialog.

Am I on the right track here? If so, other than a bit of a sticky spot with the 'None' style, it's working.
Comment 3 Yousuf Philips (jay) (retired) 2017-10-31 19:46:23 UTC
Hi Jim,

When inserting a table through the dialog, a user can choose which table style to assign to it (bug 113558). When inserting it through the toolbar table group button, it should always be inserted with the 'Default Style' table style assigned to it and the user can change the style afterwards.
Comment 4 Jim Raykowski 2017-11-01 23:45:39 UTC
Here is a link to a patch for this
 
https://gerrit.libreoffice.org/#/c/44147/
Comment 5 Commit Notification 2017-12-20 08:12:10 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=416f7578d6332b5b5a4445f26307d73925188e41

tdf#107555 Apply 'Default Style' table style to newly inserted tables

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2017-12-27 14:28:22 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=203b913155812706e9be14c5fe2b8f543cc4fdc7&h=libreoffice-6-0

tdf#107555 Apply 'Default Style' table style to newly inserted tables

It will be available in 6.0.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2018-03-15 17:02:21 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eeb4a2ec37bf88b26a9f243cc5682e96c9e35df6

tdf#115573 Revert: tdf#107555 Apply 'Default Style' table style

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Ljiljan 2018-03-20 07:21:15 UTC
At the moment, this solution is causing many difficulties in working with tables.

Inserting a new row or column will cause all custom changes to the table (bold, italic, etc...) to change to the default style.  And since it is not possible to modify styles, I suggest to remove this feature... default style should not be applied to a new table, or it should but after we address all these bugs and offer the possibility to modify existing styles. 

Currently, it is not possible to de-select default or any other style applied to the table, so unless you are completely happy with the list of existing styles (which is a rare occasion), working with the table is not intuitive and will cause many difficulties to new and existing users.
Comment 9 Commit Notification 2018-03-26 19:05:43 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=30db8c9b1d9654e62c11657140fac24f0f52c547&h=libreoffice-6-0

tdf#115573 Revert: tdf#107555 Apply 'Default Style' table style

It will be available in 6.0.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2018-03-28 14:37:07 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-0-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=55a27458831d1a7d203479c9d713d2f3e57c25a4&h=libreoffice-6-0-3

tdf#115573 Revert: tdf#107555 Apply 'Default Style' table style

It will be available in 6.0.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.