Bug 115491 - Paragraph borders L and R detached with line spacing > 1
Summary: Paragraph borders L and R detached with line spacing > 1
Status: RESOLVED DUPLICATE of bug 115296
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4.4.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-02-06 15:37 UTC by Alberto
Modified: 2018-03-12 12:39 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Paragraph borders example (9.75 KB, application/vnd.oasis.opendocument.text)
2018-02-06 15:39 UTC, Alberto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto 2018-02-06 15:37:24 UTC
Description:
If I have two paragraph and I want see all the border around the single paragraph
I can do it only for line spacing = 1
Example
-------
|hallo |
-------
|world |
-------
if I have line spacing > 1 the result is
-------
|hallo |
-------

|world |
-------


Steps to Reproduce:
1. Hallo [enter]
2. World [enter]
3. select all, select line spacing 2, Borders Set all four border
4. result OK, borders are around all two paragraph
5. click in first paragraph and format borders click in bottom border and select style ..... (for example)
6. internal border show but left and right border detach

Actual Results:  
Left and right borders detach

Expected Results:
Left and right border continues as for line spacing 1 or as line spacing > 1 but without internal line


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Comment 1 Alberto 2018-02-06 15:39:05 UTC
Created attachment 139641 [details]
Paragraph borders example
Comment 2 Buovjaga 2018-03-02 16:50:02 UTC
I reproduced from scratch with the steps, but not with 3.6.7.2.

However, even in 3.6 the border is broken with the example "TWO PARAGRAPHS LINE SPACING DOUBLE WITH INTERNAL LINE" in the file.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 51291f2352976b2f875197de83486a74795e86a3
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 1st 2018

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)
Comment 3 Buovjaga 2018-03-02 18:03:03 UTC
Repro steps with hallo world in 5.4 alpha0 do not yet show the problem.

Note: the example file actually shows another, newer bug that is not yet in 6.0.1. In 6.1 you can see there is a gap in the borders of all but the first example. Let's wait for bibisecters before going into that further.

Sadly my Windows VM is running out of space so I can't pull in the bibisect repo of 6.0 branch point.
Comment 4 raal 2018-03-12 12:38:14 UTC
This seems to have begun at the below commit.
Adding Cc: to Armin Le Grand; Could you possibly take a look at this one? Thanks
 0675f83da4d29c13f2f8d143805f2f67af0b6d35 is the first bad commit
commit 0675f83da4d29c13f2f8d143805f2f67af0b6d35
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Wed Dec 13 12:51:02 2017 -0800

    source 1d86f43a10f097aa4925bd48870477001098f5ff
author	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-12-01 16:08:10 +0100
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-12-07 16:03:53 +0100
commit 1d86f43a10f097aa4925bd48870477001098f5ff (patch)
tree 9a77dc6a9d3c4563f5154dfa7cf96823d45fad74
parent f894af6d67510ade1447197833a36151bd778214 (diff)
SwFrameBorder: Replaced BorderGeometry creation partially
Replaced BorderGeometry creation in SwFrame::PaintSwFrameShadowAndBorder,
moved to tooling method CreateBorderLinePrimitivesForRectangle. Preparing
using that tooling method also in PaintCharacterBorder to make borders
Comment 5 raal 2018-03-12 12:39:09 UTC

*** This bug has been marked as a duplicate of bug 115296 ***