Created attachment 139429 [details] comparison MSO 2010 and LibreOffice 6.1 Steps to reproduce: 1. Open attachment 54027 [details] from bug 43429 Observed behaviour: Left and right borders have empty gaps. See attached image Reproduced in Version: 6.1.0.0.alpha0+ Build ID: 75802ae40ae67737ae9e4f1a38434e0587affff6 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded [Bug found by office-interoperability-tools]
Created attachment 139430 [details] sample 2 another file affected
Regression introduced by: author Armin Le Grand <Armin.Le.Grand@cib.de> 2017-12-01 16:08:10 +0100 committer Armin Le Grand <Armin.Le.Grand@cib.de> 2017-12-07 16:03:53 +0100 commit 1d86f43a10f097aa4925bd48870477001098f5ff (patch) tree 9a77dc6a9d3c4563f5154dfa7cf96823d45fad74 parent f894af6d67510ade1447197833a36151bd778214 (diff) SwFrameBorder: Replaced BorderGeometry creation partially Bisected with: bibisect-linux64-6.1 Adding Cc: to Armin Le Grand
*** Bug 115491 has been marked as a duplicate of this bug. ***
*** Bug 119025 has been marked as a duplicate of this bug. ***
From the attached image I guess, that it is not about frame borders but about paragraph borders.
*** Bug 119338 has been marked as a duplicate of this bug. ***
May have to do with SwLineRects. Happens when adding ParagraphSpacings (Above/Below) combined with Border style for paragraph. MST metioned that there was code that connected/prolonged that lines when this was active, corresponding to the newxt/prev para having the same BorderStyle.
Got a LO-5-4-7-2, a version where that line prolongation takes place already and a new paragraph does not start a new BorderFrame. Will need to debug that one to see what happened there to do that. Maybe that was just lost with BorderLine refactorings...
Okay, reason found, debugged master and LO-5-4 in paralell and checked. Found that I killed that when changing SwFrame::PaintSwFrameShadowAndBorder to primitive usage (bigger restucture). Could re-add with not too much hassle. Fix on gerrit (see https://gerrit.libreoffice.org/#/c/62451/). Will check when in, but should be fixed with that.
Armin Le Grand committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e89e8941e114d4d1adf76df995a3f1a8d1bff4b1 tdf#115296 extend vertical FrameBorders for joined Frames It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fix in master, shbe fine
Armin Le Grand committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/ea7d9105456537d2e0a6b7dcf051fee1fa259954%5E%21 tdf#115296 extend vertical FrameBorders for joined Frames It will be available in 6.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.2.0.0.alpha1+ Build ID: 19a0698079fbba36646a2d06eaec3a7fde60b2f5 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded @Armin Le Grand, Thanks for the quick fix!
*** Bug 121157 has been marked as a duplicate of this bug. ***