Bug 115849 - Allow table to split across pages and columns enabled when adding row in a table with table style
Summary: Allow table to split across pages and columns enabled when adding row in a ta...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.6 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, needUITest
Depends on:
Blocks: Writer-Tables-Style Cell-Add-Delete
  Show dependency treegraph
 
Reported: 2018-02-19 12:48 UTC by Pascal Becker
Modified: 2022-04-21 13:32 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Becker 2018-02-19 12:48:16 UTC
If "Allow table to split across pages and columns" is disabled for table and a new row is added, then "Allow table to split across pages and columns" is automatically enabled again.

1. Create a table
2. Open table properties and disable "Allow table to split across pages and columns"
3. Commit with "OK"
4. Table behaves corretly and does not split at page the end of the page
5. Add a new row to the table
6. Table splits at page the end of the page
7. Open table properties. The option "Allow table to split across pages and columns" is enabled again.
Comment 1 Dieter 2018-02-20 08:36:06 UTC
Reproducible with

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 77a535285f0fd5f2464430abdc67cf99be024868
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-01-23_23:04:23
Locale: de-DE (de_DE); Calc: CL



But not in 

Version: 5.4.5.1 (x64)
Build-ID: 79c9829dd5d8054ec39a82dc51cd9eff340dbee8
CPU-Threads: 4; BS: Windows 6.19; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group
Comment 2 IWAMOTO 2018-02-20 09:08:02 UTC
This was reproduced in the following environment.

Version: 6.0.1.1 (x64)
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
Locale: ja-JP (ja_JP); 
OS:Winsows7 Home Premium x64
CPU:Intel(R)celeron(R)2.00GHz
Comment 3 Xisco Faulí 2018-02-23 13:34:19 UTC Comment hidden (obsolete)
Comment 4 Jim Raykowski 2018-02-24 02:11:58 UTC
This can be recreated in previous versions by

1. insert table Ctrl-F12
2. apply table style Menu > Table > AutoFormat Styles...
3. continue at step 2 using Pascal's instructions

This happens because an AutoFormat Style is applied to the table. This was introduced in 
tdf#107555 Apply 'Default Style' table style to newly inserted tables

This should be reverted along with 
tdf#108227 Set table style so it is highlighted in Sidebar styles list 

For the moment, one way to remedy this is 

1. insert tables using Menu > Table > Insert Table... or Ctrl-F12
2. click on AutoFormat button
AutoFormat dialog appears and 'None' should be highlighted in the Format list box 
3. click OK
4. click OK to insert the table
Comment 5 QA Administrators 2019-03-15 03:55:24 UTC Comment hidden (obsolete)
Comment 6 Pascal Becker 2019-03-15 07:04:51 UTC
Just tested it in Version 6.2.2.1 and the bug still persists.

Version: 6.2.2.1 (x64)
Build-ID: fcd633fb1bf21b0a99c9acb3ad6e526437947b01
CPU-Threads: 8; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: CL
Comment 7 Dieter 2021-02-11 19:54:05 UTC
Can't reproduce with a table created with table picker, but if table has a table style I can still reproduce with

Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 8 Justin L 2021-11-24 12:55:04 UTC
I re-bibisected based on comment 4 using these steps:
1.) create a new table.
2.) remove the setting "Allow table to split across pages and columns"
3.) apply a table - autoformat

where table break was applied starting in LO 3.6 somewhere in the range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=f5080ebb7022c9f5d7d7fdca4fe9d19f9bb8cabf..a90d7788a4b9aca4378cd1660293403db3d399ac

It is almost certainly the one by author Muhammad Haggag on 2012-05-03 11:12:12 
commit 7e8c0bd73ee59ff3041e55268c77203373962e51
    tdf#31005 Table Autoformats do not save/apply all properties

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7e8c0bd73ee59ff3041e55268c77203373962e51


I'm removing REGRESSION because I don't think it applies here.
What probably needs to happen is that the built-in styles should NOT specify a table-split property. That way whatever is applied to the table would remain. (But that is probably much easier said than done - likely the setting is not implemented as "optional".) However, when a user-defined style is created, it ought to capture this setting.