Description: UI: The error box "Error saving the document" has no OK button.. Secondly: The same warning will appear twice (bug 104755) Error saving the document Untitled 1: Access to C:\Users\XXX\Desktop\Untitled 1.pdf was denied Steps to Reproduce: 1. Launch Writer 2. Export to PDF 3. Open the file with a PDF viewer (creating a file in use situation) 4. Export to PDF again with the same filename: trying to overwrite the existing PDF Actual Results: Error box without OK button (close is possible with red cross) Expected Results: Should be a OK button Reproducible: Always User Profile Reset: No Additional Info: Version: 6.1.0.0.alpha0+ Build ID: e108a31a8fee09c2fa4031e45e45ed73bbdb7c6f CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-03-03_23:36:02 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
This is possibly connected to the following commit in bug 115742: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a30f8c4daaab5bfc850c18b2b0bce3fdb2281a1f author Mike Kaganski <mike.kaganski@collabora.com> 2018-02-21 00:45:04 +0300 committer Mike Kaganski <mike.kaganski@collabora.com> 2018-02-26 20:44:54 +0100 "tdf#115742: allow ignoring stale lockfile on save" I noticed this in my local build as well, but not in a daily build (though yours is one as well), so thought it just needs a clean build, but apparently not.
It can't be the previous commit, actually, because it's a different dialog (but it's affected, too). For sure the following daily build is still good: 96d551636e9179eb6874a5156b191ef3bff0a10c, 2018-02-27_00:54:40 This daily build is bad: d5837fcf2b1c60cfe29e2f41f32e22213710a1b8, 2018-02-28_02:16:25 Maybe this commit, then? Caolán, can you please check? https://cgit.freedesktop.org/libreoffice/core/commit/?id=082e69fefb7439fd4f3d543f0c402039e94c1e9c author Caolán McNamara <caolanm@redhat.com> 2018-02-26 16:53:37 +0000 committer Caolán McNamara <caolanm@redhat.com> 2018-02-27 11:22:49 +0100 convert various MessBox to weld::MessageDialog
strangely I can't seem to reproduce this with the gen backend under Linux. Maybe this will be solved by https://gerrit.libreoffice.org/#/c/50935/
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=21ef6e1157ccaca2916ec124e116fe85c74bb4ec tdf#116264 Show added_buttons by default It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 140490 [details] Dialog with right-aligned button I can see the button(s) now, what's a bit strange is that the buttons are right-aligned in the dialog. And there's more space around them, but maybe that's fine.
Created attachment 140506 [details] Another example Another example with a non-native windows look. I would expect it to be more compact..
@Aron (slightly off topic) Spaces in a filename are converted to %20. The dialog shows (Attachment 140506 [details]): 'Untitled%201.pdf'. I personally would expect 'Untitled 01.pdf'. Not sure if this is bug worthy (minor detail)
(In reply to Telesto from comment #7) > Spaces in a filename are converted to %20. The dialog shows (Attachment > 140506 [details]): 'Untitled%201.pdf'. I personally would expect 'Untitled > 01.pdf'. Not sure if this is bug worthy (minor detail) I agree, please open a bug report on it.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=775b12866059defdb7ae90f7bffe8720fdaf8340 related: tdf#116264 give windows message dialogs less border width It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Buttons are now visible and I reduced the border for windows. I have no opinion on button placement under windows for message dialogs FWIW this page https://msdn.microsoft.com/en-us/library/windows/desktop/dn742499(v=vs.85).aspx suggests... "Right-align commit buttons in a single row across the bottom of the dialog box, but above the footnote area. Do this even if there is a single commit button (such as OK). ... In this example, the OK button is incorrectly centered." while this page... https://msdn.microsoft.com/en-us/library/windows/desktop/bb246415(v=vs.85).aspx "On pop-up error messages, center command buttons"
Created attachment 140659 [details] Example file The proportions for the the locked file dialog is still off; quite a lot of unused space.
The error string itself has trailing newlines which is where the space is coming from
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=975a8164e05a437ec8b51a506989b0bd617854b8 Related tdf#116264 trailing newlines used for msgbox padding now harmful It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.