Bug 116491 - Identify commands of experimental features in the customization dialog
Summary: Identify commands of experimental features in the customization dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Muhammet Kara
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Customise-Dialog
  Show dependency treegraph
 
Reported: 2018-03-19 10:58 UTC by Heiko Tietze
Modified: 2021-11-30 13:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2018-03-19 10:58:53 UTC
For example, when adding Emoji to the insert menu nothing is shown as long the experimental features aren't activated. But there is no clue to the user about that. My suggestion is to write commands of experimental features in italic; better would be a slightly grayed out font color but some themes may show text in white on black and the disabled text color could be muted too much (should be tested anyway).
Comment 1 Muhammet Kara 2018-03-19 11:19:00 UTC
I wouldn't go into the font/color direction as it might get unnecessarily complicated.

+1 for italic. Moreover, we can also add something like this to the description of the selected experimental command: "(This is an experimental feature.)"?
Comment 2 Muhammet Kara 2018-03-19 11:22:15 UTC
Exists on master:

Version: 6.1.0.0.alpha0+
Build ID: b2147abdf6dd82096fb4441e97090ed00a21e985
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 3 Heiko Tietze 2018-04-24 18:21:01 UTC
I get Emoji also with Tools > Options > Advanced > Experimental off and can assign it to the toolbar, for instance, but of course it's not shown then. Thing is that I have no clue in the UI what command is experimental. I'd still prefer gray font color like for disabled controls (ideally taking the RGB value from system settings).
Comment 4 Xisco Faulí 2018-07-25 09:21:16 UTC
Dear Muhammet Kara,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 5 Muhammet Kara 2020-09-05 19:32:44 UTC
(In reply to Heiko Tietze from comment #3)
> I get Emoji also with Tools > Options > Advanced > Experimental off and can
> assign it to the toolbar, for instance, but of course it's not shown then.
> Thing is that I have no clue in the UI what command is experimental. I'd
> still prefer gray font color like for disabled controls (ideally taking the
> RGB value from system settings).

That listbox unfortunately doesn't seem to support such a way of identification. Since we now always have the description field filled, maybe we can add something like this at the top of the description field?

[EXPERIMENTAL]
Comment 6 Thomas Lendo 2020-09-08 20:47:33 UTC
(In reply to Muhammet Kara from comment #5)
> (In reply to Heiko Tietze from comment #3)
> > I get Emoji also with Tools > Options > Advanced > Experimental off and can
> > assign it to the toolbar, for instance, but of course it's not shown then.
> > Thing is that I have no clue in the UI what command is experimental. I 'd
> > still prefer gray font color like for disabled controls (ideally taking the
> > RGB value from system settings).
> That listbox unfortunately doesn't seem to support such a way of
> identification. Since we now always have the description field filled, maybe
> we can add something like this at the top of the description field?
> 
> [EXPERIMENTAL]
There is no space in the description field for a fourth line where the experimental status could be shown. Or do you want to move the existing lines down and the last item will not be shown anymore? Or do you want to make the description field bigger? Is this searchable? I suppose that the only few people are reading the description field.

I would like it if experimental commands are
* either always visible (also when experimental mode is not activated) and then enhanced with a suffix [experimental] in all listboxes and if not activated the commands can be greyed out to show their inactivity like toolbar commands
* or are only visible when experimental mode is activated and additionally enhanced with a suffix [experimental] so that the user is not wondering why it's missing when the experimental mode once is deactivated.

The suffix at the command name shows at the glance that this command is only available in experimental mode and should also be searchable with the search field.
Comment 7 Muhammet Kara 2020-09-08 21:01:58 UTC
(In reply to Thomas Lendo from comment #6)
> (In reply to Muhammet Kara from comment #5)
> > (In reply to Heiko Tietze from comment #3)
> > > I get Emoji also with Tools > Options > Advanced > Experimental off and can
> > > assign it to the toolbar, for instance, but of course it's not shown then.
> > > Thing is that I have no clue in the UI what command is experimental. I 'd
> > > still prefer gray font color like for disabled controls (ideally taking the
> > > RGB value from system settings).
> > That listbox unfortunately doesn't seem to support such a way of
> > identification. Since we now always have the description field filled, maybe
> > we can add something like this at the top of the description field?
> > 
> > [EXPERIMENTAL]
> There is no space in the description field for a fourth line where the
> experimental status could be shown. Or do you want to move the existing
> lines down and the last item will not be shown anymore? Or do you want to
> make the description field bigger? Is this searchable? I suppose that the
> only few people are reading the description field.

The description field is scrollable. I was imagining the [EXPERIMENTAL] tag at the top.

> 
> I would like it if experimental commands are
> * either always visible (also when experimental mode is not activated) and
> then enhanced with a suffix [experimental] in all listboxes and if not
> activated the commands can be greyed out to show their inactivity like
> toolbar commands
> * or are only visible when experimental mode is activated and additionally
> enhanced with a suffix [experimental] so that the user is not wondering why
> it's missing when the experimental mode once is deactivated.

The second suggestion is pretty much what I had in mind, except that the experimental tag being in the description rather than as a suffix.

> 
> The suffix at the command name shows at the glance that this command is only
> available in experimental mode and should also be searchable with the search
> field.

Makes sense. Search/filter does its job based on the command names/labels etc. before the list you see is filled, but I think we can include the suffix in the search/filter as well.

My only concern with this approach would be that what happens if the command name is too long. Appending the suffix will make it worse in that case.
Comment 8 Thomas Lendo 2020-09-13 12:04:30 UTC
Hm, then better not increasing/changing the command name. Then it should be enough to add [EXPERIMENTAL] (or whatever wording would be best) at the description field _and_ the tooltip that pops up when the mouse is over the command in the command list.

The items in the command list itself can't be changed for example to show experimental commands in italics (I wouldn't go with colors for a11y reasons)?

Is it possible to hide experimental mode commands in the customize dialog until the user has activated experimental mode? And is this wanted if it's possible to hide them?

Another question: Are (or can be, if not done yet) experimental mode commands tagged automatically or is there some manual work needed for developers?
Comment 9 Heiko Tietze 2020-09-15 11:15:59 UTC
Would add asterisks to the command name and show the experimental nature in the box/tooltip. But preferably we hide the experimental commands completely, if the option is not enabled.
Comment 10 Commit Notification 2021-05-22 22:19:12 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/60cba23bc0f5e8eafecc03c437f1133b62569fa6

tdf#116491: Customize: Hide experimental commands when not in experimental mode

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-06-02 14:14:08 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/487dbbb69bfcf7c0368e9dc17e5aae1f17f8187f

tdf#116491: Customize: Add indication for experimental commands

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Stéphane Guillou (stragu) 2021-11-30 13:53:10 UTC
verified as fixed in:

Version: 7.2.0.2 / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded