Bug 116892 - FILEOPEN: Rotated Objects Anchored to Cells set Move when Opened
Summary: FILEOPEN: Rotated Objects Anchored to Cells set Move when Opened
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.1.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Anchor-and-Text-Wrap
  Show dependency treegraph
 
Reported: 2018-04-08 23:56 UTC by Luke
Modified: 2018-10-06 17:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Square shape originally anchored to B2 (9.21 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-04-08 23:57 UTC, Luke
Details
tail of terminal output, daily Linux dbgutil bibisect (2.29 KB, text/plain)
2018-04-16 22:48 UTC, Terrence Enger
Details
Comparison LibreOffice 6.0 and Master (133.09 KB, image/png)
2018-04-17 14:59 UTC, Xisco Faulí
Details
screenshot of 3.6.7.2 vs 4.3.7.2 (66.54 KB, image/png)
2018-04-20 05:05 UTC, Luke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2018-04-08 23:56:42 UTC
Steps to reproduce.
1. In Calc, in B2, insert a shape
2. Set Anchor "To Cell, Resize with Cell"
3. right click -> Position and Size -> rotate by some angle
3. Save 
4. Close and re-open 

Expected behavior
1. Shape stays in same position 

Actual behavior
1. Shape moves on each save
Comment 1 Luke 2018-04-08 23:57:41 UTC
Created attachment 141216 [details]
Square shape originally anchored to B2
Comment 2 Samuel Mehrbrodt (CIB) 2018-04-09 05:59:30 UTC
This seems to happen when the shape is larger than the cell it's anchored to.
Comment 3 Samuel Mehrbrodt (CIB) 2018-04-10 08:32:42 UTC
Also seen in 5.4.x, so not a regression from my changes.
Comment 4 Luke 2018-04-10 16:57:09 UTC
No repo in LibreOffice 3.3.4. A file saved with 5.3+ is correctly centered. Subsequent save, close, re-open cycles do not result in the shape moving.
Comment 5 Terrence Enger 2018-04-16 22:48:43 UTC
Created attachment 141413 [details]
tail of terminal output, daily Linux dbgutil bibisect

Working on debian-buster in the daily Linux dbgutil bibisect
repository, I see the bug came into LO somewhere in the 73 or so
commits to master:

          commit    date        s-h
          --------  ----------  --------
    good  559d6c25  2018-04-06  6c737acc
    bad   bdd69368  2018-04-07  3ec490fc

For this, I deemed:

    bad, upon opening file: rotated square is in C3, extending into C2
    and C4.

    bad after save and reopen, and good upon opening file and after
    save and reopen: rotated square is in B2, extending into C2.


Contrary to comment 3, I have not seen the bug in 5.4.5.1.

I am setting keyword bibisected.
Comment 6 Xisco Faulí 2018-04-17 14:59:49 UTC
Created attachment 141427 [details]
Comparison LibreOffice 6.0 and Master

At import time, the drawing is over B2 in 6.0.3 and over C3 in master
Comment 7 Xisco Faulí 2018-04-17 15:03:18 UTC
Regression introduced by:

author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2018-04-06 10:20:43 +0200
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2018-04-06 13:09:55 +0200
commit	89b671c4a4288f3058157da292b1275e5bfb8392 (patch)
tree	8bd7dc860d74e8db1f52066b702be1f4766ad487
parent	49a2ca259287173d86a303b5c75d25ce52a9e26c (diff)
tdf#116836 Don't move objects out of cell when shrinking cell

Bisected with: bibisect-linux64-6.1

Adding Cc: to Samuel Mehrbrodt
Comment 8 Luke 2018-04-20 05:05:40 UTC
Created attachment 141497 [details]
screenshot of 3.6.7.2 vs 4.3.7.2

I agree with Samuel here. I can reproduce this in 5.4, 5.3, 4.3, but not in 3.3 or 3.6. So this regression occurred between 3.6 and 4.3

Use these steps to reproduce this bug:
1. Open attachment 141216 [details]
2. Compare location of rectangle with my screenshot. LO 3.6 is correct. 4.3 is wrong. 

I think Xisco & Terrence bisected a different bug.
Comment 9 Luke 2018-04-21 03:25:37 UTC
I'm going to put in a bibisect for the regression that occurred here:

Version 4.0.0.1 (Build ID: 527dba6f6e0cfbbc71bd6e7b88a52699bb48799)
Good

Version: 4.1.0.1
Build ID: 1b3956717a60d6ac35b133d7b0a0f5eb55e9155
BAD


attachment 141497 [details] shows the issue that I was reporting. 

The bug Xisco & Terrence identified is probably related to Bug 116931. Changing anchor type from "To Cell, Resize with Cell" to "To Cell" will workaround this bug.
Comment 10 Buovjaga 2018-07-07 15:13:27 UTC
It seems I hit the bullseye with 41max: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2b1aa949539d2fcbb3d349be3c279996630d83fc
fdo#56276 - resize/reposition rotated shapes in a sensible way

Committer is retired.