Created attachment 144082 [details]
Place some objects on the spreadsheet (like triangle, arrow, square).
Rotate this object by some degrees.
Set the anchor for the object.
Save the file.
Close the file.
Open the file.
--> The object rotates and switches position to a different cell everytime I Open/Close again.
Wrong with 6.2+. Also size.
Before confirming, did you search for existing bugs?
Like Bug 111448
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin ; Could you possibly take a look at this one?
95a48f86905ae970b3f12d05fa74d9c7787a8eb8 is the first bad commit
Author: Matthew Francis <firstname.lastname@example.org>
Date: Fri Sep 18 10:34:13 2015 +0800
Author: Noel Grandin <email@example.com>
AuthorDate: Wed Feb 20 13:43:03 2013 +0200
Commit: Noel Grandin <firstname.lastname@example.org>
CommitDate: Wed Feb 20 13:43:03 2013 +0200
fixup class vs. constructor definition
:040000 040000 f1ff2d173615d477227c06317ba4ec2c47dc1ab8 73e5eed929c3453eb967eed34c8e5fa36c2f19e4 M opt
@raal are you sure about that, that's a KDE-specific commit?
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword
Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
The problem still exists in Version: 18.104.22.168.alpha0+ (x64)
Build ID: 3a8d16ba8ca7ef7349e893f2bf1c7e12d9a8d7ae
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win;
Locale: de-DE (en_US); UI-Language: en-US
The problem is triggered in drw.layer.cxx#1041 with the call pObj->SetSnapRect(rData.getShapeRect());
The error itself is in svdoashp.cxx#1464
void SdrObjCustomShape::NbcSetLogicRect( const tools::Rectangle& rRect )
maRect = rRect;
Here the to be "Snap"-Rectangle rRect is directly copied to maRect, which is the "Logic"-Rectangle of the custom shape. A "Logic"-Rectangle is the rectangle of the shape without rotation and shearing and "Snap"-Rectangle is including rotation ans shearing.
We had some discussion, see https://lists.freedesktop.org/archives/libreoffice/2019-November/083710.html
I thought it would be possible to solve it, by changing the callers to use a logic rectangle as input and have adapted two places. But it seems, there exist much more situations. So I need to re-think, how to solve the problems directly in SdrObjCustomShape::NbcSetLogicRect.
Ups, wrong quote, here the correct one from line #1441:
void SdrObjCustomShape::NbcSetSnapRect( const tools::Rectangle& rRect )
maRect = rRect;
Created attachment 156255 [details]
Document to test .uno:FitToCellSize
Open the file. Apply "Fit to Cell Size" to the shape. Find the command in the context menu of the shape.
Expected: The shape shrinks so that it fits into its anchor cell.
Observed: The shape gets totally wrong size and position.
The fix for this problem is the same as for the wrong position and size on loading. Therefore I have not written a separate bug report.
The proposed fix is currently in https://gerrit.libreoffice.org/#/c/84216/ for review.
The bisect is likely wrong. From Bug 116892, the cause of this is likely
fdo#56276 - resize/reposition rotated shapes in a sensible way
I know how to fix it, but I need some time for the unit tests.
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":
tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRect
It will be available in 6.5.0.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
*** Bug 116892 has been marked as a duplicate of this bug. ***
A polite ping to Regina Henschel:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
It turned out, that the problem in bug 129339 is different, because the file contains already faulty information in the shape. So yes, this is fixed.
*** Bug 94625 has been marked as a duplicate of this bug. ***