Bug 116995 - Internal HSQLDB migration to Firebird 3 failing on Windows
Summary: Internal HSQLDB migration to Firebird 3 failing on Windows
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Database-Firebird-Migration
  Show dependency treegraph
 
Reported: 2018-04-13 15:46 UTC by V Stuart Foote
Modified: 2018-04-24 19:51 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2018-04-13 15:46:15 UTC
Something not quite right with the Revert "Remove dead HSQLDB driver" commit, and at the moment unable to open a HSQLDB .odb; seems like the convert to Firebird is still being performed.

On Windows 10 Home 64-bit en-US
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 55e84652ae84bd2374462ee19afd359a8cc90b95
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-13_05:08:28
Locale: en-US (en_US); Calc: CL
Experimental features enabled, and a JRE (64-bit) selected active.

Get an error pop-up. With error info:

The connection to the data source... could not be established.
SQL Status: HY000
The connection to the external data source could not be established. No SDBC driver was found for the URL 'sdbc:embedded:firebird'
A connection for the following URL was requested "sdbc:embedded:firebird".

A copy of the same .ODB did open, in the TB62 x86 build 818619b0f2f7813decb26d0b14362dec76a8ff37 from 2018-04-08_13:29:47
Comment 1 V Stuart Foote 2018-04-14 19:33:20 UTC
Tamás, *

guess the:

-    if( m_pImpl->m_sConnectURL == "sdbc:embedded:hsqldb" &&
-            !sMigrEnvVal.isEmpty())
-    {
+    bool bNeedMigration =  m_pImpl->m_sConnectURL == "sdbc:embedded:hsqldb" &&
+            (m_bMigationNeeded || !sMigrEnvVal.isEmpty());
+    if(bNeedMigration)

from https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b0ceb86c342754d8f4e83408c7ae0da0e3931d3

should take care of this?

Will check when it rolls on a nightly...
Comment 2 V Stuart Foote 2018-04-16 14:13:22 UTC
Hmm, migration to FB3 dead in the water here on Windows 10 64-bit with JRE 9.0.1 (32 and 64 bit)

Tables from the HSQLDB based ODB open as before when "Later" to bypass the migration--so restoration of HSQLDB support restored.

But on accepting the migration dialog, still getting the error dialog from OP "The connection to the external data source could not be established. No SDBC driver was found for the URL 'sdbc:embedded:firebird'."

This same ODB does open after conversion to FB3 in the TB62 build from 2018-04-08
818619b0f2f7813decb26d0b14362dec76a8ff37 since the revert Windows builds are affected, will check Linux.

=-testing-=
attachment 141322 [details] from bug 116982

Windows 10 Home 64-bit en-US with JRE 9.0.1 (32 and 64 bit)
Version: 6.1.0.0.alpha0+ (x64)
Build ID: d246aa574571409046619254292698184c2545a3
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-16_02:10:59
Locale: en-US (en_US); Calc: CL
Comment 3 V Stuart Foote 2018-04-24 19:51:52 UTC
Duh! thorsten's TB42 is configured "--disable-firebird-sdbc"; seems Cloph's TB62 enables it and so does not error with migration to FB.

=-testing-=
Windows 10 Ent 64-bit en-US (ver 1709) 

works with
Version: 6.1.0.0.alpha0+
Build ID: 152faedebbfed3d0c3b5e465a25ef4dba030072c
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2018-04-24_14:20:13
Locale: en-US (en_US); Calc: CL

not working with
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 930a3cbaeeaf6bca594f8651c4d5dffc1e5391d4
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-23_23:11:16
Locale: en-US (en_US); Calc: group

@Thorsten, any chance of tweaking TB42 to build with Firebird?