Bug 117081 - cannot create Firebird embedded database unless experimental features is turned on
Summary: cannot create Firebird embedded database unless experimental features is turn...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Xisco Faulí
URL:
Whiteboard: target:6.1.0
Keywords:
Depends on: Database-Firebird-Default
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-18 09:00 UTC by Lionel Elie Mamane
Modified: 2018-04-18 17:51 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lionel Elie Mamane 2018-04-18 09:00:35 UTC
In the current master (as of yesterday), the firebird driver is active and available unconditionally (e.g. for opening an existing embedded firebird .odb file), but the "new database" wizard allows only creation of HSQLDB embedded, unless "experimental features" is turned on.
Comment 1 Xisco Faulí 2018-04-18 09:34:49 UTC
Reproduced in

Version: 6.1.0.0.alpha0+
Build ID: 3564b46992fc30e212011c19043a2553178ccbca
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 2 Julien Nabet 2018-04-18 10:19:49 UTC
Code pointer? https://opengrok.libreoffice.org/xref/core/connectivity/source/commontools/DriversConfig.cxx#116
Perhaps we just remove this part (aMiscOptions.IsExperimentalMode() ||
117                         aInstalledDriver.sDriverFactory != "com.sun.star.comp.sdbc.firebird.Driver" )?
Comment 3 Xisco Faulí 2018-04-18 10:20:17 UTC
I've submitted a patch to https://gerrit.libreoffice.org/#/c/53090/
Comment 4 Commit Notification 2018-04-18 17:51:31 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a1a9899e05b0ebbc3ff43f2db242724c8feb18f

tdf#117081: show Firebird by default

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.