Tested on: Version: 6.0.3.2 Build ID: 8f48d515416608e3a835360314dac7e47fd0b821 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; Locale: en-US (en_US.UTF-8); Calc: group Description: After successful installation of Bulgarian spelling language pack the user is asked to restart the application. After restart, one is asked once again to reinstall the same language package. Steps to reproduce: 1.Download language package 2.Install it by double clicking 3.Restart the application when asked Expected results: After the application is restarted LibreOffice should start normaly Actual results: After the application is restarted a pop up window appears asking if the user wants to replace/reinstall the language pack previously installed. Additional notes: It is only reproducible in Linux, in Windows bulgarian language spelling pack is already installed. Would be nice if Linux version to include bulgarian spelling also.
Created attachment 141484 [details] Extension window
Created attachment 141485 [details] Extension replace
Yes, this happens if LibreOffice *was not running* when user installs an extension by double-clicking a downloaded extension. In this case, the command line used to launch the program contains the extension to install, and when restarting, this command line argument is used again - starting "reinstall". For information: it is absolutely safe to just refuse to reinstall. Setting NEW.
Somewhat similar problem was solved in commit 0fda52cc4a5c78c55f96850faa734ea66891808c; still it's not an equal problem. To those who decide to fix this: at least these scenarios must be handled: 1. After restart, in still running instance where duplicate installation was suppressed, user decides to install another extension (either opening from this instance's manager, or from launching the .oxt from a file manager) - the new installation must not be suppressed; 2. After restart with suppressed reinstall, user does something that initiates new restart (like configuring Java, installing other extensions, etc.) - this time, the initial (and possibly new) reinstall also should be suppressed; 3. The flag (e.g., if it is written into user profile) must not interfere with subsequent launches (not restarts from this sessions): e.g., if user decided not to restart now, but next day cold-launches LO installing another extension.
See also the commit b2c6c91391f01faa287de18e59e4762031ef6ddc, which initially mentioned this problem. Based on that commit's date, setting first affected version to 5.3.
Possibly one of these implementation variants could be used to workaround this: Variant 1. If soffice.bin was launched with an .OXT file as its argument, then (a) require it to be exclusive parameter; and (b) shutdown after closing the extension manager (no restart in this case). Variant 2. Alternatively, simply don't use restart dialog in this case. Use old warning about "restart required". Variant 3. A large-scale change: when starting first time, fork a process without fileopen command line arguments, and then pass them to this "clean" process using usual interprocess means as we do for following launches. This would allow to have the primary soffice.bin to restart safely without reloading documents (and extension package files) from old command line. Variant 4. Cleanup all fileopen/print arguments from the guards that manage restarts (e.g., soffice.exe on Windows), so that when restarting, they would not repeat using those arguments again. Problem: first launch of soffice.bin that initializes user profile: restart after this should repeat all the command line arguments. Maybe introduce a dedicated return code like "restart repeating full command line".
*** Bug 119150 has been marked as a duplicate of this bug. ***
*** Bug 109060 has been marked as a duplicate of this bug. ***
*** Bug 108460 has been marked as a duplicate of this bug. ***
*** Bug 123222 has been marked as a duplicate of this bug. ***
erreur 1714 installation précédante n'a pu etre suprimé
*** Bug 150396 has been marked as a duplicate of this bug. ***
There is a bounty for solving this issue: https://www.bountysource.com/issues/109667441-request-for-reinstall-after-successful-installation-of-an-extension-started-by-double-clicking-an-oxt-file-in-file-manager
*** Bug 141621 has been marked as a duplicate of this bug. ***
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4963fc47a0381967246e15479bf79bb58dddc465 tdf117100: do not attempt to re-install extensions on restart It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fantastic, Justin. Thanks for the bugfix! I was getting this "double popup" for years with LanguageTool's OXT, even while helping friends install it over webcam. Great to see it's finally squished. :)