Bug 166870 - Don't ask for a restart after theme installation
Summary: Don't ask for a restart after theme installation
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Sahil Gautam (allotropia)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: LibreOffice-Themes
  Show dependency treegraph
 
Reported: 2025-06-05 19:24 UTC by Eyal Rozenberg
Modified: 2025-06-06 11:46 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2025-06-05 19:24:54 UTC
When one installs a new theme, and has not yet used it - it makes no sense for LibreOffice to require a restart. Whatever we would like to do on restart (and I wonder if there's anything like that) - we should be able to defer to the next startup; and only if the user tries to enable the theme - then we can demand a restart, or refuse until a restart etc.


My build:

Version: 25.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 63597069fbb3209db1b4acd3c3e85b512b5d717c
CPU threads: 4; OS: Linux 6.12; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Comment 1 Sahil Gautam (allotropia) 2025-06-06 02:01:53 UTC
working on this atm
Comment 2 Heiko Tietze 2025-06-06 10:56:21 UTC
No need for input from UX
Comment 3 Mike Kaganski 2025-06-06 11:35:40 UTC
(In reply to Eyal Rozenberg from comment #0)
> When one installs a new theme, and has not yet used it

This should only be implemented, if we are able to use the theme without a restart. If it's like "I decided to install, but I'm OK that I can't use it until the restart, don't ask me" - then NO PLEASE DON'T. You have installed something; that something is not usable until restart; your installation is enough indication of your intent of using it; there is no need to introduce complexity. Just refuse to restart, if you like.
Comment 4 Eyal Rozenberg 2025-06-06 11:42:16 UTC
(In reply to Mike Kaganski from comment #3)
> your installation is enough indication of your intent of using it; 

It's not enough - because we have better indication when a user actually switches the theme.

Now, if the dialog were to give the option: "Restart and use this theme" or "Don't restart" - then fine. But it currently offers: "Restart and dont use this theme" vs "Don't restart" - and it claims that a restart is _necessary_. It is not, and we should not lie to our users.
Comment 5 Mike Kaganski 2025-06-06 11:46:27 UTC
Then change wording.

The "we have better indication when a user actually switches the theme" is exactly that needless increased complexity, where you move the knowledge from the place where it's immediately available to somewhere else. Then, themes are just one kind of extensions. And the extension could have not only theme (you can put just any set of extensions into one package: e.g., changes to configuration, commands, etc.) - and those could be attempted to be accessed, too; and now we need to also track that.