Bug Hunting Session
Bug 117118 - Firebird: Saving of data should be done automatically
Summary: Firebird: Saving of data should be done automatically
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: x86-64 (AMD64) All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Database-Firebird-Default
  Show dependency treegraph
 
Reported: 2018-04-20 06:03 UTC by Robert Großkopf
Modified: 2018-05-09 11:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2018-04-20 06:03:07 UTC
Using HSQLDB you usually haven't to press "save" if only data have been changed. You have to leave the row and data will be saved automatically.

Using Firebird needs to press "save" of the main-window. Whithout pressing "save" all data of this session will be lost. 
Note: The "Save"-button of the table will be activated while changing data. But it will be deactivated when reaching the next row. It's only the "Save"-button of the document which shows: Changed data won't be saved without pressing "Save".
Comment 1 Buovjaga 2018-04-23 11:12:39 UTC
Sounds like a good enhancement to achieve parity with HSQLDB.
Comment 2 Alex Thurgood 2018-04-23 12:41:05 UTC
It is debatable whether this is a RFE or in fact a bug. Current behaviour is transparent for the user when using a hsqldb embedded database, and from what I recall this behaviour was introduced into the code deliberately - if so, then we should offer the same behaviour to users who switch to default embedded Firebird.
Comment 3 Lionel Elie Mamane 2018-04-23 13:02:27 UTC
(In reply to robert from comment #0)
> Using HSQLDB you usually haven't to press "save" if only data have been
> changed. You have to leave the row and data will be saved automatically.

Horrible hacks to do that were the source for some of the weirdness and corruption issues in embedded HSQL. It was decided that for Firebird, that error would not be repeated.
Comment 4 Alex Thurgood 2018-04-24 09:28:35 UTC
(In reply to Lionel Elie Mamane from comment #3)


> Horrible hacks to do that were the source for some of the weirdness and
> corruption issues in embedded HSQL. It was decided that for Firebird, that
> error would not be repeated.


Can I take that as a "WONTFIX" then ?
Comment 5 Robert Großkopf 2018-04-24 14:14:03 UTC
Shouldn't be a WONTFIX. 

The Save-button in the table is deactivated every time I switch from a input to next row. Then it is activated while I input new values. This behavior suggests: Data are saved. But data aren't saved, you have to save them a second time with the whole document.

I know: Every created table, every created query or form will be saved twice. But a user, who gets databases from me, doesn't change the forms, queries, tables ... He expects, like in webforms or while connecting Base to an external database: Saved data are saved. I haven't to press "Save" again.
Comment 6 Alex Thurgood 2018-05-09 10:55:05 UTC
(In reply to Lionel Elie Mamane from comment #3)


> Horrible hacks to do that were the source for some of the weirdness and
> corruption issues in embedded HSQL. It was decided that for Firebird, that
> error would not be repeated.


In that case, some kind of solution for reports like bug 117513 will need to be provided.
Comment 7 Drew Jensen 2018-05-09 11:25:14 UTC
(In reply to Lionel Elie Mamane from comment #3)
> (In reply to robert from comment #0)
> > Using HSQLDB you usually haven't to press "save" if only data have been
> > changed. You have to leave the row and data will be saved automatically.
> 
> Horrible hacks to do that were the source for some of the weirdness and
> corruption issues in embedded HSQL. It was decided that for Firebird, that
> error would not be repeated.

The hacks, IIRC, were a result of two issues. First the use of HSQL 1.8 which uses multiple files for the database storage. Second use of compression for OO files. 

The request from the Base developers early on was to not compress the ODB file to get around that but the project management team would not go along with that, the file would remain compressed like the others.

HSQL 2.0 was supposed to help precisely because it moved all the different files used into a single file - but that never happened.

IDK with the embedded firebird engine if there is a single file for everything. I suspect there is. If so than there should be a non-terrible way to offer something closer to what users expectations are.
Comment 8 Drew Jensen 2018-05-09 11:41:21 UTC
sorry - double post again.

There is another choice - rethink the decision to use compression on the ODB file and let the database engine do what it does naturally. 

I suppose though that would open up a whole other set of risks given the code base.