Bug 157237 - Firebird: Automatic saving of data leads to data loss for all changes after last pressed "Save"
Summary: Firebird: Automatic saving of data leads to data loss for all changes after l...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
7.6.0.3 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, dataLoss, regression
Depends on:
Blocks:
 
Reported: 2023-09-14 14:51 UTC by Robert Großkopf
Modified: 2023-09-28 13:42 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2023-09-14 14:51:51 UTC
Saving of data with Firebird should be done automatically since LO 7.6., see  bug 117118.

Automatically saving will only work if there has nothing been saved before like a new created query, a delete view, any change of a form or something else. If Save has been pressed and after this action there will input new data in a table you could close the database file and LO. Reopen database file and all new inserted data will be lost.
See: https://bugs.documentfoundation.org/show_bug.cgi?id=117118#c23
File for testing: https://bugs.documentfoundation.org/attachment.cgi?id=189553

Seems this bug doesn't appear in Windows, as described in
https://bugs.documentfoundation.org/show_bug.cgi?id=117118#c25
Comment 1 Alex Thurgood 2023-09-19 15:35:24 UTC
No repro on macOS.

Repro with 

Version: 7.6.1.2 (AARCH64) / LibreOffice Community
Build ID: f5defcebd022c5bc36bbb79be232cb6926d8f674
CPU threads: 8; OS: Mac OS X 13.4; UI render: Skia/Raster; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded


This works correctly with 
Version: 7.5.6.2 (AARCH64) / LibreOffice Community
Build ID: f654817fb68d6d4600d7d2f6b647e47729f55f15
CPU threads: 8; OS: Mac OS X 13.4; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

==>> regression
Comment 2 Alex Thurgood 2023-09-19 15:37:15 UTC
With
Version: 7.5.6.2 (AARCH64) / LibreOffice Community
Build ID: f654817fb68d6d4600d7d2f6b647e47729f55f15
CPU threads: 8; OS: Mac OS X 13.4; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

I get asked upon closure whether I want to save the changes made, i.e. the added tuples. Clicking on Save then writes those changes to the ODB file and closes the file.

After shutting down LO and re-opening the ODB the added tuples are still there, as they should be.
Comment 3 jcsanz 2023-09-20 21:51:57 UTC
(In reply to Alex Thurgood from comment #1)
> 
> ==>> regression
May be it is a regression generated by my patch to tdf#117118, so I've reverter the patch until further investigation
Comment 4 Xisco Faulí 2023-09-28 13:42:56 UTC
The problematic commit was reverted in https://cgit.freedesktop.org/libreoffice/core/commit/?id=fbf71a4c21106fbed7c070ba940809fd84c76dfe, so this issue can be consider fixed.