Description: After saving a file with embedded macros it is no longer working. Steps to Reproduce: 1. open attached file, activate macros 2. klick the buttons (Typ I) - a form opens, you can choose a answer 3. save as with a new name1, as xlsm- file 4. save as with a new name2, als ods 5. open name1: Buttons are no longer visible 6. open name2: buttons visible, but after klick a basic- error pops up Actual Results: Excel- macros not working after saving files Expected Results: buttons should be visible and working Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: In Options/VBA "save original basic-code" is ticked User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Created attachment 141667 [details] excel- file with macros (forms)
I can confirm with Version: 6.1.0.0.alpha0+ Build ID: 930a3cbaeeaf6bca594f8651c4d5dffc1e5391d4 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3;
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Problem still exists. Version: 6.2.3.2 (x64) Build-ID: aecc05fe267cc68dde00352a451aa867b3b546ac CPU-Threads: 8; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: CL
Dear georg.weickelt, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
yes. confirmed with my software. I downloaded the file, opened it, the buttons showed up and clicking them showed a blank window. save. close. open again. buttons are gone. Version: 7.1.2.2 / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Flatpak Calc: threaded
*** Bug 120374 has been marked as a duplicate of this bug. ***
*** Bug 139938 has been marked as a duplicate of this bug. ***
*** Bug 146083 has been marked as a duplicate of this bug. ***
We have bug 124203 that focuses on the macro link being lost. Lets focus this one more on the lost buttons.
This has always been this way. Import of these buttons didn't work until LO 4.0, somewhere in the 1-month range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=699e7d9e4081942bb0ad73e9be73f90a26d0c2f7..2a360b68475d6fff5b6618feddb0b52f3a4a2373 Most likely, the import started working with author Noel Power on 2012-05-30 14:31:40 +0100 commit dbb385df0fc83c36cfc91b82979fabea868592c2 fix missing form control, partial fix for tdf#49430
Way back in LO 4.0, the exported file could not be really be imported by MS Excel. When LO 7.6 exports the file, MS Excel does import (unlabelled) buttons that are connected to macros (even though it isn't working properly). So that suggests that export is partially OK, but import is completely broken.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/73714e30d144a0d01bc2550ca7a6884a0a92af22 tdf#117266 sc oox: export vml button with a correct label It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/516a3382a774565d4708766ec796c54196563f5a tdf#117266 sc oox: import local macro without reference id It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d50eca2a30bdabdc1735c590d6ec1913c6dd22fd tdf#117266 sc oox: export vml button with a correct name It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5b92a7f211adb229a45c7dedf1ce63e15fcfe5d9 tdf#117266 sc oox: macro button unit test It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The buttons are now functional. Tested round-tripped file in LO and Word 2010. (In Word the buttons are not properly sized or labelled, but they do make a VBA call.)
Created attachment 184822 [details] NachtragVBA.xlsm: password stripped from vbaproject.bin The VBA part is still completely broken however. Unfortunately it is view-locked by a password. I used hexedit to search for DPB= and replaced it with DPx=, which allowed the password to be bypassed. So lets re-focus this bug report to be on the lost userforms during VBA round-trip.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/245912dc42bfc13cbf0db3f04f2411f3dede9615 tdf#117266 tdf#120374 sc oox: export correct vml button name #2 It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.