Description: In an .xlsm document with a macro tied to a button, the button disappears upon saving the document. Steps to Reproduce: 1. Open attached file. Make sure macros are enabled. 2. Click "Edit document". 3. Edit a cell. 4. Edit -> Edit Mode. 5. You're prompted to save. Click Save. 6. Save as .xlsm. Actual Results: Green button disappears. Expected Results: Green button should remain and work as before. Reproducible: Always User Profile Reset: Yes Additional Info:
Created attachment 145441 [details] File that reproduces the issue
Confirmed on windows 7 x64 with Version: 6.0.7.1 (x64) Build ID: 5d2cb2a5dd04fe174b336488731eb50bbb5faed3 CPU threads: 3; OS: Windows 6.1; UI render: default and ubuntu 16.04 x64 with Version: 5.1.6.2 Build ID: 07ac168c60a517dba0f0d7bc7540f5afa45f0909 CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; Locale: en-US (en_US.UTF-8); Calc: single Saving as xlsm and xlsx loses the button. Saving as xls is fine, only the button is grey instead of green.
Dear Nikolai, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The bug is still present. Version: 6.3.2.2 (x64) Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-GB (en_GB); UI-Language: en-GB Calc: threaded
Repro 7.3+. Let's consider a duplicate so far. *** This bug has been marked as a duplicate of bug 117266 ***
This was mostly fixed by commits for bug 117266. The buttons no longer disappear on a round-trip. However, the macro doesn't execute - probably because "ThisWorkbook" has been duplicated. (That is also true in bug 124203.) Removing as duplicate, since the broken VBA is not necessarily due to the same reason as any of the others. Round-tripping as XLS didn't work and exhibits the same duplicate ThisWorkbook1 (at least as seen in Excel 2003). Manually running the macro code in LO works - so perhaps the first thing to look into is why the macro-link is lost on the button. Perhaps that is caused by something different than some of the other export issues? Ahh, probably the name changed. It is based on a <name>_Click macro. In the round-trip it is just getting a numberId and is losing the spid connection. So some of the name-related commits in bug 117266 weren't good enough.
Created attachment 184825 [details] webster-sainte-lague-calculator.xls: Excel 2010 roundtrip of attachment 145441 [details] Note: starting from an Excel-created XLS and round-tripping that as XLS works fine.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/245912dc42bfc13cbf0db3f04f2411f3dede9615 tdf#117266 tdf#120374 sc oox: export correct vml button name #2 It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The beautiful green colour is lost, but the macro button exists and is still functional after multiple round-trips. I'll mark it as fixed. What does NOT work is .xls -> .xlsm, or .xlsm -> .xls. However, those are fairly different internal binary changes IIUC, so that doesn't surprise me. The fact that it can simply round-trip is already rather impressive.