Created attachment 141981 [details]
Example file

I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: a16275a3647a2fba9913ed23e8329e45b02123b4
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

nor in

Version: 6.1.0.0.alpha0+
Build ID: a16275a3647a2fba9913ed23e8329e45b02123b4
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

Reproduced in

Version: 6.1.0.0.alpha1+
Build ID: ecf50fe71596c3edba8ce437481ab80ae1cd8935
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-05-07_23:52:08
Locale: es-ES (es_ES); Calc: group

but not in

Versión: 6.0.3.2
Id. de compilación: 8f48d515416608e3a835360314dac7e47fd0b821
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; 
Configuración regional: es-ES (es_ES); Calc: group

Created attachment 141984 [details]
Screencast

Regression introduced by:

author	Armin Le Grand <Armin.Le.Grand@cib.de (CIB)>	2018-03-01 15:54:32 +0100
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-04-07 00:28:30 +0200
commit dfefe448c41921f2f1e54d3f69b8b9e89031d055 (patch)
tree 1aace31054b5740e2faffcbc5de66a791be27f7d
parent eba4d5b2b76cefde90cb3d6638c736f435023a45 (diff)
SOSAW080: Added first bunch of basic changes to helpers

Bisected with: bibisect-win32-6.1

Adding Cc: to Armin Le Grand

Can confirm, will have to talke a look...
@Telesto: Thanks for the task and the Screencast! Just one comment: When doing a screencast, could you use the context-menu to select/all and copy, then it gets even clearer immediately.

Very strange
- copy/paste from one impress to a 2nd, same exe -> n.p. -> internal shortcut, page is cloned
- copy/paste impress one app -> impress 2nd app -> no paste possible. Tried with combinations actualmaster/actualmaster and actualmaster/lo-6-0. That *should* be allowed...?

Only way to reproduce seems really to go back to StartCenter, thus it's not very probable to happen at all...

Tried to reproduce:
- Start LO
- new Impress
- duplicate slide
- copy new one
- close
- new impress
- paste
-> no problem

When using same but
- new slide
-> can reproduce

Does not happen when
- new Impress
- new slide
- copy new one
- new impress
- paste
-> no problem

Indeed *have* to close all Imperss apps open.

Also happens when:
- new Impress(a)
- new Impress(b)
- new slide
- copy
- close (b)
- pase in still open (a)
-> problem happens

Thus it's not all impress be closed, but close the one that holds the copied slide. This is probably because in that case the clipboard content gets 'flushed' using a save file to the system clipboard.

To reproduce:
- copy slide
- close impress you are in
- paste (already open or newly opened impress)

Does not happen with BlankSlide (obvious) and TitleSlide. Testing others...
Not happens with:
- TitleSlide
- TitleOnly
- CenteredText

-> Happens with all SdrObjects combined with the Content-Master-Object (NOT the Title-Master_Object)

Having one slide with Layout 'Title, Content' copy/pasted(a) (with the error) and one directly created(b) (New Slide) shows;
- a's Title and b's Title have 'PresentationStyle' 'Title'
- a's Content has 'DrawingStyle' 'Default'
- b's Content has 'PresentationStyle' 'Outline 1'
-> during save/load, that style gets lost...

When saving/reloading that combination, a's content keeps 'Default', but gets invisible -> gets painted/shown differently.

Much more strange:
- new Impress(a)
- new Impress(b)
- New Slide in b
- copy
- paste to a
-> all good
- close b
-> pasted slide in a *changes* to the error -> DrawStyleDefault (!)

This is a hint that the Styles themselves are *somehow* mixed between the Documents while both are open...?

Checking this with lo-6-0...

All good in lo-6-0, thus debugging now what might have changed...

Debugged through old (lo-6-0) and new code in parallel to see what happens. Found the reason and changed/fixed it. Interestingly, already had a todo-note at that place :-)
For more info, read the comments at the fix. Will add asap.

Fix on gerrit (see https://gerrit.libreoffice.org/#/c/54555/)

Armin Le Grand committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bc6dd64fe2d8347e20ef4d560024c5e861f07aca

tdf#117506: Add using correct StyleSheet on ::Clone

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Checked on newest master with added fix, all good.

(In reply to Armin Le Grand (CIB) from comment #17)
> Checked on newest master with added fix, all good.

Still happening in a corner case:
1. open Impress
2. Select the Classy Red template in the Template selector
3. Select all slides (CTRL+A)
4. Click the sunset template in the Sidebar (master slides)
5. Copy all slides (CTRL+C)
5. Open a new Impress Document
6. Cancel the template selector
7. Paste the slides (CTRL+V)
8. Select the third slide -> blue background

Correct, could reproduce. Also very strange, Style seems not to be 'Default'. Selecting Object and using 'Edit Style...' in the context menu blocks LO (can be circumvented by clicking on another slide, though). Have to check what LO-6-0 did here...

Hah - LO-6-0 does the same :-(

Also happens when just copying the slide in question.
Also happens when copying slide in question and closing 1st impress.

> Still happening in a corner case:
> 1. open Impress
> 2. Select the Classy Red template in the Template selector
> 3. Select all slides (CTRL+A)
> 4. Click the sunset template in the Sidebar (master slides)
> 5. Copy all slides (CTRL+C)
> 5. Open a new Impress Document
> 6. Cancel the template selector
> 7. Paste the slides (CTRL+V)
> 8. Select the third slide -> blue background

Inherited; also found in:
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

@Telesto: Since this one was about AW080 regression, how about adding a new task for the inherited stuff? Alone to not get confused with the MetaTask AW080-Regressions...?

(In reply to Armin Le Grand (CIB) from comment #23)
> @Telesto: Since this one was about AW080 regression, how about adding a new
> task for the inherited stuff? Alone to not get confused with the MetaTask
> AW080-Regressions...?

I will open a new bug report, and add it to the pile of inherited stuff (219 bugs at this point :-).  Should checked a older versions before reporting my finding here, anyway. A new meta-task bug tracker isn't needed, in my opinion. Search for Impress & Inherited from OpenOffice.

Btw, thanks for all the effort put in AW080. Quite impressive. It's always a bit sad to notice that all those changes are invisible for the end-user. Except for the complains about suddenly broken things ;-).

Hi Telesto,
just a short note: I have added the next change for AW080 stuff to the master. This currently makes two of the footer fields in Impress Blue - I am on it... :-)

(In reply to Armin Le Grand (CIB) from comment #25)
> Hi Telesto,
> just a short note: I have added the next change for AW080 stuff to the
> master. This currently makes two of the footer fields in Impress Blue - I am
> on it... :-)

Thanks for the info. For the record, another one:
1. Open Impress
2. Select DNA or Focus template
3. Save it
4. Reload to file -> Blue textbox

Hi Telesto,
Have you created the follow-up bugs? If so, could you please tell us the ids ?
Regards

Verified in

Version: 6.1.0.0.beta1+
Build ID: da49f4aeb8d5e9a7d2cba8855d911e7cc1d2f1e2
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

@Armin, Thanks for fixing this!!