Download it now!
Bug 117851 - "LibreOffice" top-level menu entry on macOS stays highlighted/selected while the About or Preferences dialog is open
Summary: "LibreOffice" top-level menu entry on macOS stays highlighted/selected while ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All Mac OS X (All)
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 101938 (view as bug list)
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2018-05-28 09:53 UTC by Tor Lillqvist
Modified: 2020-05-09 21:54 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Lillqvist 2018-05-28 09:53:21 UTC
Description:
LibreOffice > About LibreOffice.

While the About window is open, the LibreOffice menu entry in the menu bar stays highlighted. That is not expected, no other normal app looks like that. 

Steps to Reproduce:
See above.

Actual Results:  
.

Expected Results:
.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.1 Safari/605.1.15
Comment 1 Alex Thurgood 2018-05-29 08:10:12 UTC
Confirming with

Version: 6.2.0.0.alpha0+
Build ID: 7f3c2ee6c135773c98ded063bdf10ec8900bf00f
CPU threads: 4; OS: Mac OS X 10.13.4; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded
Comment 2 Tor Lillqvist 2018-05-29 08:32:56 UTC
Presumably this is caused by the fact that the action methods for those menu entries don't return until the window has been closed. That is showAbout: and showPreferences: in the MainMenuSelector class (Objective-C class, that is) in vcl/osx/salmenu.cxx . This also naturally means that the dialogs are modal.

That they are modal probably is as LibreOffice wants them to be. Fixing that might be quite hard, at least for the Preferences dialog. Whether it is against platform expectations I don't know. My guess is, though, that in general in a macOS app, the Preferences dialog is supposed to be non-modal. Also, it isn't supposed to have any separate "OK" and "Cancel" buttons (not to mention "Reset", as LO has) at all, but changes are supposed to apply immediately. Love it or not, that seems to be the macOS standard, based on checking a couple of system apps. So this is just one more way in which LibreOffice works against the platform look and feel.
Comment 3 Tor Lillqvist 2018-05-29 10:34:17 UTC
Filed a separate generic enhancement request for non-modal and apply-immediately dialogs: bug #117873
Comment 4 Tor Lillqvist 2018-05-29 10:36:53 UTC
Note that other equally modal dialogs, also accessible with shortcuts, don't leave the menubar entry highlighted while open, though. For instance ⌘-F3, for the AutoText dialog, does not leave the "Tools" menubar entry highlighted while the dialog is open. So this is a clear inconsistency.
Comment 5 Xisco Faulí 2018-05-31 15:59:50 UTC
Also reproduced in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 6 Adolfo Jayme 2018-06-03 19:47:12 UTC
The effect is visible in e.g. attachment 128283 [details].
Comment 7 QA Administrators 2019-06-04 02:50:48 UTC Comment hidden (obsolete)
Comment 8 Roman Kuznetsov 2019-10-26 15:40:50 UTC
still repro in

Version: 6.4.0.0.alpha1+
Build ID: 706afd3e765e98489a2b43934a259626f9f0be01
CPU threads: 4; OS: Mac OS X 10.15; UI render: GL; VCL: osx; 
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 9 eisa01 2020-05-09 21:54:08 UTC
*** Bug 101938 has been marked as a duplicate of this bug. ***