Bug 117861 - VIEWING Signature Lines has visual name corruption issues
Summary: VIEWING Signature Lines has visual name corruption issues
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.beta1+
Hardware: x86-64 (AMD64) Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: CommonSalLayout-refactoring-regressions
  Show dependency treegraph
 
Reported: 2018-05-28 18:22 UTC by Christoffer
Modified: 2018-07-12 13:20 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
example signature document with the issue (14.91 KB, application/vnd.oasis.opendocument.text)
2018-05-28 18:23 UTC, Christoffer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoffer 2018-05-28 18:22:45 UTC
Description:
If you resize(when I noticed the issue) the signature line, sometimes the name looks corrupted. The issue also varies with page zoom level. Print-outs do not appear affected.
See the attached example document!

Steps to Reproduce:
1. Insert a Signature line with a name.
2. Resize it until you notice how the name looks like gibberish. 

Actual Results:  
The name looks like e.g. QHQ/ ERIJR/ EEEME

Expected Results:
The name looks the same independently of how it is resized or viewed


Reproducible: Sometimes


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.1.0.0.beta1 (x64)
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
Locale: sv-SE (sv_SE); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Comment 1 Christoffer 2018-05-28 18:23:35 UTC
Created attachment 142354 [details]
example signature document with the issue
Comment 2 Stéphane Guillou (stragu) 2018-05-29 03:30:22 UTC
Could not reproduce the bug (OpenGL is disabled).
When OpenGL enabled, my LibreOffice is just too broken to use.

Tested with:

Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 2; OS: Linux 3.13; UI render: default; VCL: kde4; 
Locale: en-GB (en_GB.UTF-8); Calc: group
Comment 3 raal 2018-05-29 05:18:00 UTC
no repro Version: 6.2.0.0.alpha0+
Build ID: c0fbf99e5601da27c59d131bcca24fafd259e508
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-05-24_22:08:37
Comment 4 Telesto 2018-05-30 14:12:40 UTC
Repro with
Version: 6.2.0.0.alpha0+
Build ID: 938ec2597be2e0ad3af2fb99f77de7f87285ad86
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-05-25_23:38:38
Locale: nl-NL (nl_NL); Calc: CL

Fine with
Previous HEAD position was e46da14a3... source 9615e45d2e2bac79c252a018846e4f20012cfa34

broken with
HEAD is now at 6aacbf038... source bdccb7e9991d83029eb2f2f11327b54534a00db8


author	Jan-Marek Glogowski <glogow@fbihome.de>	2017-12-26 15:14:31 +0000
committer	Khaled Hosny <khaledhosny@eglug.org>	2018-05-08 00:55:27 +0200
commit bdccb7e9991d83029eb2f2f11327b54534a00db8 (patch)
tree c32e95c49849647dc72c1071f375f3d2b67d8d7a
parent 9615e45d2e2bac79c252a018846e4f20012cfa34 (diff)
Refactor CommonSalLayout font handling
Moves all platform specific code from CommonSalLayout into the
platform specific plugins. This way the vcl library won't depend
on the Qt5 libraries and the Qt5Font header can be moved into the
qt5 VCL plugin.

While at it, switch the CommonSalLayouts font reference from the
FontSelectPattern to the LogicalFontInstance and also add the
harfbuzz font handling to the instance.
Comment 5 V Stuart Foote 2018-05-30 14:21:43 UTC
Confirmed Windows 10 Home 64-bit en-US (ver 1709) Intel HD 620
Version: 6.2.0.0.alpha0+ (x64)
Build ID: 5f1ce0a77c63df597fba9d4cbd45be3a266343c3
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-27_23:32:53
Locale: en-US (en_US); Calc: CL

Without OpenGL rendering the FontArt of the Signature line zooms correctly.
Comment 6 Xisco Faulí 2018-06-05 21:04:29 UTC
Adding Cc: to Jan-Marek Glogowski
Comment 7 V Stuart Foote 2018-07-12 13:20:05 UTC
This is Fixed. The font art in the signature line holds font and appearance with OpenGL rendering on zoom.

Retest with

Version: 6.2.0.0.alpha0+ (x64)
Build ID: 86ca9badf9be518be3456afde70271bc1f956065
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-07-11_02:27:04
Locale: en-US (en_US); Calc: CL

or later

=-ref-=

https://cgit.freedesktop.org/libreoffice/core/commit/?id=fad862e290d727fc9fefe206f6e4b807482c4175

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ca4e75d694a5fb41a1c800146319aa6ba34d8bab