Created attachment 142366 [details] How the "Select Firefox Theme" dialog looks like just before I clicked "Cancel". Steps to reproduce: 1. Launch LibreOffice; 2. Start a new Writer document; 3. Open the "Select Firefox Theme": - Open the "Tools" menu; - Select "Options..."; - Expand the "LibreOffice" section in the tree; - Select the "Personlisation" item in the tree; - Click the "Select Theme" button. 4. You will see the "Select Firefox Theme" dialog, with 9 gray rectangles, which are used to display theme previews; 5. Click one of the categories - e.g. "Abstract"; 6. LibreOffice will start loading and showing theme previews in those gray rectangles; 7. Click the "Cancel" button after just one or two previews are loaded and displayed. 8. Watch LibreOffice hang.
Kal, thank you for your report. I could reproduce the issue on macOS and Windows, versions 6.1.0.0.beta1 and 6.0.4.2. Setting the bug to NEW, changing the Hardware to All, since it affects two SOs. Debugging details: On macOS, the loading on step 6 prints the following message on the terminal: (pkix_CacheCert_Add: PKIX_PL_HashTable_Add for Certs skipped: entry existed
Regression introduced by: author Miklos Vajna <vmiklos@collabora.co.uk> 2018-04-24 17:44:54 +0200 committer Miklos Vajna <vmiklos@collabora.co.uk> 2018-04-24 22:28:20 +0200 commit 336d91a6f2bc12ff0342f984cdbb2cf64abd0b56 (patch) tree 9b5d85a6c65a6aa022186eea200dec3c57c928e2 parent 697ebd15d646e41bb69726f7b438ebbfaff141b0 (diff) tdf#113377 cui personalization: fix calling into VCL without necessary locking We assume the SolarMutex is always taken when doing GL calls, but putting DBG_TESTSOLARMUTEX() into WinOpenGLContext::makeCurrent() pointed out two places in the persona code where this invariant wasn't hold, fix those. Opening the dialog and downloading previews of one category, then clicking on an other button to download previews of an other category no longer results in a crash while calling glBindFramebuffer() with this. Bisected with: bibisect-linux64-6.1 Adding Cc: to Miklos Vajna
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=766c85a4f67f5d50645340e31cebd5956998c6fc tdf#117866 cui: avoid deadlock in personalization dialog It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f4ac7b5a084a7cf483bb89a2fa411f9df70df4d0 Related: tdf#117866 cui: use std::atomic for thread termination flag It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=400137b1d36e4296e4e297a4c570933e6572b38c&h=libreoffice-6-1 tdf#117866 cui: avoid deadlock in personalization dialog It will be available in 6.1.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.1.0.0.beta1+ Build ID: 8b96445766efe237eb47608ade6c147673466e2e CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group @Miklos, thanks for fixing this!!
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f4c73f90da2a2c31f0d29572180aa97e10c3dbad tdf#117866 cui personalization: fix a possible race It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea08ffc92d84e944a143902f9cd280370986a781&h=libreoffice-6-1 tdf#117866 cui personalization: fix a possible race It will be available in 6.1.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec8e973f7e681b0ae25e4b781918dd98ea0e8176&h=libreoffice-6-0 tdf#117866 cui: avoid deadlock in personalization dialog It will be available in 6.0.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'm still able to reproduce a similar issues: 1. Launch LibreOffice; 2. Start a new Writer document; 3. Open the "Select Firefox Theme": - Open the "Tools" menu; - Select "Options..."; - Expand the "LibreOffice" section in the tree; - Select the "Personlisation" item in the tree; - Click the "Select Theme" button. 4. You will see the "Select Firefox Theme" dialog, with 9 gray rectangles, which are used to display theme previews; 5. Click one of the categories - e.g. "Abstract"; 6. LibreOffice will start loading and showing theme previews in those gray rectangles; 7. Click the "Cancel" button (without waiting for a theme) 8. Press the Select Theme button again -> hang Alternative 7. Click the "OK" button (without waiting for a theme) -> Hang
(In reply to Telesto from comment #10) > I'm still able to reproduce a similar issues: > > 1. Launch LibreOffice; > 2. Start a new Writer document; > 3. Open the "Select Firefox Theme": > - Open the "Tools" menu; > - Select "Options..."; > - Expand the "LibreOffice" section in the tree; > - Select the "Personlisation" item in the tree; > - Click the "Select Theme" button. > 4. You will see the "Select Firefox Theme" dialog, with 9 gray rectangles, > which are used to display theme previews; > 5. Click one of the categories - e.g. "Abstract"; > 6. LibreOffice will start loading and showing theme previews in those gray > rectangles; > 7. Click the "Cancel" button (without waiting for a theme) > 8. Press the Select Theme button again -> hang > > Alternative > 7. Click the "OK" button (without waiting for a theme) -> Hang Hi Telesto, Could you please create a follow-up bug for this?