Bug 118063 - EDITING: Impress: After changing spacing, previous spacing remains checked
Summary: EDITING: Impress: After changing spacing, previous spacing remains checked
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2 all versions
Hardware: All All
: medium normal
Assignee: Ilhan Yesil
URL:
Whiteboard: target:6.2.0 target:6.1.0.2 target:7....
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-08 08:47 UTC by Ilhan Yesil
Modified: 2021-11-30 09:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ilhan Yesil 2018-06-08 08:47:54 UTC
Description:
If the line spacing is set to a different value in the Format menu, the previous value remains checked.

Steps to Reproduce:
Bug is similar to tdf#117847
1. Select Textbox
2. Goto menu Format->Spacing, then select another spacing(if 1.0 is selected, select 1.5 as example).
3. Goto menu Format->Spacing, at least two spacings are selected (1.0 and 1.5)

Actual Results:  
Spacings remaines checked

Expected Results:
Only one spacing is checked


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134
Comment 1 Ilhan Yesil 2018-06-08 08:48:15 UTC
Allready looked into the code and fixed it.
Comment 2 Susan Gessing 2018-06-11 17:13:40 UTC
Thank you for reporting the bug. I can confirm that the bug is present in
6.0.4.2 (x64), Windows.
Comment 3 Xisco Faulí 2018-06-12 08:12:10 UTC
Patch in gerrit: https://gerrit.libreoffice.org/#/c/55455/
Checking status to ASSIGNED
Comment 4 Commit Notification 2018-06-12 20:14:57 UTC
Ilhan Yesil committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5b72382516d94bc27321461297ded92f8af8112d

tdf#118063 Impress: Deselected spacing remained checked

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2018-07-13 10:11:16 UTC
A polite ping to Ilhan Yesil:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing?
Thanks
Comment 6 Xisco Faulí 2018-07-13 10:14:30 UTC
cherry-picked to 6-1: https://gerrit.libreoffice.org/#/c/57388/
Comment 7 Commit Notification 2018-07-13 17:14:21 UTC
Ilhan Yesil committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bee7d89904b1547185e1e7be4fb731d7fe7d8563&h=libreoffice-6-1

tdf#118063 Impress: Deselected spacing remained checked

It will be available in 6.1.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-11-26 20:59:36 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fcee6b02ebfcb82f3c191b1e6ef12ef9a3487711

tdf#118063 - Writer: Deselected line spacing items remained checked

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2021-11-30 09:10:27 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/b1b83c98512024830af03ab4cfbed3517036c6a1

tdf#118063 - Writer: Deselected line spacing items remained checked

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.