Description: If you change in Impress the line spacing via clicking on a preset in the format menu (like “1.5”), the original setting (“1”) remains checked. The result is that both settings are checked in the menu. Only one would be correct. The same issue also appears in ‘Format’ → ‘Align’. Impress has this issue since the menu was introduced in LO 5.0 Writer has not the issue, even though it has the same menus (‘Spacing’ and ‘Align’). In LO 5.0 are these menus already implemented in Impress, but not in Writer. Writer has them since LO 5.1, but no issue with them since then. Steps to Reproduce: 1. Start Impress 2. Choose any template 3. Click on the slide 4. Enter a word (like ‚Lorem‘) 5. Press Enter 6. Enter another word (like ‚Ipsum‘) 7. Mark both lines 8. Open menu format → spacing Setting should be „Line Spacing: 1“ 9. Choose from menu ‚Line Spacing: 1.5“ Spacing changes to 1.5 lines. 10. Open menu format → spacing 11. Now both settings (1 & 1.5) are marked. 12. Choose ‚Line Spacing: 2‘ Spacing changes to 2 lines. 13. All three spacing options are marked: 1, 1.5 and 2 Same with 'Align' Actual Results: It is possible to put checkmarks on multiple entries in 'Spacing' and 'Align' menu. Like 'Line Spacing: 1" AND 'Line Spacing: 2'. Expected Results: If I choose a different setting, then the checkmark from the original setting should disappear. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: I searched for “impress menu spacing”, but found no dupe. Version: 6.1.0.0.alpha0+ (x64) Build ID: 9e7caee0173c5ec2d8b5cfa6aedfd1c9674d442b CPU threads: 4; OS: Windows 6.1; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-19_22:55:34 Locale: de-DE (de_DE); Calc: group threaded I could also reproduce it in Ubuntu User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299
Created attachment 138576 [details] Screenshots
Confirmed using LO 5.4.4.2 / Windows 7.
Polite ping: Could somebody check if Calc is also affected? :-) (I don't know Calc. Issue affects Impress, but not Writer.)
Yes, it affects Calc as well, eg. you can set paragraph spacing in comments. I dug up the commits that added these entries to the menubar, but I have no idea how toggling works, and where that can be specified. Looks like a good easy hack candidate, adding the respective keywords. For reference, these commits add the menu entries to the menus: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6c189a1eb90012789692344aa7dc418c7ec7f032 tdf#91781 Reorganize writer's menu bar https://cgit.freedesktop.org/libreoffice/core/commit/?id=f37ccf3ed8aae4e2d5191fb97aa28446541ff790 rearrange Impress's format menu bar
Likely ' menu:style="radio"' need to be added to these menu items, like they are there in writer https://cgit.freedesktop.org/libreoffice/core/tree/sw/uiconfig/swriter/menubar/menubar.xml#n398
Thanks for the hint Jay! The question is, why isn't it there for the line spacing menu entries?
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The Impress parts are fixed by the following commits. In Calc/Writer comments, still multiple spacings get selected (6.4.0.0.alpha0+ / d3d13140f0036c53aa74820b41acfeffa3572168). https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b72382516d94bc27321461297ded92f8af8112d author Ilhan Yesil <ilhanyesil@gmx.de> 2018-06-08 10:49:41 +0200 committer Thorsten Behrens <Thorsten.Behrens@CIB.de> 2018-06-12 22:14:21 +0200 tdf#118063 Impress: Deselected spacing remained checked https://cgit.freedesktop.org/libreoffice/core/commit/?id=07610feeeff47fc5bbe057c91c50ffae54a41c85 author Ilhan Yesil <ilhanyesil@gmx.de> 2018-05-28 11:05:30 +0200 committer Katarina Behrens <Katarina.Behrens@cib.de> 2018-05-29 09:45:50 +0200 tdf#117847 Impress: Deselected alignment remained checked
Dear Mike, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Hi! I fixed the line spacing issue for comments in Writer. However, I could not find the menu item for the line spacing in Calc. Maybe someone of you could enlight me :)
Hi Andreas! Thanks for that, I checked now, and these menu items have been removed by the following commit for bug 136071. So, this can be closed (please add a reference to the change that fixed this in Writer). https://cgit.freedesktop.org/libreoffice/core/commit/?id=ce9e965b3fc3744b99afee07f6d56860852af5e4
Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fcee6b02ebfcb82f3c191b1e6ef12ef9a3487711 tdf#114631 - Writer: Deselected line spacing items remained checked It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.