Download it now!
Bug 114631 - Calc and Impress UI - putting checkmarks on multiple entries in 'Spacing' and 'Align' menus possible
Summary: Calc and Impress UI - putting checkmarks on multiple entries in 'Spacing' and...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError, needsDevEval, topicUI
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2017-12-21 17:53 UTC by Mike
Modified: 2019-08-24 23:51 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshots (627.55 KB, application/pdf)
2017-12-21 17:58 UTC, Mike
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike 2017-12-21 17:53:11 UTC
Description:
If you change in Impress the line spacing via clicking on a preset in the format menu (like “1.5”), the original setting (“1”) remains checked. The result is that both settings are checked in the menu. Only one would be correct.

The same issue also appears in ‘Format’ → ‘Align’. Impress has this issue since the menu was introduced in LO 5.0 Writer has not the issue, even though it has the same menus (‘Spacing’  and ‘Align’). In LO 5.0 are these menus already implemented in Impress, but not in Writer. Writer has them since LO 5.1, but no issue with them since then.

Steps to Reproduce:
1. Start Impress
2. Choose any template
3. Click on the slide
4. Enter a word (like ‚Lorem‘)
5. Press Enter
6. Enter another word (like ‚Ipsum‘)
7. Mark both lines
8. Open menu format → spacing
Setting should be „Line Spacing: 1“
9. Choose from menu ‚Line Spacing: 1.5“
Spacing changes to 1.5 lines.
10. Open menu format → spacing
11. Now both settings (1 & 1.5) are marked.
12. Choose ‚Line Spacing: 2‘
Spacing changes to 2 lines.
13. All three spacing options are marked: 1, 1.5 and 2

Same with 'Align'

Actual Results:  
It is possible to put checkmarks on multiple entries in 'Spacing' and 'Align' menu. Like 'Line Spacing: 1" AND 'Line Spacing: 2'. 

Expected Results:
If I choose a different setting, then the checkmark from the original setting should disappear.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
I searched for “impress menu spacing”, but found no dupe.

Version: 6.1.0.0.alpha0+ (x64)
Build ID: 9e7caee0173c5ec2d8b5cfa6aedfd1c9674d442b
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-12-19_22:55:34
Locale: de-DE (de_DE); Calc: group threaded

I could also reproduce it in Ubuntu



User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299
Comment 1 Mike 2017-12-21 17:58:22 UTC
Created attachment 138576 [details]
Screenshots
Comment 2 Aron Budea 2017-12-21 22:10:37 UTC
Confirmed using LO 5.4.4.2 / Windows 7.
Comment 3 Mike 2018-01-27 19:05:17 UTC
Polite ping: Could somebody check if Calc is also affected? :-) (I don't know Calc. Issue affects Impress, but not Writer.)
Comment 4 Aron Budea 2018-01-27 22:07:22 UTC
Yes, it affects Calc as well, eg. you can set paragraph spacing in comments.

I dug up the commits that added these entries to the menubar, but I have no idea how toggling works, and where that can be specified.
Looks like a good easy hack candidate, adding the respective keywords.

For reference, these commits add the menu entries to the menus:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=6c189a1eb90012789692344aa7dc418c7ec7f032
tdf#91781 Reorganize writer's menu bar

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f37ccf3ed8aae4e2d5191fb97aa28446541ff790
rearrange Impress's format menu bar
Comment 5 Yousuf Philips (jay) (retired) 2018-01-28 16:12:21 UTC
Likely ' menu:style="radio"' need to be added to these menu items, like they are there in writer

https://cgit.freedesktop.org/libreoffice/core/tree/sw/uiconfig/swriter/menubar/menubar.xml#n398
Comment 6 Aron Budea 2018-01-28 19:22:12 UTC
Thanks for the hint Jay! The question is, why isn't it there for the line spacing menu entries?
Comment 7 QA Administrators 2019-01-29 03:48:23 UTC Comment hidden (obsolete)
Comment 8 Aron Budea 2019-08-24 23:51:04 UTC
The Impress parts are fixed by the following commits.
In Calc/Writer comments, still multiple spacings get selected (6.4.0.0.alpha0+ / d3d13140f0036c53aa74820b41acfeffa3572168).

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b72382516d94bc27321461297ded92f8af8112d
author		Ilhan Yesil <ilhanyesil@gmx.de>	2018-06-08 10:49:41 +0200
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2018-06-12 22:14:21 +0200
tdf#118063 Impress: Deselected spacing remained checked

https://cgit.freedesktop.org/libreoffice/core/commit/?id=07610feeeff47fc5bbe057c91c50ffae54a41c85
author		Ilhan Yesil <ilhanyesil@gmx.de>	2018-05-28 11:05:30 +0200
committer	Katarina Behrens <Katarina.Behrens@cib.de>	2018-05-29 09:45:50 +0200
tdf#117847 Impress: Deselected alignment remained checked