Created attachment 164631 [details] Screenshot of the problem in Calc Since Calc 5.1 the Format – Spacing menu in Calc contains some items that cannot be used: Line Spacing: 1 ; Line Spacing: 1.5 ; Line Spacing: 2; Increase Paragraph Spacing and Decrease Paragraph Spacing are always greyed out. Steps to reproduce: 1. In Calc go to Format - Spacing Actual results: Only the Increase Indent and Decrease Indent commands are usable, all others are greyed out no matter what is selected: empty cell, non-empty cell, cell with selected text – the commands are greyed out. Line spacing and paragraph spacing settings are not present in the Format Cells dialog either. Expected results: Only the two usable commands should be available, the unusable ones are only confusing users. LibreOffice details: Version: 7.1.0.0.alpha0+ (x86) Build ID: a06a83b29a9da770787bffe416b138102aa12531 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL Also happens way back to: Version: 5.1.0.3 Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737 CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; Locale: en-US (hu_HU) But not yet in: Version: 5.0.0.5 Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b Locale: hu-HU (hu_HU) Additional Information: Bibisected using bibisect-win32-5.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ce5470cb3eb7e5394ef1d7cb1906886abab80d5d author Yousuf Philips <philipz85@hotmail.com> 2015-06-05 00:52:21 +0400 committer Yousuf Philips <philipz85@hotmail.com> 2015-06-05 19:53:15 +0000 tdf#91820 Reorganize calc's menu bar
These commands work inside shapes.
(In reply to Maxim Monastirsky from comment #1) > These commands work inside shapes. Indeed, thanks. Also work for text put above an image. Another side note: Increase Indent and Decrease Indent are greyed out in case of text in shape/image. So the first five and second two command do not really "belong" together. Then they are not entirely useless, but still: perhaps these are placed at too high a level. In case of text put on shape/image the Format - Object - Text item is enabled, so: * Maybe these would fit better under Format - Object - Spacing -> ( Line Spacing: 1 ; Line Spacing: 1.5 ; Line Spacing: 2; Increase Paragraph Spacing and Decrease Paragraph Spacing ) * Format - Spacing could ** either keep the "Increase Indent" and "Decrease Indent" commands ** or the commands could go over to Format - Text without an own submenu; since these affect the Format Cells - Alignment - Text Alignment - Indent value. Anyways: it's time to ask the UX team :).
Let's will not touch a main menu
Roman's argument is to keep the menu familiar (only absolute necessary changes are accepted) and consistent (same commands on same position across modules). In this particular case it leads to confusion, however, since without Maxim nobody would know where spacing can be applied. Dealing with shapes is a secondary use case, at best, and I tend to agree with removal from the menu.
Please remember to update Help as I just recently created it for Format - Spacing across the suite: https://gerrit.libreoffice.org/c/help/+/99383
We discussed the topic in the design meeting. And since spacing is so special for Calc the recommendation is to remove it completely. All functions are available via context menu, sidebar, or the paragraph properties dialog. This also applies to indentation. sc/uiconfig/scalc/menubar/menubar.xml -> <menu:menu menu:id=".uno:FormatSpacingMenu">
Proposed patch implementing comment #6: https://gerrit.libreoffice.org/c/core/+/103078
Thanks, Gabor!
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ce9e965b3fc3744b99afee07f6d56860852af5e4 tdf#136071 Drop mostly useless Format - Spacing menu from Calc It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Who will update the Help? Status changed too quickly.
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/9b4e021c4ba2cd74ebd81bf0a46efc762ad36931 tdf#136071 (related) Remove Spacing submenu from Calc Format menu reference