Bug 118127 - Format duplication in Hungarian Locale Settings
Summary: Format duplication in Hungarian Locale Settings
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-12 12:24 UTC by Gabor Kelemen (allotropia)
Modified: 2019-02-06 19:15 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2018-06-12 12:24:46 UTC
In 
https://cgit.freedesktop.org/libreoffice/core/tree/i18npool/source/localedata/data/hu_HU.xml

the following date formats are duplicated:

YYYY". "MMMM D.	3x
YY-MM-DD	2x
YYYY-MM-DD	2x
YYYY". "MMM D.	2x
YYYY-MM-DD HH:MM:SS	2x

And the following time format:

YYYY-MM-DD HH:MM:SS	2x

Actual results:
The rows listed above are multiple times in the code (three times, twice, twice, twice).

Expected results:
One individual format code should only be used once.
Comment 1 Gabor Kelemen (allotropia) 2018-06-12 12:26:54 UTC
Please leave this open, I know a new volunteer for this task :)
Comment 2 László Németh 2018-06-12 12:45:41 UTC
There is a fix in https://gerrit.libreoffice.org/#/c/55637/ for the plain dates.

The reason of the same format was the fixed format for back compatibility:

https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/locale.dtd#223

Using the NatNum12, it's possible to replace the duplicates with useful date variants.
Comment 3 Gabor Kelemen (allotropia) 2018-08-07 14:54:45 UTC
Adam, maybe one for you?
With a bit of mentoring by Laszlo.
Comment 4 Commit Notification 2018-08-16 14:43:38 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=61c713bf93a1c585730b97265e2ba7a5a4d09d1d

tdf#118127 fix date format duplications in Hungarian locale

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2018-09-17 11:38:13 UTC
A polite ping to László Németh:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing?
Thanks
Comment 6 László Németh 2018-09-17 11:52:14 UTC
Xisco, Eike: The commit has solved this problem. The started 6.1 backport (https://gerrit.libreoffice.org/#/c/59201/.) got -1 from Eike, related to the overuse of the month abbreviations for the two kind of Hungarian month abbreviations, but maybe this is not a serious problem, regarding to the non-existing 1-letter month abbrevations of Hungarian. See his comments and my questions in https://gerrit.libreoffice.org/#/c/59171/. Eike, what is your opinion, is it ok to close this issue, as resolved/fixed, also accepting its backport? Thanks for your helps!
Comment 7 Eike Rathke 2018-09-18 22:12:40 UTC
Please see my latest comment at https://gerrit.libreoffice.org/59171
I don't think the change qualifies for a backport, it does not solve the month name problem because the narrow name formats are not persistent in an ODF roundtrip.
Comment 8 Commit Notification 2018-10-03 10:09:35 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e85966450b770e1169f113183ce1a9a9f4dcc507

Related: tdf#119613 tdf#118127 suppress duplicated builtins, rework All cat

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.