Bug 118133 - FILESAVE: DOC: Image is missing if roundtrip is done in headless mode
Summary: FILESAVE: DOC: Image is missing if roundtrip is done in headless mode
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: high major
Assignee: Miklos Vajna
URL:
Whiteboard: target:6.2.0 target:6.1.0.1 target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-imageHandling
  Show dependency treegraph
 
Reported: 2018-06-12 23:43 UTC by Xisco Faulí
Modified: 2023-08-03 13:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (1.47 MB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2018-06-12 23:43 UTC, Xisco Faulí
Details
How the document looks after RT (1.43 MB, application/msword)
2018-06-12 23:44 UTC, Xisco Faulí
Details
Sample 2 (30.00 KB, application/msword)
2018-06-13 00:53 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-06-12 23:43:33 UTC
Created attachment 142691 [details]
sample file

Steps to reproduce:
1. Open attached document
2. Save it as .DOC with -headless --convert-to doc
3. Open the output file

Observed behaviour: the image 'Proof Points is missing.

Reproduced in

Version: 6.2.0.0.alpha0+
Build ID: 4c6e11886a9d396bf7be18e9e3209a73c6e303ad
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2018-06-12 23:44:23 UTC
Created attachment 142692 [details]
How the document looks after RT
Comment 2 Xisco Faulí 2018-06-12 23:46:18 UTC
Regression introduced by:

author	Miklos Vajna <vmiklos@collabora.co.uk>	2018-04-20 16:32:00 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2018-04-20 21:04:35 +0200
commit edda1e5fc8113aa4744e32f97c96a3cc311485ca (patch)
tree b6da5a4a637a9a3ae3ed9307fe59d6f1df80b197
parent e9c52f55f0cc7155d6883e4d2abf14f1638b03b3 (diff)
DOCX import: lazy-read images without external headers
So that similar to ODT, images are not loaded on file open, only when
the user scrolls there.

Bisected with: bibisect-linux64-6.2

Adding Cc: to Miklos Vajna
Comment 3 Xisco Faulí 2018-06-13 00:53:27 UTC
Created attachment 142693 [details]
Sample 2

Another file affected by the same problem
Comment 4 Xisco Faulí 2018-06-13 11:19:25 UTC
The office-interoperability-tools found all these files affected by this problem:

fdo55529-1.doc
moz551399-1.doc
abi9747-1.doc
fdo62613-2.doc
kde239662-1.doc
moz1026685-3.doc
moz1028992-1.doc
abi6418-1.doc
gentoo131686-1.doc
fdo38619-3.doc
tdf104028-1.doc
fdo33613-3.doc
fdo37192-1.doc
fdo65285-1.doc
fdo71703-1.doc
fdo71290-1.doc
tdf104027-3.doc
fdo88163-1.doc

Raising severity
Comment 5 Commit Notification 2018-06-26 07:05:20 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa356008b08a8a5b5556aa8f89ca8f7989c53516

tdf#118133 DOCX import: disable lazy-loading of tiff images

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Miklos Vajna 2018-06-26 07:35:50 UTC
This above commit addresses the tiff-in-docx case, should help with other OOXML formats as well. Please open a follow-up bug if there are still other cases left with a different root cause. Thanks!
Comment 7 Commit Notification 2018-06-26 12:00:54 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d647dc45b9ae0494e4f3185a6eb85e006b336b00&h=libreoffice-6-1

tdf#118133 DOCX import: disable lazy-loading of tiff images

It will be available in 6.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2018-06-27 09:21:44 UTC
Verified in

Version: 6.2.0.0.alpha0+
Build ID: 6ebc026e34d0c119067e7dfbad8d932f92844760
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

@Miklos, Thanks for fixing this!!
Comment 9 Commit Notification 2021-03-11 14:03:02 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c6bf16909db054ec5467ebdc0ea0c9dc07307048

Revert "tdf#118133 DOCX import: disable lazy-loading of tiff images"

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.