Bug 118230 - Replace... command does not remember order of alignment of elements after picture is placed
Summary: Replace... command does not remember order of alignment of elements after pic...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-06-18 18:41 UTC by xordevoreaux
Modified: 2019-06-27 22:04 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description xordevoreaux 2018-06-18 18:41:39 UTC
Description:
I have a text box for a caption positioned on top of a picture. I want to keep the caption but replace the picture. When right-clicking the picture and using the Replace... command on the context menu, the picture gets replaced, but winds up on top of any other elements that were previously on top of the picture.

Steps to Reproduce:
1.Open Draw.
2.Place a picture.
3.Create a text box and position it on top of the picture so it overlaps.
4.Right-click the picture.
5.From the context menu, select Replace...
6.Replace the picture with another picture 

Actual Results:
The new picture comes in on top of the other elements

Expected Results:
The new picture should be placed in the same alignment order as the original picture that it replaced.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
It's tedious having to move the alignment order of the picture every time I replace it, and I replace pics often.
Comment 1 Susan Gessing 2018-06-18 22:51:31 UTC
I was able to reproduce on:

Version: 6.0.5.1 (x64)
Build ID: 0588a1cb9a40c4a6a029e1d442a2b9767d612751
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
Locale: en-US (en_US); Calc: CL

and

Version: 6.2.0.0.alpha0+
Build ID: b1740fba0d1e6e3d69c3781734509317f42a0e4f
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-06-15_08:49:04
Locale: en-US (en_US); Calc: CL
Comment 2 Susan Gessing 2018-06-19 14:21:28 UTC
Tested on Windows 8.1.
Comment 3 Xisco Faulí 2018-06-20 16:10:33 UTC
Regression introduced by:

author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2016-07-05 12:05:28 +0000
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2016-07-05 19:58:48 +0000
commit fd6655080e181de4b78e31f13fe8ba35de8edfe5 (patch)
tree b132314cd39e107b818f057cda33c07e6e9f2e47
parent 28a03248b1d1649e157b788e43dfe8326f165379 (diff)
tdf#73742 Don't replace existing image when inserting one
If we want to replace an image, we have an entry in the context menu for that.

Bisected with: bibisect-linux-64-5.3

Adding Cc: to Samuel Mehrbrodt
Comment 4 xordevoreaux 2018-06-21 03:43:05 UTC
(In reply to Xisco Faulí from comment #3)
> Regression introduced by:
> 
> author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2016-07-05 12:05:28 +0000
> committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2016-07-05 19:58:48
> +0000
> commit fd6655080e181de4b78e31f13fe8ba35de8edfe5 (patch)
> tree b132314cd39e107b818f057cda33c07e6e9f2e47
> parent 28a03248b1d1649e157b788e43dfe8326f165379 (diff)
> tdf#73742 Don't replace existing image when inserting one
> If we want to replace an image, we have an entry in the context menu for
> that.
> 
> Bisected with: bibisect-linux-64-5.3
> 
> Adding Cc: to Samuel Mehrbrodt

I'm not entirely sure, but I suspect you're missing the point. It's not the act of replacing the image that's the problem. It's where the replacement image lands in terms of the top-down order of items on the document.

Currently, once the image is replaced, it always occupies the top-most position in the hierarchy rather than honoring the placement of the position of the picture which it replaced. That is the bug.
Comment 5 QA Administrators 2019-06-27 02:53:59 UTC Comment hidden (obsolete)
Comment 6 xordevoreaux 2019-06-27 22:02:20 UTC
Bug does not happen in Version: 6.3.0.0.beta2 (x64)