Open DOC attachment 52631 [details] from Bug 42112 or .DOCX attachment 144474 [details] from Bug 119529.
Double click diagram to open embedded document.
Could be open and edited with 6.1, but opens read-only in 6.2+ so we cannot edit it.
Not sure if regression or on purpose because editing is wrong.
Note: if one has MSO, depending on settings, double click can open MSO but it should open LO, as can be seen where there's no MSO.
I confirm it with the doc-File. When I save it as odt and reopen it, I have the same result.
This seems to have begun at the below commit.
Adding Cc: to Aron Budea ; Could you possibly take a look at this one?
9879ac3f90c7b96efeb13e0b69f7638d88e69933 is the first bad commit
Author: Jenkins Build User <firstname.lastname@example.org>
Date: Fri Jul 13 18:52:56 2018 +0200
author Aron Budea <email@example.com> 2017-08-02 03:34:24 +0200
committer Jan Holesovsky <firstname.lastname@example.org> 2018-07-13 18:25:27 +0200
commit c1817a5b12da642e365a3ef72b556d33c6e29a76 (patch)
parent 1549ff45e14fccec653c2db927393c9710173e6b (diff)
tdf#110987: type detection, binary Office formats > templates
The templates for binary MS Office formats were higher prioritized
than non-templates, this caused files in binary format and lacking
file extension to be identified as templates.
The commit has been reverted (it wasn't that useful), thanks for finding and bibisecting this bug!
Revert "tdf#110987: type detection, binary Office formats > templates"
I tried to verify the bug fix, but I couldn't open embedded document. I always got the error message "Error activating object: General OLE error."
This happened with both files in
Version: 22.214.171.124.alpha0+ (x64)
Build ID: f0c832acb53326ccc9a8c1a47401fbc9e1081feb
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win;
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-09-11_05:46:53
Locale: de-DE (de_DE); UI-Language: en-US
as well as in
Version: 126.96.36.199 (x64)
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win;
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
I tested with 6.4+.
In Linux, embedded documents open as read-only .tmp file, so not fixed.
In Windows, embedded document opens with MSO (if installed) instead with LO.
As you can see the fixing commit is a simple revert of the bibisected commit. Whatever the issue is, either it had been there before, or is caused by an unrelated change. Therefore this bug report can remain closed as FIXED. Please open a separate bug report.
It makes no sense to open a new bug, when this one is clear in description.
Regardless of commits, issue not resolved.
I don't want to spent my time on that, for false stats.
As I mentioned, the commit clearly reverts the identified causing commit, and fixed the regression at the time. If the bug came back, it's a new issue, which should be in a separate bug report.
For the record, this issue re-emerge with the following commit, feel free to reference that in the new bug report:
Aron, please do not close my bug report.
I appreciate your info, but you should appreciate anyone who bothered to write bug report, and you are not entitled to close it.
I am assigned to this, it was fixed after my revert, and what you are seeing now is technically not the same issue that you saw back then, the causing commit is from several months later. Please don't reopen this bug report.
Opened bug 129944 on the current issue.