Bug 119589 - FILESAVE: ODT: paragraph spacing not preserved after RT
Summary: FILESAVE: ODT: paragraph spacing not preserved after RT
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: high major
Assignee: Justin L
URL:
Whiteboard: target:6.2.0
Keywords: bibisected, bisected, filter:odt, regression
Depends on:
Blocks:
 
Reported: 2018-08-29 14:57 UTC by Xisco Faulí
Modified: 2018-09-13 14:40 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Comparison before and after (20.57 KB, image/png)
2018-08-29 14:57 UTC, Xisco Faulí 		Details
another file affected (418.20 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2018-08-29 15:16 UTC, Xisco Faulí 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-08-29 14:57:11 UTC 
Created attachment 144534 [details]
Comparison before and after

Steps to reproduce:
1. Open attachment 100131 [details] from bug 78470
2. Save it as .ODT ( Not reproduced as .DOC/.DOCX )
3. Open the new file

Observed behaviour: Paragraph spacing is 0. See attached comparison

Reproduced in

Version: 6.2.0.0.alpha0+
Build ID: 3bd8316718fdfed454c01a9c4ae6af6beb34437d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2018-08-29 14:58:59 UTC 
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2c00f5c896bee61033b93ddb9f32d959b0b01e94

author	Justin Luth <justin_luth@sil.org>	2018-07-27 13:29:39 +0300
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2018-08-08 12:33:46 +0200
commit 2c00f5c896bee61033b93ddb9f32d959b0b01e94 (patch)
tree ff3645619586e6793759c49f27ac5af0e9675863
parent 674416a2f16dfa050a23f2b1f0b749214ea1f2a6 (diff)
tdf#103961: delay merge of default props until export

Bisected with: bibisect-linux64-6.2

Adding Cc: to Justin Luth

Increasing severity as many files are affected based on the results from office-interoperability-tools
Comment 2 Xisco Faulí 2018-08-29 15:05:58 UTC 
attachment 83725 [details] from bug 67830 is also affected
Comment 3 Xisco Faulí 2018-08-29 15:08:24 UTC 
or attachment 134903 [details] from bug 65393
Comment 4 Xisco Faulí 2018-08-29 15:16:25 UTC 
Created attachment 144535 [details]
another file affected

@Justin, If you need more documents affected, I can provide them, for now, you have 4 affected...
Comment 5 Justin L 2018-09-01 04:53:07 UTC 
Probably am going to have to revert that patch.  It was an "enable to solve problems in the future" patch mainly for table-styles.

But in core/xmloff, ODT exportTextStyles doesn't export the RUNNING default "Paragraph style", but just a createInstance( "com.sun.star.text.Defaults" ). So EVERYTHING that I dump in defaults is going to be lost. And every unit test breaks if you DO save the running  defaults because of an invalid draw:fill attribute (long-standing bugs 94768 and bug 103602 I think).
Comment 6 Justin L 2018-09-12 18:14:44 UTC 
fixed by http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca762d7016ac1271a17e2d4371cca71a78455376

~revert tdf#103961: delay merge of default props until export

It will be available in 6.2.0.
Comment 7 Xisco Faulí 2018-09-13 14:40:02 UTC 
Verified in

Version: 6.2.0.0.alpha0+
Build ID: b74db4138342f646fda061eac5d6759ecf2c366f
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded