Bug 119649 - FILEOPEN: PPTX: color isn't imported correctly after pptx roundtrip
Summary: FILEOPEN: PPTX: color isn't imported correctly after pptx roundtrip
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:pptx, regression
Depends on:
Blocks: PPTX
  Show dependency treegraph
 
Reported: 2018-09-02 19:54 UTC by Jens Mildner
Modified: 2019-01-08 18:59 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Original odp file (219.74 KB, application/vnd.oasis.opendocument.presentation)
2018-09-02 19:55 UTC, Jens Mildner
Details
Page 8 how it should look (116.20 KB, application/pdf)
2018-09-02 19:56 UTC, Jens Mildner
Details
Page 8 how it actually looks after pptx roundtrip (45.61 KB, application/pdf)
2018-09-02 19:56 UTC, Jens Mildner
Details
PPTX file, created with Office 365, which is wrongly imported by LibreOffice (55.16 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2018-09-04 00:33 UTC, Bartosz
Details
PPTX file, created with LibreOffice, which is importing correctly (27.05 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2018-09-04 02:52 UTC, Bartosz
Details
Minimal ODP doc with wrong roundtrip (12.64 KB, application/vnd.oasis.opendocument.presentation)
2018-09-04 20:04 UTC, Jens Mildner
Details
Minimal PPTX doc wrongly imported (20.73 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2018-09-04 20:05 UTC, Jens Mildner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Mildner 2018-09-02 19:54:32 UTC
Description:
Open the attached odp file in Impress and export it to PowerPoint 2007-2010 (pptx) format, then reopen the pptx in Impress, compare with the odp. 

On pages 8, 11, 13 and 16, the whole text becomes purple since the first purple character.

Actual Results:
Please see file OrderCore_Brainstorming_Page8_pptx.pdf

Expected Results:
Please see file OrderCore_Brainstorming_Page8_odp.pdf


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Jens Mildner 2018-09-02 19:55:52 UTC
Created attachment 144614 [details]
Original odp file
Comment 2 Jens Mildner 2018-09-02 19:56:31 UTC
Created attachment 144615 [details]
Page 8 how it should look
Comment 3 Jens Mildner 2018-09-02 19:56:58 UTC
Created attachment 144616 [details]
Page 8 how it actually looks after pptx roundtrip
Comment 4 Jens Mildner 2018-09-02 19:57:32 UTC
Oh, I forgot:

Opening the pptx file in PowerPoint, the pages look okay.
Comment 5 Xisco Faulí 2018-09-03 16:17:16 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8129ad7b22dceeb2fef13741aa509c2229cf03de

author	Bartosz Kosiorek <gang65@poczta.onet.pl>	2017-05-24 01:13:26 +0200
committer	Markus Mohrhard <markus.mohrhard@googlemail.com>	2017-05-31 11:50:42 +0200
commit	8129ad7b22dceeb2fef13741aa509c2229cf03de (patch)
tree	bdba1bd9ae93d50451b4f6e65981ef4fd077fe59
parent	2eceb468728088a84ad1a2b192e23e275b4b907a (diff)
tdf#104219 Don't export color information when color is automatic

Bisected with: bibisect-linux64-6.0

Adding Cc: to Bartosz Kosiorek
Comment 6 Bartosz 2018-09-03 23:19:18 UTC
I investigated this issue, and it is not regresion, rather pptx import issue. The same problem will appear after saving by MS Office.
Comment 7 Bartosz 2018-09-03 23:24:16 UTC
Please attach exported pptx file.
Comment 8 Bartosz 2018-09-04 00:33:24 UTC
Created attachment 144649 [details]
PPTX file, created with Office 365, which is wrongly imported by LibreOffice

Generally problem is that the LibreOffice is not restarting colours, when colour is not specified. 
Example in slide1.xml:
 <a:r>
                            <a:rPr lang="de-DE" sz="2200" b="0" strike="noStrike" spc="-1" dirty="0">
                                <a:solidFill>
                                    <a:srgbClr val="800080"/>
                                </a:solidFill>
                                <a:latin typeface="Arial"/>
                            </a:rPr>
                            <a:t>Monat</a:t>
                        </a:r>
                        <a:r>
                            <a:rPr lang="de-DE" sz="2200" b="0" strike="noStrike" spc="-1" dirty="0">
                                <a:latin typeface="Arial"/>
                            </a:rPr>
                            <a:t>)</a:t>
                        </a:r>

The closing bracket <a:t>)</a:t> should have default colour. 
In previous implementation of export, all colours were exported explicetely. It means that information about Default Colour was lost.
Now, when we already have export done properly, we could fix import.
Comment 9 Bartosz 2018-09-04 02:34:48 UTC
@Jens I was tried to reproduce this issue from scratch (by creating new ODP presentation and export to PPTX), but unfortunately after export it opens correctly.

Could you please reproduce this issue on new minimal presentation and provide instruction how to create such wrong presentation?
Comment 10 Bartosz 2018-09-04 02:52:48 UTC
Created attachment 144650 [details]
PPTX file, created with LibreOffice, which is importing correctly
Comment 11 Jens Mildner 2018-09-04 20:04:44 UTC
Created attachment 144678 [details]
Minimal ODP doc with wrong roundtrip
Comment 12 Jens Mildner 2018-09-04 20:05:31 UTC
Created attachment 144679 [details]
Minimal PPTX doc wrongly imported
Comment 13 Jens Mildner 2018-09-04 20:16:27 UTC
Hi Xisco, hi Bartosz,

thanks for caring! :)

Step by step instructions on how to create a minimal bug document:

1) Open Impress

Version: 6.1.0.3
Build-ID: libreoffice-6.1.0.3-snap1
CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: gtk3; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group threaded

2) cancel choosing a template

3) type "default_color(colored_text)" in the text box (no headline)

4) select "colored_text" without the brackets

5) choose font color red in the sidebar

6) deselect and save as "PowerPoint 2007-2019 (.pptx)" format

7) use pptx format despite the warning that not everything will be safed in pptx format

8) Reopen in Impress: the last bracket is also red

Thanks,
Jens
Comment 14 Bartosz 2018-09-05 15:13:16 UTC
After resave minimal document with MS PowerPoint, the LibreOffice opening PPTX file properly.
Unfortunately I was unable to find what exactly causes this wrong import.
I will keep investigating it.
Comment 15 Xisco Faulí 2018-12-05 09:48:49 UTC
Dear Bartosz,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.