Description: Open the attached odp file in Impress and export it to PowerPoint 2007-2010 (pptx) format, then reopen the pptx in Impress, compare with the odp. On pages 8, 11, 13 and 16, the whole text becomes purple since the first purple character. Actual Results: Please see file OrderCore_Brainstorming_Page8_pptx.pdf Expected Results: Please see file OrderCore_Brainstorming_Page8_odp.pdf Reproducible: Always User Profile Reset: No Additional Info:
Created attachment 144614 [details] Original odp file
Created attachment 144615 [details] Page 8 how it should look
Created attachment 144616 [details] Page 8 how it actually looks after pptx roundtrip
Oh, I forgot: Opening the pptx file in PowerPoint, the pages look okay.
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8129ad7b22dceeb2fef13741aa509c2229cf03de author Bartosz Kosiorek <gang65@poczta.onet.pl> 2017-05-24 01:13:26 +0200 committer Markus Mohrhard <markus.mohrhard@googlemail.com> 2017-05-31 11:50:42 +0200 commit 8129ad7b22dceeb2fef13741aa509c2229cf03de (patch) tree bdba1bd9ae93d50451b4f6e65981ef4fd077fe59 parent 2eceb468728088a84ad1a2b192e23e275b4b907a (diff) tdf#104219 Don't export color information when color is automatic Bisected with: bibisect-linux64-6.0 Adding Cc: to Bartosz Kosiorek
I investigated this issue, and it is not regresion, rather pptx import issue. The same problem will appear after saving by MS Office.
Please attach exported pptx file.
Created attachment 144649 [details] PPTX file, created with Office 365, which is wrongly imported by LibreOffice Generally problem is that the LibreOffice is not restarting colours, when colour is not specified. Example in slide1.xml: <a:r> <a:rPr lang="de-DE" sz="2200" b="0" strike="noStrike" spc="-1" dirty="0"> <a:solidFill> <a:srgbClr val="800080"/> </a:solidFill> <a:latin typeface="Arial"/> </a:rPr> <a:t>Monat</a:t> </a:r> <a:r> <a:rPr lang="de-DE" sz="2200" b="0" strike="noStrike" spc="-1" dirty="0"> <a:latin typeface="Arial"/> </a:rPr> <a:t>)</a:t> </a:r> The closing bracket <a:t>)</a:t> should have default colour. In previous implementation of export, all colours were exported explicetely. It means that information about Default Colour was lost. Now, when we already have export done properly, we could fix import.
@Jens I was tried to reproduce this issue from scratch (by creating new ODP presentation and export to PPTX), but unfortunately after export it opens correctly. Could you please reproduce this issue on new minimal presentation and provide instruction how to create such wrong presentation?
Created attachment 144650 [details] PPTX file, created with LibreOffice, which is importing correctly
Created attachment 144678 [details] Minimal ODP doc with wrong roundtrip
Created attachment 144679 [details] Minimal PPTX doc wrongly imported
Hi Xisco, hi Bartosz, thanks for caring! :) Step by step instructions on how to create a minimal bug document: 1) Open Impress Version: 6.1.0.3 Build-ID: libreoffice-6.1.0.3-snap1 CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: gtk3; Gebietsschema: de-DE (de_DE.UTF-8); Calc: group threaded 2) cancel choosing a template 3) type "default_color(colored_text)" in the text box (no headline) 4) select "colored_text" without the brackets 5) choose font color red in the sidebar 6) deselect and save as "PowerPoint 2007-2019 (.pptx)" format 7) use pptx format despite the warning that not everything will be safed in pptx format 8) Reopen in Impress: the last bracket is also red Thanks, Jens
After resave minimal document with MS PowerPoint, the LibreOffice opening PPTX file properly. Unfortunately I was unable to find what exactly causes this wrong import. I will keep investigating it.
Dear Bartosz, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this.
So, not a regression, since the issue with attachment 144679 [details] can be reproducible back to LibreOffice 3.3
(In reply to Bartosz from comment #14) > After resave minimal document with MS PowerPoint, the LibreOffice opening > PPTX file properly. > Unfortunately I was unable to find what exactly causes this wrong import. > I will keep investigating it. Hi Bartosz, Did you find anything interesting when you investigated this issue? it seems it affects any property using a colour followed by an auto colour @Ilmari, I think it's good to have it in the PPTX team's radar
(In reply to Xisco Faulí from comment #17) > (In reply to Bartosz from comment #14) > > After resave minimal document with MS PowerPoint, the LibreOffice opening > > PPTX file properly. > > Unfortunately I was unable to find what exactly causes this wrong import. > > I will keep investigating it. > > Hi Bartosz, > Did you find anything interesting when you investigated this issue? > it seems it affects any property using a colour followed by an auto colour > > @Ilmari, I think it's good to have it in the PPTX team's radar I think ( not 100% sure ) the problem might be in https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/textrun.cxx?r=a7f28581#78, where aPropSet is not reset properly. @Mark, since you fixed bug 106638 ( also fixed in that method ) I thought you might be interested in this issue...
*** Bug 131056 has been marked as a duplicate of this bug. ***
Sample in this bug is ODP attachment 144678 [details]. Another sample with underline color that may be the same issue is attachment 158004 [details].
Verified in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a98971ac975e19efa2336b608506eefa85ce2485 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL
The problem with attachment 144679 [details] was fixed by author Vasily Melenchuk <vasily.melenchuk@cib.de> 2021-08-27 18:10:15 +0300 committer Thorsten Behrens <thorsten.behrens@allotropia.de> 2021-09-10 12:27:14 +0200 commit 14d299f8f1e19b39dfa81e143762c6b277c1ae9a (patch) tree e6b97cccfe5d92793bf10f8e30d491eb25e1cce3 parent 3c02fe5ca8e12dc52531367a1ac1c0802518d133 (diff) tdf#126426: support for hyperlinks in TextParagraphContext
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0350c84a5e6bf7c48cd77c7fcb29a3bbdc1d8c8d tdf#119649: sd_import_tests2: Add unittest It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Timur from comment #20) > Sample in this bug is ODP attachment 144678 [details]. It's Verified for PPTX but it should also be checked for PPT, which I did and it opens OK both in LO and MSO. > Another sample with underline color that may be the same issue is attachment > 158004 [details]. Not the same, not resolved, mentioned in bug 130498 but it didn't belong there. Underline differently wrong for PPT and PPTX. I reuse bug 65278 for PPT and I'll See Also there PPTX version.
Wow, thanks to all involved!