Download it now!
Bug 119735 - Calc: Change .uno: Command for Column Break
Summary: Calc: Change .uno: Command for Column Break
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks: UNO-Command-New
  Show dependency treegraph
 
Reported: 2018-09-06 17:24 UTC by Rizal Muttaqin
Modified: 2020-03-18 13:44 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Proposed new different column break icons (8.81 KB, image/png)
2018-09-06 17:25 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2018-09-06 17:24:12 UTC
Description:
Calc has same .uno: command for column break with the one for Writer (.uno:InsertColumnBreak). As both implementation is different between two, I suggest to create one more of .uno: command for Calc to make it specific.

I have created two different kind of icon and need other contributor to change the .uno: command.

Steps to Reproduce:
1. Open up Calc
2. Click Sheet menu > Insert Page Break > [Row Break] or [Column Break]
3.

Actual Results:
Calc use same .uno: command for Column break with the one used in Writer

Expected Results:
Calc use different .uno: command for Column break with the one used in Writer


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Rizal Muttaqin 2018-09-06 17:25:42 UTC
Created attachment 144722 [details]
Proposed new different column break icons

Just need a more specific .uno: command
Comment 2 Heiko Tietze 2018-10-12 11:09:04 UTC
Writer adds a line break (Shift+Enter) on InsertColumnBreak https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/wrtsh1.cxx#888 and nothing on InsertRowBreak
(not sure that it works as designed because when a cell or column is selected nothing happens; col/row break makes not much sense to me in Writer anyway)

So I agree on splitting the commands if there was no good reason at the implementation => needsDevAdvice
Comment 3 Heiko Tietze 2018-11-01 09:58:17 UTC
Maxim, can you confirm that splitting the commands makes sense?
Comment 4 Heiko Tietze 2019-03-12 09:58:11 UTC
Removing needsUX as of comment 2. Eike, do you have an opinion here?