Bug 130783 - Change .uno: command for Protect Cells in Writer from .uno:Protect to .uno:CellProtection
Summary: Change .uno: command for Protect Cells in Writer from .uno:Protect to .uno:Ce...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: UNO
  Show dependency treegraph
 
Reported: 2020-02-19 21:12 UTC by Rizal Muttaqin
Modified: 2020-04-08 06:21 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2020-02-19 21:12:33 UTC
Step to reproduce

1. Insert table to a writer document than place cursor then we have Table toolbar activated
2. See fifth icon from left, there is Protect Cells icon


Currently, the Protect Cells icon in Writer's Table toolbar use .uno:Protect command while this same .uno: command in Calc is being used for Protect Sheet. As the icon designer I choose to draw .uno:Protect command for Protect Sheet then the icon which reflect "sheet" does not fit in Writer.

In Calc, we had already have .uno:CellProtection for Cell Protection function so why not switch current .uno:Protect in Writer to use .uno:CellProtection in Calc instead? So we would have consistent icons accross module.

Yes I know the safest method is using just "padlock" without other elements but I personally don't like such image representation without context. Every lock/protect and unlock/unprotect _should_ have context.
Comment 1 Rizal Muttaqin 2020-02-20 21:08:30 UTC
(In reply to Rizal Muttaqin from comment #0)

> 2. See fifth icon from left, there is Protect Cells icon

I mean from right
Comment 2 Rizal Muttaqin 2020-03-11 13:54:06 UTC
(In reply to Rizal Muttaqin from comment #0)
> Currently, the Protect Cells icon in Writer's Table toolbar use .uno:Protect
> command while this same .uno: command in Calc is being used for Protect
> Sheet. As the icon designer I choose to draw .uno:Protect command for
> Protect Sheet then the icon which reflect "sheet" does not fit in Writer.


To see the real example, please use Sukapura icon which show a real sheet in the icon.
Comment 3 Heiko Tietze 2020-03-16 17:02:50 UTC
We discussed the topic in the design meeting and at the ESC:


 + <node oor:name=".uno:Protect" oor:op="replace"> exists for Writer and Calc
 + due to the same names the command take the same icons, which is the issue here
 + request is to rename one of the two UNO commands

 + good to keep the old name working, in-doc macros and extensions can refer to the old name (Miklos/ESC)

So yes to a new command but keep the current. Miklos/Maxim, could you please add a code pointer?
Comment 4 Timur 2020-04-07 16:56:21 UTC Comment hidden (obsolete)
Comment 5 Rizal Muttaqin 2020-04-07 23:46:15 UTC
(In reply to Timur from comment #4)
> I don't know if we are at the same, but now there are different icons in
> Writer to protect and unprotect cells. 
> Should be a single toggle one, as in Calc.

I don't talk about the similarities between two. If you try the extension attached yes the unprotect cell use single opened/unlocked padlock. I can easily change it and it will have no issue all since the command (.uno:UnSetCellsReadOnly) is a unique command. I talked about Protect Cell command here.
Comment 6 Timur 2020-04-08 05:35:12 UTC
I didn't understand. Should that be a separate bug to replace 2 icons with 1 toggle?
Comment 7 Rizal Muttaqin 2020-04-08 06:21:12 UTC
(In reply to Timur from comment #6)
> I didn't understand. Should that be a separate bug to replace 2 icons with 1
> toggle?

Your request about unifying the two commands to be a toggle might not covered in this bug report. I'm pretty sure it should be another bug report.