Bug 119812 - Non-functional "Windows Share" item shown among server types in File Services dialog on Windows
Summary: Non-functional "Windows Share" item shown among server types in File Services...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: lowest trivial
Assignee: Aditya Sahu
URL:
Whiteboard: target:6.3.0
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Blocks:
 
Reported: 2018-09-11 17:27 UTC by Mike Kaganski
Modified: 2022-11-18 05:52 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2018-09-11 17:27:47 UTC
On Windows, "Windows Share" server type is non-functional (there's no smb protocol handler there, which makes share enumeration a no-op). Though, the item is shown in the File Services dialog, and it's possible to create such non-functional services. The item needs to be hidden in Windows builds.

The item is pre-defined in svtools/uiconfig/ui/placeedit.ui, and its handler is assigned in PlaceEditDialog::InitDetails (svtools/source/dialogs/PlaceEditDialog.cxx) - search for comment "// Create Windows Share control".
Comment 1 Roman Kuznetsov 2018-09-12 19:22:48 UTC
confirm in LO 6.1.1.1 on Windows 10
Comment 2 Aditya Sahu 2019-01-09 22:06:48 UTC Comment hidden (obsolete)
Comment 3 Aditya Sahu 2019-01-09 22:12:08 UTC Comment hidden (obsolete)
Comment 4 Commit Notification 2019-02-02 09:38:04 UTC
Aditya committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f875364d5bf2207410814efe39e1b41f3c283356%5E%21

tdf#119812: Hide "Windows Share" server type in Windows OS.

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Mosi Morin 2019-07-20 06:29:26 UTC Comment hidden (spam)