Every service in "remote files" shows the "share" field - but only in Windows.
I assume it can be fixed in PlaceEditDialog.cxx with something like this:
// Remove Windows Share entry from dialog on Windows OS, where it's non-functional
m_xLBServerType->remove(nPos + 3);
I don't have a Windows compile/bibisect environment, so I can't test this.
Created attachment 175808 [details]
addRemoteService-extraShareInWindows.jpg: all services add this extra field
likely can be seen in bibisect 6.3 with
Author: Aditya on Thu Jan 31 03:50:55 2019 +0530
tdf#119812: Hide "Windows Share" server type in Windows OS.
Steps to access these dialogues
1.) File menu - open remote (or save remote)
2.) manage service - add or edit
(In reply to Justin L from comment #2)
> likely can be seen in bibisect 6.3 with
> commit f875364d5bf2207410814efe39e1b41f3c283356
> Author: Aditya on Thu Jan 31 03:50:55 2019 +0530
> tdf#119812: Hide "Windows Share" server type in Windows OS.
Absolutely correct. The question is - why? The change doesn't touch the control directly. So there should be some code that is not not executing that hides it...
Setting to invisible is done in the CTOR (which is no longer being run).
m_pDialog->m_xEDShare->connect_changed( LINK( this, DetailsContainer, ValueChangeHdl ) );
set_visible( false );
(In reply to Justin L from comment #5)
Right! And SmbDetailsContainer::set_visible also operates on other elements, too.
Maybe another (IMO cleaner) approach would be to set all the elements to hidden in the UI file, so that every provided explicitly activate them as needed...
Re-evaluating the EasyHack in 2023
This EasyHack is still relevant. The issue is still reproducible with comparing Windows and Linux for LO 7.6 dev:
Version: 18.104.22.168.alpha0+ (X86_64) / LibreOffice Community
Build ID: ed0372bac123b402fe3cd694a455e8328117752d
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: fa-IR (fa_IR); UI: fa-IR