Bug 119827 - LibreOffice doesn’t interpret GtkBuilder’s “scale” attribute under Windows or gen, to indicate secondary labels in .ui’s
Summary: LibreOffice doesn’t interpret GtkBuilder’s “scale” attribute under Windows or...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: lowest enhancement
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.5.0 target:7.4....
Keywords:
Depends on:
Blocks: 150045
  Show dependency treegraph
 
Reported: 2018-09-12 16:56 UTC by Adolfo Jayme Barrientos
Modified: 2023-01-02 14:06 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Smaller label (−1 pt) under Linux with welded dialog (3.82 KB, image/png)
2018-09-12 16:58 UTC, Adolfo Jayme Barrientos
Details
No effect under Windows: the label is the same size as others (4.02 KB, image/png)
2018-09-12 16:58 UTC, Adolfo Jayme Barrientos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adolfo Jayme Barrientos 2018-09-12 16:56:27 UTC
Some information in our UI is secondary or complementary, and as such it doesn’t need to be as prominent as other elements. GtkBuilder’s .ui files allow designers to create a visual hierarchy by means of the “scale” Pango attribute and style classes like “dim-label”. Together, they help to create visually clearer UIs.

For instance, in a welded UI file like specialcharacters.ui (cui module), I can add the following markup to the “charname” GtkLabel…:

     <style>
       <class name="dim-label"/>
     </style>
     <attributes>
       <attribute name="scale" value="0.8"/>
     </attributes>

… to make it smaller (by 1 pt) and dimmed. This works well under Linux, but doesn’t have any effect under Windows, and I presume under macOS as well (didn’t test). I would like that, under Windows, LibreOffice at least interpret the scale part to make some secondary-info labels smaller. I don’t ask for the dimmed style to be reimplemented into LO because I know such styles belong to Gtk+ themes <rant>(which apparently Gtk+ developers intend to drop because GNOME loves to sabotage itself as a viable, flexible platform)</rant>.
Comment 1 Adolfo Jayme Barrientos 2018-09-12 16:58:02 UTC
Created attachment 144821 [details]
Smaller label (−1 pt) under Linux with welded dialog
Comment 2 Adolfo Jayme Barrientos 2018-09-12 16:58:39 UTC
Created attachment 144822 [details]
No effect under Windows: the label is the same size as others
Comment 3 Buovjaga 2018-10-05 10:56:15 UTC
I believe you -> NEW
Comment 4 Caolán McNamara 2022-06-08 11:34:53 UTC
https://gerrit.libreoffice.org/c/core/+/135493 for supporting scale
Comment 5 Commit Notification 2022-06-08 12:23:28 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f17d42f251bf4a20b4192c16fa007226dcf17ed

tdf#119827 implement GtkBuilder "scale" property for font size

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Adolfo Jayme Barrientos 2022-06-08 14:26:25 UTC
Go raibh maith agat, Caolán!! ❤️
Comment 7 Commit Notification 2022-06-11 17:41:04 UTC
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0ebbe1f0080f474fd583e5912c9605e6fb2e13d5

Related: tdf#119827 Add “scale” property for non-interactive labels in more places

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-06-11 17:42:15 UTC
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/cb1a89591afd16b4b8faef526a2269e388764a70

Related: tdf#119827 Add “scale” property for non-interactive labels in more places

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Stéphane Guillou (stragu) 2023-01-02 14:06:17 UTC
Fix verified in:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you both!