Bug 120135 - Currency icon must not show the dollar sign
Summary: Currency icon must not show the dollar sign
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0 target:6.3.0
Keywords:
Depends on:
Blocks: Icon-Theme-Breeze Icon-Theme-Colibre Icon-Theme-Elementary Icon-Theme-Sifr-old
  Show dependency treegraph
 
Reported: 2018-09-26 13:54 UTC by Heiko Tietze
Modified: 2019-04-30 22:10 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
How in looks in gtk3 master with elementary (6.50 KB, image/png)
2018-10-04 16:16 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2018-09-26 13:54:48 UTC
The icon themes Breeze, Sifr, Elementary, and Colibre show a dollar sign as icon for the currency button. This is not appropriate to an international product and should get reconsidered.
Comment 1 Adolfo Jayme Barrientos 2018-09-26 14:13:43 UTC
I’d favor Eike’s suggestion of metaphor at bug 100849 comment 25 (banknote plus coin).
Comment 2 V Stuart Foote 2018-09-26 15:02:24 UTC
Absent an ability to stamp a locale appropriate currency symbol other than the "$" onto the button face--as was agreed to by UX/Design team--the currency icon from each theme need attention dropping the "$"--I would suggest rifs on the "note & coins" from Tango.

The "note & coins" in Tango is readable. But the stacked coins in Karasa Jaga are a little hard to read--hay bales?, no coins.
Comment 3 Commit Notification 2018-09-28 09:31:20 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8dac53d5cec1984590f7ef51a4a773711ca2d01d

elementary: Fix for tdf#120135, improve existing and many more

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2018-10-04 16:16:39 UTC
Created attachment 145389 [details]
How in looks in gtk3 master with elementary
Comment 5 andreas_k 2019-01-06 08:49:52 UTC
fixed in breeze, colibre, elementary and kj.
Comment 6 BogdanB 2019-01-14 16:33:15 UTC
Verified on Breeze, Colibre, Elementary
Version: 6.2.1.0.0+
Build ID: d94f96c56d858cfd20bd7fac0c357ea0ecc24785
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-6-2, Time: 2019-01-12_20:23:00
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded


As a note: it is not solved on Sifr. It is a dollar.
Comment 7 Commit Notification 2019-04-29 05:37:41 UTC
Matthias Freund committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/c4d8b4ecd82fde107d12f6b606bcbd023cfdd7cb%5E%21

tdf#120135 Currency icon must not show the dollar sign SIFR

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Tomaz Vajngerl 2019-04-29 08:17:33 UTC
Minimize the SVGs before committing!
Comment 9 Commit Notification 2019-04-30 22:10:55 UTC
Matthias Freund committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/29be6d1512375d637b41ea646be9e3ece715bba8%5E%21

tdf#120135 Currency icon must not show the dollar sign SIFR

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.