Bug 120722 - Handles are not scaled properly on higher resolutions
Summary: Handles are not scaled properly on higher resolutions
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.1.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: HiDPI
  Show dependency treegraph
 
Reported: 2018-10-20 07:34 UTC by 00
Modified: 2018-12-05 08:27 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
In the drawing, the functions of normal preset contact and magnify preset contact are added. 1 (12.73 KB, image/png)
2018-10-20 07:37 UTC, 00
Details
In the drawing, the functions of normal preset contact and magnify preset contact are added. 2 (66.24 KB, image/png)
2018-10-20 07:37 UTC, 00
Details
Version 2 (69.33 KB, image/png)
2018-10-26 06:29 UTC, 00
Details
document to estimate size of handles (9.68 KB, application/vnd.oasis.opendocument.graphics)
2018-10-26 12:51 UTC, Regina Henschel
Details
Regina Henschel (88.00 KB, image/png)
2018-10-26 15:32 UTC, 00
Details
Regina Henschel (63.41 KB, image/png)
2018-10-26 15:43 UTC, 00
Details
Regina Henschel (195.32 KB, image/png)
2018-10-26 16:34 UTC, 00
Details
handle for 96dpi (1.12 KB, image/png)
2018-10-26 17:00 UTC, Regina Henschel
Details
The third edition (change to "circle center point" + "round frame" is better) (33.68 KB, image/png)
2018-11-05 05:51 UTC, 00
Details
"Contact" is still too small, please zoom in 0.5 times, zoom in 0.5 times, do not be afraid that the "contact" and "contact" will be stuck, because the enlarged display will increase the distance of t (116.43 KB, image/png)
2018-11-30 08:03 UTC, 00
Details
If you use a solid "contact", don't have a "frame" that looks better. (11.35 KB, image/png)
2018-11-30 09:23 UTC, 00
Details
Change to no outer frame (no lines). (9.96 KB, image/png)
2018-11-30 10:04 UTC, 00
Details
See if it can be changed, there is no "outer frame", "transparency" 50%. (13.44 KB, image/png)
2018-12-01 09:29 UTC, 00
Details
Perfect contact (this picture, please hand over to the designer, after the transfer, please reply to the notice, thank you.) (38.70 KB, image/png)
2018-12-04 07:09 UTC, 00
Details

Note You need to log in before you can comment on or make changes to this bug.
Description 00 2018-10-20 07:34:28 UTC
Description:
"Normal preset contact" is the current contact. 
"Magnify the preset contact" is a 0.3 cm red frame contact. 

Note: 
1, "normal preset contact", the contact is too small and not good. 
2, "Magnify the preset contact", the contact is better, but the contact is 
too large, the position is too close, and will overlap. 
3. According to the use environment, switching between “normal preset 
contact” and “magnifying preset contact” is the best way to improve working 
speed. 


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 00 2018-10-20 07:37:05 UTC
Created attachment 145847 [details]
In the drawing, the functions of normal preset contact and magnify preset contact are added.  1
Comment 2 00 2018-10-20 07:37:56 UTC
Created attachment 145848 [details]
In the drawing, the functions of normal preset contact and magnify preset contact are added.  2
Comment 3 00 2018-10-26 06:29:58 UTC
Created attachment 146021 [details]
Version 2
Comment 4 00 2018-10-26 06:37:50 UTC
Version 2
Changed to a red dot inside the red box.
Comment 5 Heiko Tietze 2018-10-26 07:59:32 UTC
You are talking about "Points" (also enabled with F8) that toggles the segment connectors on/off. It's not the glue point feature. (Btw, not all systems show the icons in menus and perhaps you can switch the UI language to English for screenshots.)

I disagree with enlarging the dots. First of all there is no use case like "For disabled users it's hard to pick up the tiny dots and we should support accessibility". Furthermore the big red squares are way too obtrusive to me and I would always switch off points when it gets to this size.

Or have I missed some aspect, maybe zoom? From the summary '...functions of "normal preset contact" and "magnify preset contact" are added' the request is not clear to me,
Comment 6 Regina Henschel 2018-10-26 12:51:31 UTC
Created attachment 146031 [details]
document to estimate size of handles

The attachments show, that the reporter uses a display setting of (I guess) 150%. That is the default for HiDPI monitors on Windows 10. There are other complains (not sure whether here or on Ask), that for 4k monitors the handles are too small. 

(You can see, that a HiDPI monitor is used, because the handles are wrongly drawn. There exists an issue about that, but I do not find it.)

和尚蟹: I want to estimate, how large your current handles are. Please open my attachment. It is a small document with a 0.5mm grid. Show it at 2000% zoom, click on the blue line and make a screen shot.
Comment 7 00 2018-10-26 15:19:11 UTC
(In reply to Heiko Tietze from comment #5)
> 您正在談論打開/


Not necessarily red, the color can be changed.
Not necessarily 0.3 cm, the size can be changed.



This design is a humanized design.
You don't think so, but others think it is needed.



Humanize
Humanize
Humanize
Comment 8 Heiko Tietze 2018-10-26 15:24:47 UTC
(In reply to 和尚蟹 from comment #7)
> You don't think so, but others think it is needed.

I don't want to discourage you. In case you totally disagree with my opinion we can discuss your input in the design meeting and have more people consider it. Just drop a note at the comments. But please also read comment 6. Maybe that makes your req
Comment 9 Heiko Tietze 2018-10-26 15:25:25 UTC
(In reply to Heiko Tietze from comment #8)
> req..
uest more clear. (Pushed the wrong key on this stupid mac keyboard, sorry)
Comment 10 00 2018-10-26 15:32:23 UTC
Created attachment 146038 [details]
Regina Henschel
Comment 11 00 2018-10-26 15:43:51 UTC
Created attachment 146039 [details]
Regina Henschel
Comment 12 00 2018-10-26 15:56:33 UTC Comment hidden (no-value)
Comment 13 00 2018-10-26 16:34:10 UTC
Created attachment 146040 [details]
Regina Henschel
Comment 14 Regina Henschel 2018-10-26 17:00:06 UTC
Created attachment 146044 [details]
handle for 96dpi

I see that "Handle at 96dpi" = 1.6 * "Handle of reporter" (approximately). That corresponds to 100% compared to 174%.

Or calculate directly: A handle has currently 9 pixel width, at 96dpi that results in 2.38mm. That is already very small. But with higher dpi, e.g. 167dpi of the reporters screen, it is only 1.4mm. That is really too small. 

Therefore I think it is a valid request to get larger handles.

This proposal adds a frame around a central square. That is not really bad as long as the white part inside is semi-transparent. There are other proposals, e.g to increase the handle size if higher dpi is used, or to enlarge the handles for higher zoom.
Comment 15 Thomas Lendo 2018-10-26 17:34:11 UTC
Is this a dupe of bug 89544 or bug 117348? I don't find other HiDPI bugs but I also thought there is at least one.

Can the handles be changed if a high dpi Screen is used? 'Normal' screens shouldn't show too big handles.
Comment 16 Thomas Lendo 2018-10-26 18:58:59 UTC
Can someone please change the summary so that everybody understands what this bug is about? I can't.
Comment 17 Heiko Tietze 2018-10-27 10:58:45 UTC
No UX issue but a bug. Code is under investigation by Armin.
Comment 18 Regina Henschel 2018-10-27 13:20:09 UTC
(In reply to Thomas Lendo from comment #15)
> Is this a dupe of bug 89544 or bug 117348?

No, those are about the grid, but this one is about the handles, which you use to resize an object.

 I don't find other HiDPI bugs but
> I also thought there is at least one.

There is a meta bug 90796.

> 
> Can the handles be changed if a high dpi Screen is used? 'Normal' screens
> shouldn't show too big handles.

That is work in progress. The current idea is to enlarge the handles according the scaling. For that purpose not the combined file markers.png is used, but a single image file for each marker. Such files are already contained in some icon-themes in the source, e.g. colibre or colibre-svg. The marker files are in core/icon-themes/<icon theme name>/svx/res. If the user has a scaling factor of e.g. 150%, LO generates a folder <installation folder>/cache/<icon theme name>/<factor>/svx/res containing the enlarged markers. You can test it, if you zip the icon theme colibre-svg from source, rename it suitable and put it into <installation folder>/share/config. Set your display to 150% and start LO.

I do not set this as duplicate, because the idea not to use a solid marker but a marker with a center dot and a frame is new.
Comment 19 00 2018-10-27 14:55:12 UTC
This problem can be solved by the method of "magnification level"

Assumed "magnification level":
Level 1 (0.3 cm).
Level 2 (1 cm).
Level 3 (2 cm).
Level 4 (3 cm).
Level 5 (4 cm).
Comment 20 Regina Henschel 2018-11-01 16:33:45 UTC
The patch https://cgit.freedesktop.org/libreoffice/core/commit/?id=f713caa6f116ee9d6f99e03a688216984cedce44 is in master. Now the single files for handles are integrated into the delivered icon-themes. Now larger handles are generated when used and cached for reuse. Please test a current developer build, whether the size of the handles is OK now. The fact, that the scaled handles might look blurry is a different issue.

This fix does not include the crop handles.
Comment 21 00 2018-11-05 05:51:02 UTC
Created attachment 146307 [details]
The third edition (change to "circle center point" + "round frame" is better)
Comment 22 Regina Henschel 2018-11-05 23:39:43 UTC
The bugtracker is not suitable to _discuss_ design. Please contact the design team. Read section "Get in contact" on https://wiki.documentfoundation.org/Design
Comment 23 00 2018-11-30 08:03:37 UTC
Created attachment 147165 [details]
"Contact" is still too small, please zoom in 0.5 times, zoom in 0.5 times, do not be afraid that the "contact" and "contact" will be stuck, because the enlarged display will increase the distance of t
Comment 24 00 2018-11-30 09:23:32 UTC
Created attachment 147167 [details]
If you use a solid "contact", don't have a "frame" that looks better.
Comment 25 00 2018-11-30 09:28:43 UTC
(In reply to 和尚蟹 from comment #24)
> 創建附件147167  [詳細信息] 
> 如果使用堅固的“聯繫人”,則沒有看起來更好的“框架”。

Don't have a "frame".
Comment 26 00 2018-11-30 10:04:43 UTC
Created attachment 147171 [details]
Change to no outer frame (no lines).
Comment 27 00 2018-12-01 09:29:06 UTC
Created attachment 147186 [details]
See if it can be changed, there is no "outer frame", "transparency" 50%.
Comment 28 00 2018-12-03 07:29:14 UTC
The ".docx" is the same as the ".doc" format. The "contact" cannot be automatically scaled.
Comment 29 00 2018-12-03 09:36:09 UTC
(In reply to 和尚蟹 from comment #28)

Wrong, I accidentally used LibreOffice 6.1 to test, sorry...
Comment 30 00 2018-12-04 07:09:49 UTC
Created attachment 147258 [details]
Perfect contact (this picture, please hand over to the designer, after the transfer, please reply to the notice, thank you.)
Comment 31 00 2018-12-05 08:27:39 UTC
I gave up, I added a new article in the following URL, please support, thank you.
https://bugs.documentfoundation.org/show_bug.cgi?id=121915