compared to LO 6.0.7 the input/msgbox is to small: Sub TEST_InputBox InputBox("MELDUNG","TITEL","BW BY BE BB HB HH HE MV NI NW RP SL SN ST SH TH") MsgBox("MELDUNG","TITEL","BW BY BE BB HB HH HE MV NI NW RP SL SN ST SH TH") End Sub
bisected with bibisect-win32-6.1, regression introduced: convert remaining InfoBox to weld::MessageDialog 05/50205/12 author Caolán McNamara <caolanm@redhat.com> Wed, 21 Feb 2018 22:20:15 +0100 (21:20 +0000) committer Caolán McNamara <caolanm@redhat.com> Sun, 25 Feb 2018 20:03:26 +0100 (20:03 +0100) commit d75144cf44779a8f6cc9bccf9b0a6328b94a5b90 tree 25b9f3c677c50ad715e1a0bc6bef3d5bf79ef957 tree parent 8d42909cd326cb26d8ba1fb383b5578f820c72ed commit | diff convert remaining InfoBox to weld::MessageDialog Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8 Reviewed-on: https://gerrit.libreoffice.org/50205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=d75144cf44779a8f6cc9bccf9b0a6328b94a5b90 7b357a6d04e07c3017c9c7886b2e436d80f951cb is the first bad commit commit 7b357a6d04e07c3017c9c7886b2e436d80f951cb Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sun Feb 25 11:18:05 2018 -0800 source d75144cf44779a8f6cc9bccf9b0a6328b94a5b90 source d75144cf44779a8f6cc9bccf9b0a6328b94a5b90 :040000 040000 84c619a289908ab8f3a32ab5fe851f6e16be871c 46eb6d846f5306aafcc977d541e3ca0fa606aeff M instdir $ git bisect log # bad: [7ee9f0665bc96bcfa34506bef9b1569e6b368708] source 22c451df33b733440f24c1feb6380d31240d55e6 # good: [29d08f54c2f71ffee4fe12dbb24c5f5cbedecfd2] source 6eeac3539ea4cac32d126c5e24141f262eb5a4d9 git bisect start 'master' 'oldest' # good: [c0dc3e12b2b5f3047c02ed9cfe2f54e3fd663273] source fa2a43c29051b1bdcd0aef2e9cebfd206a4448ce git bisect good c0dc3e12b2b5f3047c02ed9cfe2f54e3fd663273 # bad: [aa9ee79da17464e0558d7b73ef63e1e14c5ba342] source cc7ff0c141e27090ab521073b961b5eeeb4d693e git bisect bad aa9ee79da17464e0558d7b73ef63e1e14c5ba342 # bad: [282e4b2e052782ba1439586db1cfca473e9b9c2a] source dfe797e8a54f49270f25043dda5fdd95d8fbc4ff git bisect bad 282e4b2e052782ba1439586db1cfca473e9b9c2a # bad: [863e1aa59aba55cef24d47e6bc98a23707a4019a] source 1615d0eb285eeaf3da10b4ed727b776b0a28b94d git bisect bad 863e1aa59aba55cef24d47e6bc98a23707a4019a # bad: [4427ac806e4491a6340302fe60db6723333a5514] source d24dba40175256a317a3d2281c70d3240b74f4a0 git bisect bad 4427ac806e4491a6340302fe60db6723333a5514 # bad: [f5ce5a5d50e87204e1cdd68f8272cdc9282cb224] source f41a08183504a59d6ffc7a00ed7f24e6b19995ab git bisect bad f5ce5a5d50e87204e1cdd68f8272cdc9282cb224 # bad: [17d81e9d1b8ec285915b55da849d8fafe7fa69c7] source f1a11b9ce9dda2a57bc77d3bf38167a31feff8f1 git bisect bad 17d81e9d1b8ec285915b55da849d8fafe7fa69c7 # good: [8d277559ff381baa9820406a329bb2757b4580b7] source 4873f5a96d258ce5571b424bde309305a9817ac0 git bisect good 8d277559ff381baa9820406a329bb2757b4580b7 # bad: [93c1e7417e7f80bae94cfaa5cdc974ca223a5164] source 3400424877032595490f38711b5e8520ed889fee git bisect bad 93c1e7417e7f80bae94cfaa5cdc974ca223a5164 # bad: [7b357a6d04e07c3017c9c7886b2e436d80f951cb] source d75144cf44779a8f6cc9bccf9b0a6328b94a5b90 git bisect bad 7b357a6d04e07c3017c9c7886b2e436d80f951cb # good: [3bb2c92cb5b9c0c900170817b661f53d0ce6500e] source d176877bc0ccb8432e55eda2e7d620a246bccdde git bisect good 3bb2c92cb5b9c0c900170817b661f53d0ce6500e # good: [7685994ee519e51d283c146c36d8827efd75f651] source a7d7b2b49e6b63cdf22be823b8eb6e4c0ec8191f git bisect good 7685994ee519e51d283c146c36d8827efd75f651 # good: [4935cefeef3133bb7fed3fa9e68aea717e6f5ccc] source 8d42909cd326cb26d8ba1fb383b5578f820c72ed git bisect good 4935cefeef3133bb7fed3fa9e68aea717e6f5ccc # first bad commit: [7b357a6d04e07c3017c9c7886b2e436d80f951cb] source d75144cf44779a8f6cc9bccf9b0a6328b94a5b90
Created attachment 146341 [details] Comparsion before and after Title is truncated in previous versions as well... Could you please be more clear where the problem is? To me, it looks much better now than before...
Created attachment 146355 [details] input_msgbox_lo6_lo61 added a new sample Sub Main MsgBox("Error #123", 64, "LibreOffice " & GetSolarVersion) InputBox("Enter Data:", "TITLE", "ABCDEFGHIJKLMNOPQRSTUVWXYZ") End Sub both, input and msgbox should have a minimum width. IMHO lo 6.0.7 layout looks much better.
Adding Cc: to Caolán McNamara Better to hear Caolán's opinion on this...
The original input box used to be quite wide, and is now the default edit width. I can see that things might have depended on that, so https://gerrit.libreoffice.org/#/c/63099/ to make that around the same width again. The msgbox might take a little more thought.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/e9c1bbb32d6cef06c875bb8cf05a00216ea59b2e%5E%21 Related: tdf#121181 basic input box used to have a very wide edit widget It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0120dfb12bcc8f86f256f8f56410215c1828e578%5E%21 Resolves: tdf#121181 expand message boxes to show full title It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
backports to 6-1 in gerrit
Verified in Version: 6.2.0.0.alpha1+ Build ID: 3a99ae072ac170ebed8d1f5bf65913d3412fab67 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Caolán, Thanks for fixing this!
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/8ef6623c71317448acc74d5dc8648211673dce76%5E%21 Resolves: tdf#121181 expand message boxes to show full title It will be available in 6.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/c4dd14c2b4e8a4960c86e6640bf2b568f8e583f5%5E%21 Related: tdf#121181 basic input box used to have a very wide edit widget It will be available in 6.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.