Bug 121267 - SIDEBAR: border cell color isn't shown (white box)
Summary: SIDEBAR: border cell color isn't shown (white box)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium normal
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:6.3.0 target:6.2.0.1 target:6.1.4
Keywords: bibisected, bisected, regression
: 121482 (view as bug list)
Depends on:
Blocks: Sidebar-Properties
  Show dependency treegraph
 
Reported: 2018-11-08 10:14 UTC by Telesto
Modified: 2018-11-19 12:44 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (8.03 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-11-08 10:14 UTC, Telesto
Details
Bibisect log (2.89 KB, text/plain)
2018-11-08 12:51 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-11-08 10:14:45 UTC
Description:
SIDEBAR: border cell color isn't shown (white box)

Steps to Reproduce:
1. Open the attached file
2. Select the orange cell
3. Check the sidebar -> Cell Appearance (no border color)


Actual Results:
No border color

Expected Results:
Orange border color


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 6.2.0.0.alpha1+
Build ID: 6896f39ffd8a6c4b32b8f601a6a93678247456bd
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-11-05_22:40:18
Locale: nl-NL (nl_NL); Calc: CL

and in

Version: 5.4.0.0.alpha0+
Build ID: aabc5aab5af27e929a81a6036d2f470ab1f5ac4d
CPU Threads: 4; OS Version: Windows 6.29; UI Render: default; Layout Engine: new; 
Locale: nl-NL (nl_NL); Calc: CL

no repro with
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL
Comment 1 Telesto 2018-11-08 10:14:59 UTC
Created attachment 146427 [details]
Example file
Comment 2 Dieter 2018-11-08 12:25:25 UTC
I confirm this with

Version: 6.2.0.0.alpha1+ (x64)
Build ID: 8274c4c62df5b937b3f0bec9e1eeca85f3b219d4
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-22_01:47:50
Locale: en-US (de_DE); Calc: CL

but not in

Version: 4.4.7.2
Build-ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Gebietsschema: de_DE
Comment 3 Telesto 2018-11-08 12:51:03 UTC
Created attachment 146436 [details]
Bibisect log

Bisected to
author	Maxim Monastirsky <momonasmon@gmail.com>	2016-10-13 10:20:31 +0300
committer	Maxim Monastirsky <momonasmon@gmail.com>	2016-10-13 11:12:27 +0300
commit 9125a4f3f63a7f49fd307908c181e999120063e0 (patch)
tree ef7d47475a37b87cda0e97b766143ab3e4c55cb5
parent f1bae1b5c0ba7949f6a91ba938be18589f9accaa (diff)
Use FeatureStateEvent directly for status updates
... for SfxPopupWindow and SvxColorToolBoxControl (the
latter shares BorderColorStatus with SvxColorWindow_Impl,
so it was easier to convert it too).

https://cgit.freedesktop.org/libreoffice/core/commit/?id=9125a4f3f63a7f49fd307908c181e999120063e0
Comment 4 Telesto 2018-11-08 12:51:59 UTC
Adding cc: to Maxim Monastirsky
Comment 5 Maxim Monastirsky 2018-11-08 23:48:33 UTC
Turns out that missing diagonal borders also return css::table::BorderLine2 in the status update, but it's empty. So need to check that too.
Comment 6 Telesto 2018-11-09 07:44:51 UTC
(In reply to Maxim Monastirsky from comment #5)
> Turns out that missing diagonal borders also return css::table::BorderLine2
> in the status update, but it's empty. So need to check that too.

There is also bug 84129 (some line-styles don't show up), if you want to do some more work :-)
Comment 7 Maxim Monastirsky 2018-11-17 18:42:03 UTC
*** Bug 121482 has been marked as a duplicate of this bug. ***
Comment 8 Commit Notification 2018-11-17 22:43:23 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f162066d9df814086c92fa008c563ffc08daaf98%5E%21

tdf#121267 Handle missing diagonal borders

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Xisco Faulí 2018-11-19 09:27:00 UTC
Verified locally by cherry-picking the commit from gerrit...

@Maxim Monastirsky, thanks for fixing this!

Cherry-picked to
6-2: https://gerrit.libreoffice.org/#/c/63551/1
6-1: https://gerrit.libreoffice.org/#/c/63552/
Comment 10 Commit Notification 2018-11-19 12:44:30 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/6fe56989cfe0c4aa58cd8532db9cfdb5116f2a73%5E%21

tdf#121267 Handle missing diagonal borders

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2018-11-19 12:44:39 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/d01ad3a3c715900de6448c3010d41f3b75fb6103%5E%21

tdf#121267 Handle missing diagonal borders

It will be available in 6.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.