Bug 121270 - GTK3: features dialog is not resized automatically to show all elements
Summary: GTK3: features dialog is not resized automatically to show all elements
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords: bibisected, regression
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2018-11-08 11:57 UTC by Xisco Faulí
Modified: 2018-12-18 16:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
How it looks (12.91 KB, image/png)
2018-11-08 11:57 UTC, Xisco Faulí
Details
How it should look (34.49 KB, image/png)
2018-11-08 11:58 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-11-08 11:57:43 UTC
Created attachment 146432 [details]
How it looks

STR:
1. Open writer
2. Format - Character
3. Fonts tab and select Noto Sans
4. Click on features button

-> Many options are hidden by default. the dialog needs to be resized in order to see them. Not reproducible with GTK or GEN

Reproduced in

Version: 6.2.0.0.alpha1+
Build ID: 1cfa1d9e1041b0e82d9be90847c428adfd01476e
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded
Comment 1 Xisco Faulí 2018-11-08 11:58:08 UTC
Created attachment 146433 [details]
How it should look
Comment 2 Xisco Faulí 2018-11-08 12:09:17 UTC
This is related to bug 120045.
Before https://cgit.freedesktop.org/libreoffice/core/commit/?id=842c71a1fae1def3e8b694ae3b820b34ad26bce4 it was displayed correctly.
The problem is reproducible after http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e17cdbca0738eeecbda7ed8f60f1e988c68d7bc

Adding Cc: to Caolán McNamara
Comment 3 Caolán McNamara 2018-11-08 14:48:56 UTC
looks fine in gtk 3.22, so possibly that propagate_natural_height thing
Comment 4 Caolán McNamara 2018-11-08 15:28:03 UTC
yeah, turning that off in my version gives what you get. I think I have a hackaround for the older version which is "good enough"
Comment 5 Commit Notification 2018-11-08 15:40:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/3d70b1253f964fb75cd4b5915b8dd031ee54d5c7%5E%21

Resolves: tdf#121270 use never scrollbar policy for gtk 3.18

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 BogdanB 2018-11-15 16:43:10 UTC
Works as expected.

Verified on:
Version: 6.2.0.0.alpha1+
Build ID: 7eb71f84db2f2d9a6e79a42d25bb676cf1018a90
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-11-12_17:12:50
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded