Bug 121497 - UI: "Save As" Changing File Format Type in Windows
Summary: UI: "Save As" Changing File Format Type in Windows
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha1+
Hardware: All Windows (All)
: high major
Assignee: Ilhan Yesil
URL:
Whiteboard: target:6.3.0 target:6.2.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-11-18 19:33 UTC by Luke
Modified: 2018-12-10 10:55 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2018-11-18 19:33:39 UTC
When working with a non-ODF document, LibreOffice silently changes the file type. This is not how any other Office Suite functions. We should not change format without prompting the user.  

Steps to Reproduce:
1. Open non-ODF document such as .docx, .doc, xlsx, ppt...
2. File->Save As 

Expect Result:
Save As File Type = Same as Original File

Actual Result:
Save As File Type is silently changed to equivalent ODF format. 

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 587ef41f75b8ea0bcd03366178d42a324dcf481c
Bad

Version: 6.2.0.0.alpha1+ (x64)
Build ID: 0ee11c3f55ec1285d8febc065bda44224052eaae
Good
Comment 1 Luke 2018-11-19 04:29:28 UTC
Version: 6.2.0.0.alpha1+ Build ID: a20a2d7e0d28658f2d9089da076961a599833a28
TinderBox: Win-x86@42, Branch:master, Time: 2018-11-12_22:51:20
Good

Version: 6.2.0.0.alpha1+ Build ID: 85dba18a3d3644a4ac49bd32ea106a4d69159fb4
TinderBox: Win-x86@42, Branch:master, Time: 2018-11-13_23:59:01
Bad
Comment 2 Timur 2018-11-19 08:55:03 UTC
New.
Comment 3 Xisco Faulí 2018-11-19 11:20:40 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1b50fa88b148739a7b192ba70f08af2c6e326fd2

author	Ilhan Yesil <ilhanyesil@gmx.de>	2018-09-10 16:01:31 +0200
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2018-11-13 17:54:52 +0100
commit 1b50fa88b148739a7b192ba70f08af2c6e326fd2 (patch)
tree 18109155d881e346fdbcce222da426f7bd7adced
parent afd4f48d164ca72a024159e0c6b7a49147351f64 (diff)
tdf#119747 FileSaveDialog: Windows dialog shows only one extension.

Bisected with: bibisect-win32-6.2

Adding Cc: to Ilhan Yesil
Comment 4 Commit Notification 2018-11-20 10:55:59 UTC
Ilhan Yesil committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/c444eb7934d4a3c190e1d060805d9d175c1a9127%5E%21

tdf#121497 "Save As": File Format Type unchanged in Windows

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2018-11-20 21:45:28 UTC
Ilhan Yesil committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/02a5cbb9814dc224114dfbf3bc0b6c53658450c9%5E%21

tdf#121497 "Save As": File Format Type unchanged in Windows

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Luke 2018-11-29 01:27:07 UTC
For .docx files, when I "save as" and change the name to something new, the format being reset to .odt.
Comment 7 Luke 2018-12-01 04:04:56 UTC
Thorsten,
Can we revert these commits. The "save as" behavior is so broken under windows, it's interfering with my ability to do QA. I can't even round trip a .docx to test another bug fix.
Comment 8 Commit Notification 2018-12-06 12:50:11 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/1d427cd700704bc80378e250d3350b505e4413bd%5E%21

Revert "tdf#121497 "Save As": File Format Type unchanged in Windows"

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2018-12-10 10:55:12 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/3b03604d1bb48fc1c1337307d0ba259dca9fbf1e%5E%21

Revert "tdf#121497 "Save As": File Format Type unchanged in Windows"

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.