Bug 119747 - FileSaveDialog: Superfluously two extensions under Windows shown (e.g. (.odt) (*.odt)
Summary: FileSaveDialog: Superfluously two extensions under Windows shown (e.g. (.odt)...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All Windows (All)
: medium normal
Assignee: Ilhan Yesil
URL:
Whiteboard: target:6.2.0 target:6.3.0 target:6.2.0.1
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-07 12:21 UTC by Ilhan Yesil
Modified: 2018-12-12 18:43 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
file_save_extensions_aoo_415 (64.00 KB, image/jpeg)
2018-09-07 16:45 UTC, Oliver Brinzing
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilhan Yesil 2018-09-07 12:21:39 UTC
Description:
In the save file dialog, the list of file types has doubled extension types like:
 ODF Text Document (.odt) (*.odt). The second extension is superfluous.

Steps to Reproduce:
1. Open/Create an odt document
2. Select "Save as..." in the menu


Actual Results:
All file types are listed with two extensions instead one

Expected Results:
All file types are listed with one extension


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Oliver Brinzing 2018-09-07 16:45:36 UTC
Created attachment 144743 [details]
file_save_extensions_aoo_415

confirmed, inherited from aoo
Comment 2 Jan-Marek Glogowski 2018-09-08 00:49:46 UTC
Currently we don't know, if a system file dialog shows or hides the filter strings (the *.odt). The first "(.odt)" is part of the description string.

On most platform the filter itself is hidden, so a user just sees the "(.odt)".

Guess not hard to implement; I'm just not sure where to put the info (SalData or an extended interface).
Comment 3 himajin100000 2018-09-24 15:39:11 UTC
Are there some people who can give Code-Review+2 aware of Ilhan Yesil's submission?
https://gerrit.libreoffice.org/#/c/60268/
Comment 4 Commit Notification 2018-11-13 16:55:16 UTC
Ilhan Yesil committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/1b50fa88b148739a7b192ba70f08af2c6e326fd2%5E%21

tdf#119747 FileSaveDialog: Windows dialog shows only one extension.

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Timur 2018-11-28 08:33:02 UTC
As I wrote in Bug 121569, I think this was wrongfully confirmed without UX and all those should be reverted.
Comment 6 Heiko Tietze 2018-11-30 09:11:04 UTC
(In reply to Timur from comment #5)
> As I wrote in Bug 121569, I think this was wrongfully confirmed without UX
> and all those should be reverted.

Compliance with the OS is what we aim for. So if the dialog usually shows just the file type name and hides the extension we should do that too. So it's more a dev topic to make have a safe implementation. But let's see how bug 12569 progresses.
Comment 7 himajin100000 2018-11-30 09:32:22 UTC
It seems I have read the report too hastily and misunderstood. I will re-read it.
Comment 8 Commit Notification 2018-12-06 12:51:42 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/38a47bc3a4f618da4613968d28c08c8dda064cea%5E%21

Revert "tdf#119747 FileSaveDialog: Windows dialog shows only one extension."

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2018-12-06 12:51:48 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f553e34aff94fd9bce9cce77e0a723021be7c38a%5E%21

tdf#119747 FileSaveDialog: remove duplicate extension on Windows

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2018-12-10 10:55:21 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/b836f8241d6eaf0a4969341084fa8bfe3bdf0586%5E%21

Revert "tdf#119747 FileSaveDialog: Windows dialog shows only one extension."

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2018-12-10 10:55:28 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/414246683899928014ea11ec07caebdfdf8aaee4%5E%21

tdf#119747 FileSaveDialog: remove duplicate extension on Windows

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Heiko Tietze 2018-12-12 18:43:28 UTC
*** Bug 74443 has been marked as a duplicate of this bug. ***